Issue 6249 in pharo: spotlight enhancements

Status: Accepted
Owner: ----
Labels: Milestone-2.0 Type-Feature

New issue 6249 by [hidden email]: spotlight enhancements
http://code.google.com/p/pharo/issues/detail?id=6249

- shift+enter show/close restored
- small improvements to ro UI (thanks Fernando)
- renamed to SpotlightMorph to match Morph conventions


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #1 on issue 6249 by [hidden email]: spotlight enhancements
http://code.google.com/p/pharo/issues/detail?id=6249

in SLICE-Issue-6249-spotlight-enhancements-EstebanLorenzano.1

(except the rename... )


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #2 on issue 6249 by [hidden email]: spotlight enhancements
http://code.google.com/p/pharo/issues/detail?id=6249#c2

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #3 on issue 6249 by [hidden email]: spotlight enhancements
http://code.google.com/p/pharo/issues/detail?id=6249#c3

Monkey went bananas:
--------------------
Error while loading  
SLICE-Issue-6249-spotlight-enhancements-EstebanLorenzano.1 from  
http://ss3.gemstone.com/ss/PharoInbox:
        UndeclaredVariableWarning
  1: EncoderForV3PlusClosures(Encoder)>>undeclared:
  2: Parser>>correctVariable:interval:
  3: [self
                        correctVariable: varName
                        interval: (varStart to: varEnd)] in Parser>>variable
  4: [(self
                                lookupInPools: name
                                ifFound: [:assoc | varNode := self global: assoc name: name])
                        ifTrue: [varNode]
                        ifFalse: [^ action value]] in  
EncoderForV3PlusClosures(Encoder)>>encodeVariable:sourceRange:ifUnknown:
  5: Dictionary>>at:ifAbsent:
  6: EncoderForV3PlusClosures(Encoder)>>encodeVariable:sourceRange:ifUnknown:
  7: Parser>>variable
  8: Parser>>expression
  9: Parser>>statements:innerBlock:blockNode:
10: Parser>>statements:innerBlock:
        ...
----------------------------------------------------------
Loaded Source: SLICE-Issue-6249-spotlight-enhancements-EstebanLorenzano.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20180-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.161 uuid:  
8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul  3 2012,  
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.161 uuid:  
8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul  3 2012,  
https://git.gitorious.org/cogvm/blessed.git Commit:  
8028952c1242f72b6d078b8161f310e3bf0cd365 Date: Tue Jul 3 16:26:14 2012  
+0200 By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #4 on issue 6249 by [hidden email]: spotlight enhancements
http://code.google.com/p/pharo/issues/detail?id=6249

uh? what does that means?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 6249 by [hidden email]: spotlight enhancements
http://code.google.com/p/pharo/issues/detail?id=6249

It means that somewhere in your slice you refer to an undeclared variable
"UndeclaredVariableWarning:"


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 6249 by [hidden email]: spotlight enhancements
http://code.google.com/p/pharo/issues/detail?id=6249

mmm... but that was true before, not after :(


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #7 on issue 6249 by [hidden email]: spotlight enhancements
http://code.google.com/p/pharo/issues/detail?id=6249

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #8 on issue 6249 by [hidden email]: spotlight enhancements
http://code.google.com/p/pharo/issues/detail?id=6249#c8

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #9 on issue 6249 by [hidden email]: spotlight enhancements
http://code.google.com/p/pharo/issues/detail?id=6249#c9

Monkey went bananas:
--------------------
Error while loading  
SLICE-Issue-6249-spotlight-enhancements-EstebanLorenzano.1 from  
http://ss3.gemstone.com/ss/PharoInbox:
        UndeclaredVariableWarning
  1: EncoderForV3PlusClosures(Encoder)>>undeclared:
  2: Parser>>correctVariable:interval:
  3: [self
                        correctVariable: varName
                        interval: (varStart to: varEnd)] in Parser>>variable
  4: [(self
                                lookupInPools: name
                                ifFound: [:assoc | varNode := self global: assoc name: name])
                        ifTrue: [varNode]
                        ifFalse: [^ action value]] in  
EncoderForV3PlusClosures(Encoder)>>encodeVariable:sourceRange:ifUnknown:
  5: Dictionary>>at:ifAbsent:
  6: EncoderForV3PlusClosures(Encoder)>>encodeVariable:sourceRange:ifUnknown:
  7: Parser>>variable
  8: Parser>>expression
  9: Parser>>statements:innerBlock:blockNode:
10: Parser>>statements:innerBlock:
        ...
----------------------------------------------------------
Loaded Source: SLICE-Issue-6249-spotlight-enhancements-EstebanLorenzano.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20182-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.161 uuid:  
8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul  3 2012,  
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.161 uuid:  
8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul  3 2012,  
https://git.gitorious.org/cogvm/blessed.git Commit:  
8028952c1242f72b6d078b8161f310e3bf0cd365 Date: Tue Jul 3 16:26:14 2012  
+0200 By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 6249 by [hidden email]: spotlight enhancements
http://code.google.com/p/pharo/issues/detail?id=6249

There is another spotlight change in Issue 6239


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #11 on issue 6249 by [hidden email]: spotlight enhancements
http://code.google.com/p/pharo/issues/detail?id=6249

trying again... should not be part of spotlight but somewhere else


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #12 on issue 6249 by [hidden email]: spotlight enhancements
http://code.google.com/p/pharo/issues/detail?id=6249

in SLICE-Issue-6249-spotlight-enhancements-EstebanLorenzano.3


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #13 on issue 6249 by [hidden email]: spotlight enhancements
http://code.google.com/p/pharo/issues/detail?id=6249

in 2.0 191


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker