Issue 6274 in pharo: another step to remove StringHolder hierarchy element

Status: Accepted
Owner: [hidden email]
Labels: Type-Bug

New issue 6274 by [hidden email]: another step to remove  
StringHolder hierarchy element
http://code.google.com/p/pharo/issues/detail?id=6274

Ben I worked on the integration of the spec version of the dualchangesorter.
Can you have a look?

BTW the preamble is not kept in the new dualChangeSorterApplication


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #1 on issue 6274 by [hidden email]: another step to remove  
StringHolder hierarchy element
http://code.google.com/p/pharo/issues/detail?id=6274

I get also an error when I want to remove a method from a change set

removeMethod: aMethod inClass: aClass
        "If a message is selected, create a Confirmer so the user can verify that
        the currently selected message should be removed from the system. If
        so, remove it. "
        | messageName confirmation |
       
        aMethod ifNil: [^ false].
        messageName := aMethod  selector.
                                                   ^^^^^^^^ a Method is  
already a selector
        confirmation := self systemNavigation confirmRemovalOf: messageName on:  
aClass.
        confirmation = 3
                ifTrue: [^ false].
        (aClass includesLocalSelector: messageName)
                ifTrue: [ aClass removeSelector: messageName ]
                ifFalse: [ self removeNonLocalSelector: messageName ].

        "In case organization not cached"
        confirmation = 2
                ifTrue: [self systemNavigation browseAllCallsOn: messageName].
        ^ true


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 6274 by [hidden email]: another step to remove  
StringHolder hierarchy element
http://code.google.com/p/pharo/issues/detail?id=6274

Ben I cannot get the menu on an item (class or  method item)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #3 on issue 6274 by [hidden email]: another step to remove  
StringHolder hierarchy element
http://code.google.com/p/pharo/issues/detail?id=6274

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #4 on issue 6274 by [hidden email]: another step to remove  
StringHolder hierarchy element
http://code.google.com/p/pharo/issues/detail?id=6274

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 6274 by [hidden email]: another step to remove  
StringHolder hierarchy element
http://code.google.com/p/pharo/issues/detail?id=6274

(No comment was entered for this change.)

Attachments:
        ChangeSorterIntegration.cs  2.6 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #6 on issue 6274 by [hidden email]: another step to remove  
StringHolder hierarchy element
http://code.google.com/p/pharo/issues/detail?id=6274

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Milestone-2.0

Comment #7 on issue 6274 by [hidden email]: another step to remove  
StringHolder hierarchy element
http://code.google.com/p/pharo/issues/detail?id=6274

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #8 on issue 6274 by [hidden email]: another step to remove  
StringHolder hierarchy element
http://code.google.com/p/pharo/issues/detail?id=6274#c8

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #9 on issue 6274 by [hidden email]: another step to remove  
StringHolder hierarchy element
http://code.google.com/p/pharo/issues/detail?id=6274#c9

Monkey went bananas:
--------------------
Error while loading "ChangeSorterIntegration.cs" from Comment #5:
        MessageNotUnderstood: ReadStream>>fileIn
  1: ReadStream(Object)>>doesNotUnderstand: #fileIn
  2: [attachment contents asString readStream fileIn] in [:attachment |  
[attachment contents asString readStream fileIn]
                        on: Error
                        do: [:e | self addError: e forFile: attachment description]] in  
UlysseTheMonkey>>loadChangeSet
  3: BlockClosure>>on:do:
  4: [:attachment | [attachment contents asString readStream fileIn]
                        on: Error
                        do: [:e | self addError: e forFile: attachment description]] in  
UlysseTheMonkey>>loadChangeSet
  5: Array(SequenceableCollection)>>do:
  6: UlysseTheMonkey>>loadChangeSet
  7: [self loadChangeSet] in UlysseTheMonkey>>loadAndTestChangeSet
  8: [loadStopwatch reset activate.
                aBlock value.
                loadStopwatch suspend.
                testResult := self runTests.
                self removeFalseErrors] in UlysseTheMonkey>>testChangeImpact:
  9: BlockClosure>>on:do:
10: UlysseTheMonkey>>testChangeImpact:
        ...
----------------------------------------------------------
Loaded Source: "ChangeSorterIntegration.cs" from Comment #5
Tested using Pharo-2.0-20183-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.161 uuid:  
8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul  3 2012,  
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.161 uuid:  
8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul  3 2012,  
https://git.gitorious.org/cogvm/blessed.git Commit:  
8028952c1242f72b6d078b8161f310e3bf0cd365 Date: Tue Jul 3 16:26:14 2012  
+0200 By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #10 on issue 6274 by [hidden email]: another step to remove  
StringHolder hierarchy element
http://code.google.com/p/pharo/issues/detail?id=6274

Name:  
SLICE-Issue-6274-another-step-to-remove-StringHolder-hierarchy-element-MarcusDenker.1
Author: MarcusDenker
Time: 5 July 2012, 1:15:58.456 pm
UUID: a894a502-d472-435b-823c-ed7f5f768d49
Ancestors:
Dependencies: Spec-Tools-MarcusDenker.35, Tools-MarcusDenker.882,  
Morphic-MarcusDenker.1183

Issue 6274: another step to remove StringHolder hierarchy element


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #11 on issue 6274 by [hidden email]: another step to remove  
StringHolder hierarchy element
http://code.google.com/p/pharo/issues/detail?id=6274#c11

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20185

Comment #12 on issue 6274 by [hidden email]: another step to remove  
StringHolder hierarchy element
http://code.google.com/p/pharo/issues/detail?id=6274#c12

This Issue has been checked by Ulysse the Monkey
       
6386 tests passed in 00:02:00s:
===============================
        CollectionsTests-Arrayed (547)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (906)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (596)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1951)
        CollectionsTests-Weak (739)
        CompilerTests (171)
        KernelTests-Chronology (577)
        KernelTests-Classes (66)
        KernelTests-Exception (2)
        KernelTests-Methods (171)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (31)
        MorphicTests-Basic (16)
        MorphicTests-Event (7)
        MorphicTests-Kernel (8)
        MorphicTests-Text Support (4)
        MorphicTests-Widgets (3)
        MorphicTests-WindowNotification (8)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)
        ToolsTest-Base (2)
        ToolsTest-Debugger (10)
        ToolsTest-Finder (9)
        ToolsTest-Inspector (1)
        ToolsTest-MessageTally (5)
        ToolsTest-PointerFinder (3)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6274-another-step-to-remove-StringHolder-hierarchy-element-MarcusDenker.1  
from http://ss3.gemstone.com/ss/PharoInbox"ChangeSorterIntegration.cs" from  
Comment #5
Tested using Pharo-2.0-20185-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.161 uuid:  
8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul  5 2012,  
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.161 uuid:  
8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul  5 2012,  
https://git.gitorious.org/cogvm/blessed.git Commit:  
8216bc960dcf8ddab3a2f6fb54cc97214e7797fd Date: Thu Jul 5 09:41:44 2012  
+0200 By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #13 on issue 6274 by [hidden email]: another step to remove  
StringHolder hierarchy element
http://code.google.com/p/pharo/issues/detail?id=6274#c13

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20186

Comment #14 on issue 6274 by [hidden email]: another step to remove  
StringHolder hierarchy element
http://code.google.com/p/pharo/issues/detail?id=6274#c14

This Issue has been checked by Ulysse the Monkey
       
6386 tests passed in 00:03:34s:
===============================
        CollectionsTests-Arrayed (547)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (906)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (596)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1951)
        CollectionsTests-Weak (739)
        CompilerTests (171)
        KernelTests-Chronology (577)
        KernelTests-Classes (66)
        KernelTests-Exception (2)
        KernelTests-Methods (171)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (31)
        MorphicTests-Basic (16)
        MorphicTests-Event (7)
        MorphicTests-Kernel (8)
        MorphicTests-Text Support (4)
        MorphicTests-Widgets (3)
        MorphicTests-WindowNotification (8)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)
        ToolsTest-Base (2)
        ToolsTest-Debugger (10)
        ToolsTest-Finder (9)
        ToolsTest-Inspector (1)
        ToolsTest-MessageTally (5)
        ToolsTest-PointerFinder (3)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6274-another-step-to-remove-StringHolder-hierarchy-element-MarcusDenker.1  
from http://ss3.gemstone.com/ss/PharoInbox"ChangeSorterIntegration.cs" from  
Comment #5
Tested using Pharo-2.0-20186-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.161 uuid:  
8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul  5 2012,  
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.161 uuid:  
8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul  5 2012,  
https://git.gitorious.org/cogvm/blessed.git Commit:  
8216bc960dcf8ddab3a2f6fb54cc97214e7797fd Date: Thu Jul 5 09:41:44 2012  
+0200 By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #15 on issue 6274 by [hidden email]: another step to remove  
StringHolder hierarchy element
http://code.google.com/p/pharo/issues/detail?id=6274#c15

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FailingTest

Comment #16 on issue 6274 by [hidden email]: another step to remove  
StringHolder hierarchy element
http://code.google.com/p/pharo/issues/detail?id=6274#c16

Test Results:
-------------
Passed: 6402
        CollectionsTests-Arrayed (547)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (906)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (596)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1951)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        KernelTests-Chronology (577)
        KernelTests-Classes (67)
        KernelTests-Exception (2)
        KernelTests-Methods (178)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (31)
        MorphicTests-Basic (16)
        MorphicTests-Event (7)
        MorphicTests-Kernel (8)
        MorphicTests-Text Support (4)
        MorphicTests-Widgets (3)
        MorphicTests-WindowNotification (8)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)
        ToolsTest-Base (2)
        ToolsTest-Debugger (10)
        ToolsTest-Finder (9)
        ToolsTest-Inspector (1)
        ToolsTest-MessageTally (5)
        ToolsTest-PointerFinder (3)


Failures: 1
        TimeTest>>#testGeneralInquiries

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6274-another-step-to-remove-StringHolder-hierarchy-element-MarcusDenker.1  
from http://ss3.gemstone.com/ss/PharoInbox"ChangeSorterIntegration.cs" from  
Comment #5
Tested using Pharo-2.0-20187-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.161 uuid:  
8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul  5 2012,  
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.161 uuid:  
8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul  5 2012,  
https://git.gitorious.org/cogvm/blessed.git Commit:  
8216bc960dcf8ddab3a2f6fb54cc97214e7797fd Date: Thu Jul 5 09:41:44 2012  
+0200 By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #17 on issue 6274 by [hidden email]: another step to remove  
StringHolder hierarchy element
http://code.google.com/p/pharo/issues/detail?id=6274

This is not a failing test


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #18 on issue 6274 by [hidden email]: another step to remove  
StringHolder hierarchy element
http://code.google.com/p/pharo/issues/detail?id=6274

I merged all but not the change for removeMethod:... which looked strange  
(likely to break all other clients)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker