Issue 6275 in pharo: Failing tests related to Traits

Status: FailingTest
Owner: [hidden email]
Labels: Type-Bug Milestone-2.0

New issue 6275 by [hidden email]: Failing tests related to Traits
http://code.google.com/p/pharo/issues/detail?id=6275



>>> Tests.Traits.TraitMethodDescriptionTest.testConflictingCategories 0.18  
>>> sec 83
>>> Tests.Traits.TraitMethodDescriptionTest.testCategories
>>> Tests.Traits.TraitTest.testTraitsMethodClassSanity 0.61 sec 56
>>> Tests.Traits.ClassTraitTest.testChanges 1.1 sec 79


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 6275 by [hidden email]: Failing tests  
related to Traits
http://code.google.com/p/pharo/issues/detail?id=6275

Working on them.  Will provide a Slice


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #2 on issue 6275 by [hidden email]: Failing tests  
related to Traits
http://code.google.com/p/pharo/issues/detail?id=6275

SLICE-Issue-6275-Failing-tests-related-to-Traits-GuillermoPolito.1

- made traits categorize it's methods before adding
- made traits use categorize methods when changing their trait composition  
(only if they were not categorized before)
- removed some TPureBehavior overriden methods which added no value
- tests are green


Now, I do not know if this is the way to go, since I'm making use of some  
side effects on the categorization...
But the events raised when adding a method in a trait looks messy, so i  
didn't want to mess a lot with that :)
Please, Please, review


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #3 on issue 6275 by [hidden email]: Failing tests related to  
Traits
http://code.google.com/p/pharo/issues/detail?id=6275#c3

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #4 on issue 6275 by [hidden email]: Failing tests related to  
Traits
http://code.google.com/p/pharo/issues/detail?id=6275#c4

Monkey went bananas:
--------------------
Error while loading  
SLICE-Issue-6275-Failing-tests-related-to-Traits-GuillermoPolito.1 from  
http://ss3.gemstone.com/ss/PharoInbox:
        MCMergeOrLoadWarning: You are about to load new versions of the following  
packages
that have unsaved changes in the image:

   Traits
   Traits

If you continue, you will lose these changes:
  1: MCVersionLoader>>warnAboutLosingChangesTo:ifCancel:ifMerge:
  2: MCVersionLoader>>checkForModificationsIfCancel:ifMerge:
  3: MCVersionLoader>>loadWithNameLike:
  4: MCVersionLoader>>load
  5: GoferLoad>>execute
  6: Gofer>>execute:do:
  7: Gofer>>execute:
  8: Gofer>>load
  9: GoferResolvedReference>>load
10: [self slice load] in UlysseTheMonkey>>loadSlice
        ...
----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6275-Failing-tests-related-to-Traits-GuillermoPolito.1 from  
http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20192-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.161 uuid:  
8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul  7 2012,  
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.161 uuid:  
8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul  7 2012,  
https://git.gitorious.org/cogvm/blessed.git Commit:  
28e69b26d6011d124e8c4eeb4dcaf22913faac3a Date: Sat Jul 7 09:51:38 2012  
+0200 By: Camillo Bruni <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixManualReviewNeeded

Comment #5 on issue 6275 by [hidden email]: Failing tests  
related to Traits
http://code.google.com/p/pharo/issues/detail?id=6275

Monkey goes bananas... seems it is not working on a clean image..


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #6 on issue 6275 by [hidden email]: Failing tests related to  
Traits
http://code.google.com/p/pharo/issues/detail?id=6275

lets try it... I added it as an update.




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker