Issue 6280 in pharo: NonInteractiveTranscript streams don't survive restarts

Status: Accepted
Owner: ----
Labels: Milestone-2.0 Type-Bug

New issue 6280 by [hidden email]: NonInteractiveTranscript streams  
don't survive restarts
http://code.google.com/p/pharo/issues/detail?id=6280

As reported by Guillermo Polito:


Select the three statements at once and evaluate them:

NonInteractiveTranscript stdout install.
Smalltalk snapshot: true andQuit: true.
Transcript show: 'hello'.

Then reopen your image... Bump! stdout is closed.

Of course, It got closed when the image quitted, but the  
NonInteractiveTranscript kept the reference to an invalid fileStream...

What should be a good solution for this?
- catch the error on the transcript and if closed reopen the file?
- subscribe to the shutdown list to void the reference?
- adding a SystemShutdown announcement and subscribe to it?

The third one seems... cleaner.  But I'm not sure.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 6280 by [hidden email]: NonInteractiveTranscript  
streams don't survive restarts
http://code.google.com/p/pharo/issues/detail?id=6280

First feedback from Sven:


Yes, the stream inside NonInteractiveTranscript should be set to nil  
whenever an image save closes stdout, so either option 2 or 3.

Mind you that the current close/open/reopen logic is not good enough:  
stream is never set to nil .

I think that open and reopen should be removed, and that close should become

close
        self critical: [
                stream ifNotNil: [
                        self isStdout
                                ifTrue: [ stream flush ]
                                ifFalse: [ stream close ].
                        stream := nil ] ]

And then you should add some shutdown hook.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #2 on issue 6280 by [hidden email]: NonInteractiveTranscript  
streams don't survive restarts
http://code.google.com/p/pharo/issues/detail?id=6280

Name:  
SLICE-Issue-6280-NonInteractiveTranscript-streams-dont-survive-restarts-SvenVanCaekenberghe.1
Author: SvenVanCaekenberghe
Time: 6 July 2012, 11:01:44.304 am
UUID: eed5f597-6680-4cbb-b687-66d45ccbf0c7
Ancestors:
Dependencies: NonInteractiveTranscript-SvenVanCaekenberghe.4

Enhance NonInteractiveTranscript so that its stream, if any, is closed  
automatically on image shutdown, to be re-initialized automatically later  
on first use.

Warning: new class side initialization and #shutDown hook


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #3 on issue 6280 by [hidden email]: NonInteractiveTranscript  
streams don't survive restarts
http://code.google.com/p/pharo/issues/detail?id=6280#c3

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20187

Comment #4 on issue 6280 by [hidden email]: NonInteractiveTranscript  
streams don't survive restarts
http://code.google.com/p/pharo/issues/detail?id=6280#c4

This Issue has been checked by Ulysse the Monkey
       
6327 tests passed in 00:01:58s:
===============================
        CollectionsTests-Arrayed (547)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (906)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (596)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1951)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        KernelTests-Chronology (578)
        KernelTests-Classes (67)
        KernelTests-Exception (2)
        KernelTests-Methods (178)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (31)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6280-NonInteractiveTranscript-streams-dont-survive-restarts-SvenVanCaekenberghe.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20187-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.161 uuid:  
8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul  5 2012,  
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.161 uuid:  
8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul  5 2012,  
https://git.gitorious.org/cogvm/blessed.git Commit:  
8216bc960dcf8ddab3a2f6fb54cc97214e7797fd Date: Thu Jul 5 09:41:44 2012  
+0200 By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #5 on issue 6280 by [hidden email]: NonInteractiveTranscript  
streams don't survive restarts
http://code.google.com/p/pharo/issues/detail?id=6280#c5

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20188

Comment #6 on issue 6280 by [hidden email]: NonInteractiveTranscript  
streams don't survive restarts
http://code.google.com/p/pharo/issues/detail?id=6280#c6

This Issue has been checked by Ulysse the Monkey
       
6327 tests passed in 00:01:57s:
===============================
        CollectionsTests-Arrayed (547)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (906)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (596)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1951)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        KernelTests-Chronology (578)
        KernelTests-Classes (67)
        KernelTests-Exception (2)
        KernelTests-Methods (178)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (31)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6280-NonInteractiveTranscript-streams-dont-survive-restarts-SvenVanCaekenberghe.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20188-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.161 uuid:  
8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul  5 2012,  
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.161 uuid:  
8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul  5 2012,  
https://git.gitorious.org/cogvm/blessed.git Commit:  
8216bc960dcf8ddab3a2f6fb54cc97214e7797fd Date: Thu Jul 5 09:41:44 2012  
+0200 By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #7 on issue 6280 by [hidden email]: NonInteractiveTranscript  
streams don't survive restarts
http://code.google.com/p/pharo/issues/detail?id=6280

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #8 on issue 6280 by [hidden email]: NonInteractiveTranscript  
streams don't survive restarts
http://code.google.com/p/pharo/issues/detail?id=6280

in 2.0 1889


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker