Issue 6297 in pharo: ChunkFileFormatParser goes bananas over embedded exclamation point

Status: Accepted
Owner: ----
Labels: Milestone-2.0 Type-Bug

New issue 6297 by [hidden email]: ChunkFileFormatParser goes bananas  
over embedded exclamation point
http://code.google.com/p/pharo/issues/detail?id=6297

It seems that the ChunkFileFormatParser does not like exclamation points  
embedded in strings.

Suppose we have the following file

$ cat test.st
FileStream stdout nextPutAll: 'Hello World'; cr.
Smalltalk quitPrimitive.

This works as expected

$ ./bin/CogVM -vm-display-null -vm-sound-null Pharo-2.0.image test.st
Hello World

Now add an exclamation point

$ cat test.st
FileStream stdout nextPutAll: 'Hello World!'; cr.
Smalltalk quitPrimitive.

Bang

$ ./bin/CogVM -vm-display-null -vm-sound-null Pharo-2.0.image test.st

===============================================================================
Notice: Errors in script loaded from /home/ubuntu/pharo2/test.st
===============================================================================
Syntax Error on line 1: 'Unmatched string quote'
================================================
1: FileStream stdout nextPutAll: 'Hello World
                                 _^_

I don't know if this is new or not.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 6297 by [hidden email]: ChunkFileFormatParser  
goes bananas over embedded exclamation point
http://code.google.com/p/pharo/issues/detail?id=6297

Issue 5350 might be related ?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 6297 by [hidden email]: ChunkFileFormatParser  
goes bananas over embedded exclamation point
http://code.google.com/p/pharo/issues/detail?id=6297

Yes!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #3 on issue 6297 by [hidden email]: ChunkFileFormatParser  
goes bananas over embedded exclamation point
http://code.google.com/p/pharo/issues/detail?id=6297

Is this a show-stopper for 2.0?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 6297 by [hidden email]: ChunkFileFormatParser  
goes bananas over embedded exclamation point
http://code.google.com/p/pharo/issues/detail?id=6297

the input format is the chunk format, no?

so replacing ! with !! should escape it?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 6297 by [hidden email]: ChunkFileFormatParser  
goes bananas over embedded exclamation point
http://code.google.com/p/pharo/issues/detail?id=6297

I never thought about it that way, but you are right of course.

I just tried and it works.

I learned something, thx.

Should we record this information somewhere ?

This issue can be closed.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Invalid

Comment #6 on issue 6297 by [hidden email]: ChunkFileFormatParser  
goes bananas over embedded exclamation point
http://code.google.com/p/pharo/issues/detail?id=6297

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker