Issue 6300 in pharo: Detach keymaping shortcuts

Status: Accepted
Owner: [hidden email]
CC: [hidden email]
Labels: Type-Bug Milestone-2.0 Nautilus

New issue 6300 by [hidden email]: Detach keymaping shortcuts
http://code.google.com/p/pharo/issues/detail?id=6300

Nautilus has Morph>>detach*KeymapCategory* extension methods.

These are generally useful and should be moved from Nautilus to KM

Also, they are broken... Morph>>detachKeymapCategory: signals
MessageNotUnderstood: KMDispatcher>>detachKeymapCategory:


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 6300 by [hidden email]: Detach keymaping  
shortcuts
http://code.google.com/p/pharo/issues/detail?id=6300

Pharo2.0a
Latest update: #20193


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded
        Cc: [hidden email]

Comment #2 on issue 6300 by [hidden email]: Detach keymaping  
shortcuts
http://code.google.com/p/pharo/issues/detail?id=6300

Fix in inbox: SLICE-Issue-6300-Detach-keymaping-shortcuts-SeanDeNigris.1

* Move Morph>>detach*Keymap*Category* methods from Nautilus to  
Keymapping-Core
* A few cosmetic changes (rename temp, add comment)
* Add #disable and #reset to KMKeymap


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #3 on issue 6300 by [hidden email]: Detach keymaping  
shortcuts
http://code.google.com/p/pharo/issues/detail?id=6300#c3

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20197

Comment #4 on issue 6300 by [hidden email]: Detach keymaping  
shortcuts
http://code.google.com/p/pharo/issues/detail?id=6300#c4

This Issue has been checked by Ulysse the Monkey
       
6327 tests passed in 00:02:07s:
===============================
        CollectionsTests-Arrayed (547)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (906)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (596)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1951)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        KernelTests-Chronology (578)
        KernelTests-Classes (67)
        KernelTests-Exception (2)
        KernelTests-Methods (178)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (31)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)

----------------------------------------------------------
Loaded Source: SLICE-Issue-6300-Detach-keymaping-shortcuts-SeanDeNigris.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20197-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.161 uuid:  
8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul  9 2012,  
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.161 uuid:  
8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul  9 2012,  
https://git.gitorious.org/cogvm/blessed.git Commit:  
8eb3f452262d1b213fd1b6fd3cb682e292945ccf Date: Mon Jul 9 15:23:19 2012  
+0200 By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #5 on issue 6300 by [hidden email]: Detach keymaping  
shortcuts
http://code.google.com/p/pharo/issues/detail?id=6300#c5

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20198

Comment #6 on issue 6300 by [hidden email]: Detach keymaping  
shortcuts
http://code.google.com/p/pharo/issues/detail?id=6300#c6

This Issue has been checked by Ulysse the Monkey
       
6327 tests passed in 00:02:05s:
===============================
        CollectionsTests-Arrayed (547)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (906)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (596)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1951)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        KernelTests-Chronology (578)
        KernelTests-Classes (67)
        KernelTests-Exception (2)
        KernelTests-Methods (178)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (31)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)

----------------------------------------------------------
Loaded Source: SLICE-Issue-6300-Detach-keymaping-shortcuts-SeanDeNigris.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20198-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.161 uuid:  
8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul  9 2012,  
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.161 uuid:  
8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul  9 2012,  
https://git.gitorious.org/cogvm/blessed.git Commit:  
8eb3f452262d1b213fd1b6fd3cb682e292945ccf Date: Mon Jul 9 15:23:19 2012  
+0200 By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #7 on issue 6300 by [hidden email]: Detach keymaping  
shortcuts
http://code.google.com/p/pharo/issues/detail?id=6300#c7

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20199

Comment #8 on issue 6300 by [hidden email]: Detach keymaping  
shortcuts
http://code.google.com/p/pharo/issues/detail?id=6300#c8

This Issue has been checked by Ulysse the Monkey
       
6330 tests passed in 00:02:10s:
===============================
        CollectionsTests-Arrayed (547)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (906)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (596)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1951)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        KernelTests-Chronology (581)
        KernelTests-Classes (67)
        KernelTests-Exception (2)
        KernelTests-Methods (178)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (31)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)

----------------------------------------------------------
Loaded Source: SLICE-Issue-6300-Detach-keymaping-shortcuts-SeanDeNigris.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20199-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.161 uuid:  
8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul  9 2012,  
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.161 uuid:  
8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul  9 2012,  
https://git.gitorious.org/cogvm/blessed.git Commit:  
8eb3f452262d1b213fd1b6fd3cb682e292945ccf Date: Mon Jul 9 15:23:19 2012  
+0200 By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #9 on issue 6300 by [hidden email]: Detach keymaping  
shortcuts
http://code.google.com/p/pharo/issues/detail?id=6300

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded
        Labels: -CheckedIn20197 -CheckedIn20198 -CheckedIn20199

Comment #10 on issue 6300 by [hidden email]: Detach keymaping  
shortcuts
http://code.google.com/p/pharo/issues/detail?id=6300

Give me a day on this. I found a bug in detach and I'll include a test or  
two ;-)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #11 on issue 6300 by [hidden email]: Detach keymaping  
shortcuts
http://code.google.com/p/pharo/issues/detail?id=6300

Fix in inbox: SLICE-Issue-6300-Detach-keymaping-shortcuts-SeanDeNigris.2

This version:
* Add Morph>>hasKeymapCategoryNamed:
* Fix/enhance attaching/detaching keymap categories
        - Fix bug in detaching a keymap category
        - Raise error when trying to detach a category that's not attached
        - Don't attach keymap category if it's already attached
        - Add tests

v. 1
* Move Morph>>detach*Keymap*Category* methods from Nautilus to  
Keymapping-Core
* A few cosmetic changes (rename temp, add comment)
* Add #disable and #reset to KMKeymap


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #12 on issue 6300 by [hidden email]: Detach keymaping  
shortcuts
http://code.google.com/p/pharo/issues/detail?id=6300

in 2.0 204


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker