Issue 6308 in pharo: Failing test: TraitTest>>#testTraitsMethodClassSanity

Status: FailingTest
Owner: [hidden email]
Labels: Type-Bug Milestone-2.0

New issue 6308 by [hidden email]: Failing test:  
TraitTest>>#testTraitsMethodClassSanity
http://code.google.com/p/pharo/issues/detail?id=6308

TraitTest>>#testTraitsMethodClassSanity fails on build server


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 6308 by [hidden email]: Failing test:  
TraitTest>>#testTraitsMethodClassSanity
http://code.google.com/p/pharo/issues/detail?id=6308

tests work under Mac OSX, Pharo 20195 and the latest cog vm


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 6308 by [hidden email]: Failing test:  
TraitTest>>#testTraitsMethodClassSanity
http://code.google.com/p/pharo/issues/detail?id=6308

Most probably side-effects in play here. trying to reproduce this locally


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 6308 by [hidden email]: Failing test:  
TraitTest>>#testTraitsMethodClassSanity
http://code.google.com/p/pharo/issues/detail?id=6308

If I modify the test to see what's going on I get a duplicate  
ArrayedCollection collection...

It seems that we have a dangling reference via the compiler.

Attachments:
        Screen Shot 2012-07-08 at 18.00.52.png  87.5 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 6308 by [hidden email]: Failing test:  
TraitTest>>#testTraitsMethodClassSanity
http://code.google.com/p/pharo/issues/detail?id=6308

I added ad-hoc log to Jenkins build, this is the resutl

testTraitsMethodClassSanity:
each: SequenceableCollection
selector: copyFrom:to:
(each >> selector) methodClass: SequenceableCollection


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 6308 by [hidden email]: Failing test:  
TraitTest>>#testTraitsMethodClassSanity
http://code.google.com/p/pharo/issues/detail?id=6308

TSortable users  select: [:user | (Smalltalk includes: user) not] an  
IdentitySet(SequenceableCollection ArrayedCollection)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: marianopeck

Comment #7 on issue 6308 by [hidden email]: Failing test:  
TraitTest>>#testTraitsMethodClassSanity
http://code.google.com/p/pharo/issues/detail?id=6308

the nonglobal users start to appear after FuelMetalevelTests... but not  
when the tests are started manually


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 6308 by [hidden email]: Failing test:  
TraitTest>>#testTraitsMethodClassSanity
http://code.google.com/p/pharo/issues/detail?id=6308

I use this script to reproduce it

Attachments:
        1.st  1.9 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 6308 by [hidden email]: Failing test:  
TraitTest>>#testTraitsMethodClassSanity
http://code.google.com/p/pharo/issues/detail?id=6308

FLCreateClassSerializationTest >> testCreateByteArrayWithInstance is the  
dirty test


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 6308 by [hidden email]: Failing test:  
TraitTest>>#testTraitsMethodClassSanity
http://code.google.com/p/pharo/issues/detail?id=6308

Confirmed, when I delete the test FLCreateClassSerializationTest >>  
testCreateByteArrayWithInstance, the test testTraitsMethodClassSanity is  
not failing


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #11 on issue 6308 by [hidden email]: Failing test:  
TraitTest>>#testTraitsMethodClassSanity
http://code.google.com/p/pharo/issues/detail?id=6308

(I tried it directly on the Jenkins server)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded
        Cc: [hidden email]

Comment #12 on issue 6308 by marianopeck: Failing test:  
TraitTest>>#testTraitsMethodClassSanity
http://code.google.com/p/pharo/issues/detail?id=6308

Hi Pavel. Nice catch! thanks both for the debugging. Indeed,  
#testCreateByteArrayWithInstance is dirty now that I noticed. However, such  
test is to test something really really specific that we do not support (in  
fact it only fails when using file streams). So we should remove it or find  
a way to make it fail but without having side effects.

For the immediate solution for Pharo, I recommend removing the test. We  
will take care to correctly fix it in Fuel's repository and then at some  
point we will merge.

Martin, do you agree?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #13 on issue 6308 by [hidden email]: Failing test:  
TraitTest>>#testTraitsMethodClassSanity
http://code.google.com/p/pharo/issues/detail?id=6308

agree to remove it.

Then we will have to add a new stable version in ConfigurationOfFuel so  
Jenkins loads correctly, right?





_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #14 on issue 6308 by marianopeck: Failing test:  
TraitTest>>#testTraitsMethodClassSanity
http://code.google.com/p/pharo/issues/detail?id=6308

I have commented the test. In inbox.


testCreateByteArrayWithInstance
        "Tests internal materialization of ByteArray together with an instance of  
it.
        IMPORTANT: this test was disabled because it is dirty and gets broken  
classes/traits.
        For more details see: http://code.google.com/p/pharo/issues/detail?id=6308"
        ......


Name:  
SLICE-Issue-6308-Failing-test-TraitTestgtgttestTraitsMethodClassSanity-MarianoMartinezPeck.1
Author: MarianoMartinezPeck
Time: 10 July 2012, 5:39:46.809 pm
UUID: cfe70b09-9711-4c5d-b3fa-9d4d6098fd7a
Ancestors:
Dependencies: FuelMetalevelTests-MarianoMartinezPeck.45

fix in inbox


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #15 on issue 6308 by [hidden email]: Failing test:  
TraitTest>>#testTraitsMethodClassSanity
http://code.google.com/p/pharo/issues/detail?id=6308

in 2.0 201


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker