Issue 6350 in pharo: StartupPreferences Cleanup

Status: Accepted
Owner: [hidden email]
Labels: Type-Bug Milestone-2.0 Difficulty-Easy

New issue 6350 by [hidden email]: StartupPreferences Cleanup
http://code.google.com/p/pharo/issues/detail?id=6350

Pharo2.0a
Latest update: #20196

There is some duplication of code and some changes needed for FS everywhere


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded
        Cc: marianopeck

Comment #1 on issue 6350 by [hidden email]: StartupPreferences  
Cleanup
http://code.google.com/p/pharo/issues/detail?id=6350

Fix in inbox: SLICE-Issue-6350-StartupPreferences-Cleanup-SeanDeNigris.1

* Change #lookInImageDirectory to #lookInImageFolder to be consistent with  
the rest of those methods
* Add flag to #lookInFolder: which should be refactored
* Move duplicated (and inconsistent) logic for preferences folder paths to  
StartupLoader (class-side #preferencesGeneralFolder &  
#preferencesVersionFolder)
* Fix for FS everywhere


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 6350 by marianopeck: StartupPreferences Cleanup
http://code.google.com/p/pharo/issues/detail?id=6350

Hi. I have just reviewed the issue and it looks fine. However, there is  
something I don't undersand. Say I want to know which is  
preferencesGeneralFolder. If  I print:

StartupLoader preferencesGeneralFolder

-> {preferences}/pharo

so what is {preferences}  ??  where is it actually that folder?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 6350 by [hidden email]: StartupPreferences  
Cleanup
http://code.google.com/p/pharo/issues/detail?id=6350

You're looking at a FileLocator. Maybe it should be returning a  
FileReference. To see what it actually points to, you can convert it via  
#asFileReference, or send #fullName


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 6350 by marianopeck: StartupPreferences Cleanup
http://code.google.com/p/pharo/issues/detail?id=6350

Ok. I see now :)
Yes, maybe it should return a FileReference instead?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 6350 by [hidden email]: StartupPreferences  
Cleanup
http://code.google.com/p/pharo/issues/detail?id=6350

Done.

Name: SLICE-Issue-6350-StartupPreferences-Cleanup-SeanDeNigris.2

This version:
* StartupLoader (class-side #preferencesGeneralFolder &  
#preferencesVersionFolder) return FileReferences instead of FileLocators,  
per Mariano's suggestion

v. 1:
* Change #lookInImageDirectory to #lookInImageFolder to be consistent with  
the rest of those methods
* Add flag to #lookInFolder: which should be refactored
* Move duplicated (and inconsistent) logic for preferences folder paths to  
StartupLoader (class-side #preferencesGeneralFolder &  
#preferencesVersionFolder)
* Fix for FS everywhere


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #6 on issue 6350 by [hidden email]: StartupPreferences  
Cleanup
http://code.google.com/p/pharo/issues/detail?id=6350

in 2.0 206


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker