Issue 6441 in pharo: Several CompiledMethod fixes from Squeak

Status: Accepted
Owner: marianopeck
Labels: Type-Bug Milestone-2.0

New issue 6441 by marianopeck: Several CompiledMethod fixes from Squeak
http://code.google.com/p/pharo/issues/detail?id=6441

Hi guys. The full discussion is in:
http://forum.world.st/Re-squeak-dev-CompiledMethod-gt-gt-hash-broken-on-CogVM-r2559-Win7-Squeak-4-3-td4641198.html

The slice coming soon does:

- Create CompiledMethod >> #hash to prevent problems with new Cog VMs
- Improve #postCopy to properly fix pragmas
- remove unncessary #createMethod:header: and  
#fixAdditionalMethodStateMethodReference:
- fix in #runUntilErrorOrReturnFrom:
- Improve CompiledMethodTests >> testCopy and new  #testCopyWithTrailerBytes

These changes from from Squeak commits  Kernel-eem.692, Kernel-eem.700,  
Kernel-eem.703, Kernel-eem.706,  KernelTests-eem.228.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded
        Cc: [hidden email]

Comment #1 on issue 6441 by marianopeck: Several CompiledMethod fixes from  
Squeak
http://code.google.com/p/pharo/issues/detail?id=6441

Fix in inbox waiting for a nice review

Name:  
SLICE-Issue-6441-Several-CompiledMethod-fixes-from-Squeak-MarianoMartinezPeck.1
Author: MarianoMartinezPeck
Time: 24 July 2012, 10:40:13.755 am
UUID: f32af3cd-78f5-47ef-b7d8-6378685442f9
Ancestors:
Dependencies: Kernel-MarianoMartinezPeck.1166,  
KernelTests-MarianoMartinezPeck.435

Fix to issue 6441


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #2 on issue 6441 by [hidden email]: Several CompiledMethod  
fixes from Squeak
http://code.google.com/p/pharo/issues/detail?id=6441#c2

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #3 on issue 6441 by [hidden email]: Several CompiledMethod  
fixes from Squeak
http://code.google.com/p/pharo/issues/detail?id=6441#c3

Monkey went bananas:
--------------------
Error while loading  
SLICE-Issue-6441-Several-CompiledMethod-fixes-from-Squeak-MarianoMartinezPeck.1  
from http://ss3.gemstone.com/ss/PharoInbox:
        MCMergeOrLoadWarning: You are about to load new versions of the following  
packages
that have unsaved changes in the image:

   KernelTests
   KernelTests

If you continue, you will lose these changes:
  1: MCVersionLoader>>warnAboutLosingChangesTo:ifCancel:ifMerge:
  2: MCVersionLoader>>checkForModificationsIfCancel:ifMerge:
  3: MCVersionLoader>>loadWithNameLike:
  4: MCVersionLoader>>load
  5: GoferLoad>>execute
  6: Gofer>>execute:do:
  7: Gofer>>execute:
  8: Gofer>>load
  9: GoferResolvedReference>>load
10: [self slice load] in UlysseTheMonkey>>loadSlice
        ...Test Results:
-------------
Passed: 7559
        CollectionsTests-Arrayed (547)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (906)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (596)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1951)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        KernelTests-Chronology (1165)
        KernelTests-Classes (134)
        KernelTests-Exception (5)
        KernelTests-Methods (357)
        KernelTests-Numbers (552)
        KernelTests-Objects (172)
        KernelTests-Pragmas (6)
        KernelTests-Processes (62)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)


Failures: 1
        TimeTest>>#testGeneralInquiries

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6441-Several-CompiledMethod-fixes-from-Squeak-MarianoMartinezPeck.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20232-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.161 uuid:  
8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul 19 2012
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.161 uuid:  
8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul 19 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
5151310c41b08f55b70e9c6250711cb1f3672ce7 Date: 2012-07-18 14:06:15 +0200  
By: Camillo Bruni <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: HumanReviewNeeded

Comment #4 on issue 6441 by [hidden email]: Several  
CompiledMethod fixes from Squeak
http://code.google.com/p/pharo/issues/detail?id=6441

Bad Monkey!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 6441 by [hidden email]: Several CompiledMethod  
fixes from Squeak
http://code.google.com/p/pharo/issues/detail?id=6441

Mariano can you have a look?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email] [hidden email]

Comment #6 on issue 6441 by marianopeck: Several CompiledMethod fixes from  
Squeak
http://code.google.com/p/pharo/issues/detail?id=6441

Check what? I have no idea what the monkey is saying. I have just took the  
latest image and KernelTests is NOT dirty...so I don't know. I think there  
was an issue in some previous ago where KernelTests was dirty..so maybe the  
monkey is taking an old image.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 6441 by [hidden email]: Several CompiledMethod  
fixes from Squeak
http://code.google.com/p/pharo/issues/detail?id=6441

there is at least one issue with the monkey when certain packages are  
touched.
We should investigate that, in any case, for now we simply put these issue  
on HumanReviewNeeded, and just load and have a look at the issues :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 6441 by marianopeck: Several CompiledMethod fixes from  
Squeak
http://code.google.com/p/pharo/issues/detail?id=6441

I have created a slightly new version. Anyone wants to review?

Name:  
SLICE-Issue-6441-Several-CompiledMethod-fixes-from-Squeak-MarianoMartinezPeck.2
Author: MarianoMartinezPeck
Time: 25 July 2012, 2:28:18.824 pm
UUID: e4f089f2-9739-4546-ba14-44ea26a88fda
Ancestors:  
SLICE-Issue-6441-Several-CompiledMethod-fixes-from-Squeak-MarianoMartinezPeck.1
Dependencies: Kernel-MarianoMartinezPeck.1167,  
KernelTests-MarianoMartinezPeck.436

new version


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #9 on issue 6441 by [hidden email]: Several CompiledMethod  
fixes from Squeak
http://code.google.com/p/pharo/issues/detail?id=6441

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #10 on issue 6441 by [hidden email]: Several CompiledMethod  
fixes from Squeak
http://code.google.com/p/pharo/issues/detail?id=6441#c10

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #11 on issue 6441 by [hidden email]: Several CompiledMethod  
fixes from Squeak
http://code.google.com/p/pharo/issues/detail?id=6441#c11

Monkey went bananas:
--------------------
Error while loading  
SLICE-Issue-6441-Several-CompiledMethod-fixes-from-Squeak-MarianoMartinezPeck.2  
from http://ss3.gemstone.com/ss/PharoInbox:
        MCMergeOrLoadWarning: You are about to load new versions of the following  
packages
that have unsaved changes in the image:

   KernelTests
   KernelTests

If you continue, you will lose these changes:
  1: MCVersionLoader>>warnAboutLosingChangesTo:ifCancel:ifMerge:
  2: MCVersionLoader>>checkForModificationsIfCancel:ifMerge:
  3: MCVersionLoader>>loadWithNameLike:
  4: MCVersionLoader>>load
  5: GoferLoad>>execute
  6: Gofer>>execute:do:
  7: Gofer>>execute:
  8: Gofer>>load
  9: GoferResolvedReference>>load
10: [self slice load] in UlysseTheMonkey>>loadSlice
        ...
----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6441-Several-CompiledMethod-fixes-from-Squeak-MarianoMartinezPeck.2  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20233-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.161 uuid:  
8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul 19 2012
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.161 uuid:  
8e0c22c3-b48d-4d8d-a7f9-8a75dc246f28 Jul 19 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
5151310c41b08f55b70e9c6250711cb1f3672ce7 Date: 2012-07-18 14:06:15 +0200  
By: Camillo Bruni <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #12 on issue 6441 by marianopeck: Several CompiledMethod fixes from  
Squeak
http://code.google.com/p/pharo/issues/detail?id=6441

I don't understand this problem with the Monkey. Can someone review it ?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: HumanReviewNeeded

Comment #13 on issue 6441 by marianopeck: Several CompiledMethod fixes from  
Squeak
http://code.google.com/p/pharo/issues/detail?id=6441

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #14 on issue 6441 by [hidden email]: Several CompiledMethod  
fixes from Squeak
http://code.google.com/p/pharo/issues/detail?id=6441

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #15 on issue 6441 by [hidden email]: Several CompiledMethod  
fixes from Squeak
http://code.google.com/p/pharo/issues/detail?id=6441#c15

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #16 on issue 6441 by [hidden email]: Several CompiledMethod  
fixes from Squeak
http://code.google.com/p/pharo/issues/detail?id=6441#c16

Monkey went bananas:
--------------------
Error while loading  
SLICE-Issue-6441-Several-CompiledMethod-fixes-from-Squeak-MarianoMartinezPeck.2  
from http://ss3.gemstone.com/ss/PharoInbox:
        MCMergeOrLoadWarning: You are about to load new versions of the following  
packages
that have unsaved changes in the image:

   KernelTests
   KernelTests

If you continue, you will lose these changes:
  1: MCVersionLoader>>warnAboutLosingChangesTo:ifCancel:ifMerge:
  2: MCVersionLoader>>checkForModificationsIfCancel:ifMerge:
  3: MCVersionLoader>>loadWithNameLike:
  4: MCVersionLoader>>load
  5: GoferLoad>>execute
  6: Gofer>>execute:do:
  7: Gofer>>execute:
  8: Gofer>>load
  9: GoferResolvedReference>>load
10: [self slice load] in UlysseTheMonkey>>loadSlice
        ...
----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6441-Several-CompiledMethod-fixes-from-Squeak-MarianoMartinezPeck.2  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20247-a on CoInterpreter  
VMMaker-oscog-IgorStasenko.162 uuid: e4554f9a-cc90-4826-a807-ac282b782fe4  
Aug  3 2012
StackToRegisterMappingCogit VMMaker-oscog-IgorStasenko.162 uuid:  
e4554f9a-cc90-4826-a807-ac282b782fe4 Aug  3 2012
git://gitorious.org/cogvm/blessed.git Commit:  
aeb0705cde4b8fc57cb262dc051c5ee6dfa72a14 Date: 2012-07-26 16:38:48 +0200  
By: Igor Stasenko <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #17 on issue 6441 by [hidden email]: Several CompiledMethod  
fixes from Squeak
http://code.google.com/p/pharo/issues/detail?id=6441

ok, obviously the monkey has problems, because I don't see any problem  
here... :(


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #18 on issue 6441 by [hidden email]: Several CompiledMethod  
fixes from Squeak
http://code.google.com/p/pharo/issues/detail?id=6441

indeed, I'll look into it, cause this sucks if each time we touch  
Monticello or Kernel we have to manually check it again :)



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #19 on issue 6441 by [hidden email]: Several CompiledMethod  
fixes from Squeak
http://code.google.com/p/pharo/issues/detail?id=6441

in 20248


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker