Issue 6449 in pharo: [ENH]: MCHttpRepository Authentication

Updates:
        Status: WorkNeeded

Comment #20 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449

Sean, your slice changes ScriptLoader, who is updated before the  
integration and then used to load the packages... so, it breaks  
everything :)
can you upload a slice without changing ScriptLoader?



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #21 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449

Name: SLICE-Issue-6449-ENH-MCHttpRepository-Authentication-SeanDeNigris.4
Author: SeanDeNigris
Time: 7 September 2012, 9:14:42.246 am
UUID: c9f44c43-9a9a-45eb-8ae8-6c6b8c88f774
Ancestors:  
SLICE-Issue-6449-ENH-MCHttpRepository-Authentication-SeanDeNigris.3
Dependencies: CI-Core-SeanDeNigris.36, Gofer-Tests-SeanDeNigris.143,  
Monticello-SeanDeNigris.690, Tests-SeanDeNigris.454,  
MonticelloConfigurations-SeanDeNigris.63, Network-Url-SeanDeNigris.76,  
Tools-SeanDeNigris.923, Gofer-Core-SeanDeNigris.165

v. 4
* Remove ScriptLoader changes for easy integration (per Esteban)

 From v. 3:
* Add MCServerRegistry, a singleton which stores credentials for  
MCHttpRepository locations (see #on:beUser:withPassword:)
* Add MCHttpRepository class>>location:, which uses any stored credentials,  
or empty user and password if none
        -Change all senders manually setting empty credentials to use #location.  
e.g.
        MCHttpRepository
                location: 'http://ss3.gemstone.com/ss/Pharo20'
                user: ''
                password: ''
        or worse
        MCHttpRepository new
          location: self inboxRepositoryUrlString;
                user: '';
                password: ''
        becomes:
        MCHttpRepository location: 'http://ss3.gemstone.com/ss/Pharo20'.
* Fix Gofer repo authentication
        - Replace switch statement with polymorphic delegation
        - Setting credentials only effects the repo for that Gofer instance; does  
not change the stored credentials
* Tests - added for new behavior, fixed relevant existing; all passing
* MCHttpRepository class>>location:user:password: only effects that repo;  
does not change the stored credentials

n.b. redid v.3 for #20277; changes are same as v. 2 of slice; not related  
to SLICE-Issue-6449-ENH-MCHttpRepository-Authentication-SeanDeNigris.1 in  
inbox; v. 2 restarted from scratch


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #22 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449#c22

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20278

Comment #23 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449#c23

This Issue has been checked by Ulysse the Monkey
       
7055 tests passed in 00:03:47s:
===============================
        CollectionsTests-Arrayed (547)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (906)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (596)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1951)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        Gofer-Tests (44)
        KernelTests-Chronology (583)
        KernelTests-Classes (66)
        KernelTests-Exception (2)
        KernelTests-Methods (179)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (31)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)
        Tests-Bugs (25)
        Tests-CodeImport (9)
        Tests-Compression (10)
        Tests-Digital Signatures (8)
        Tests-Exceptions (28)
        Tests-Files (21)
        Tests-Finalization (1)
        Tests-Monticello (122)
        Tests-Multilingual (3)
        Tests-Object Events (24)
        Tests-ObjectsAsMethods (3)
        Tests-PackageInfo (2)
        Tests-Polymorph-Widgets (10)
        Tests-Release (5)
        Tests-ScriptLoader (4)
        Tests-System (271)
        Tests-System-CommandLine (14)
        Tests-SystemChangeNotification (1)
        Tests-SystemHistory (14)
        Tests-TextEditors (3)
        Tests-Traits (58)
        Tests-Traits-MOP (3)
        Tests-VM (10)
        ToolsTest-Base (2)
        ToolsTest-Debugger (10)
        ToolsTest-Finder (9)
        ToolsTest-Inspector (1)
        ToolsTest-MessageTally (5)
        ToolsTest-PointerFinder (3)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6449-ENH-MCHttpRepository-Authentication-SeanDeNigris.4 from  
http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20278-a on CoInterpreter  
VMMaker-oscog-IgorStasenko.162 uuid: e4554f9a-cc90-4826-a807-ac282b782fe4  
Sep  3 2012
StackToRegisterMappingCogit VMMaker-oscog-IgorStasenko.162 uuid:  
e4554f9a-cc90-4826-a807-ac282b782fe4 Sep  3 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
aeb0705cde4b8fc57cb262dc051c5ee6dfa72a14 Date: 2012-07-26 16:38:48 +0200  
By: Igor Stasenko <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #24 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449#c24

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: HumanReviewNeeded

Comment #25 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #26 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449

Sean I want to integrate this, but it has become outdated. Could you  
prepare a new slice with updated changes? Thanks


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #27 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449

I'm working all night... I'll take a look in the next day or two


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: -Milestone-2.0

Comment #28 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449

I would be nice to have an integratable version of this, but if not, it is  
not an issue that should hold up the 2.0 release.

therefore: removed tag.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #29 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449

I wasn't pushing due to the feature freeze, but if it will be integrated,  
this is important enough to me to sit down and make a new slice... let me  
know...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #30 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449

send a slice :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded
        Cc: [hidden email]

Comment #31 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449

New slice in inbox,  
SLICE-Issue-6449-ENH-MCHttpRepository-Authentication-SeanDeNigris.5, made  
for #20452...

Version 5: Same as version 4; redid slice for Pharo 2.0452

 From v. 4:
* Remove ScriptLoader changes for easy integration (per Esteban)

 From v. 3:
* Add MCServerRegistry, a singleton which stores credentials for  
MCHttpRepository locations (see #on:beUser:withPassword:)
* Add MCHttpRepository class>>location:, which uses any stored credentials,  
or empty user and password if none
        -Change all senders manually setting empty credentials to use #location.  
e.g.
        MCHttpRepository
                location: 'http://ss3.gemstone.com/ss/Pharo20'
                user: ''
                password: ''
        or worse
        MCHttpRepository new
          location: self inboxRepositoryUrlString;
                user: '';
                password: ''
        becomes:
        MCHttpRepository location: 'http://ss3.gemstone.com/ss/Pharo20'.
* Fix Gofer repo authentication
        - Replace switch statement with polymorphic delegation
        - Setting credentials only effects the repo for that Gofer instance; does  
not change the stored credentials
* Tests - added for new behavior, fixed relevant existing; all passing
* MCHttpRepository class>>location:user:password: only effects that repo;  
does not change the stored credentials

n.b. redid slice for #20277; changes are same as v. 2 of slice; not related  
to SLICE-Issue-6449-ENH-MCHttpRepository-Authentication-SeanDeNigris.1 in  
inbox; v. 2 restarted from scratch


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Milestone-2.0

Comment #32 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #33 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449

I think this is a very useful addition.

I just had a quick look at the changes of the slice against (an upgraded)  
20459.

All in all it looks OK, but I think there are some places where the  
integrator has to be careful:

   ImageCleaner>>cleanupMethods
   MCMethodDefinitiion class>>shutdown|flushMethodCache
   MCWorkingCopy>>newVersion

I don' think that are changes from the original last version of Sean's  
slice.

Sven


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #34 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449

Thanks sven for the feedback
I will try to look at it, once I fixed the problem to integrate an MC  
annoying bug.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #35 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449

Esteban, will you integrate this? The changes should be identical to the  
previous slice you tried to integrate, just repackaged to load cleanly.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #36 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449

Guys, this should be integrated.

It takes a lot of effort to make a slice.

And we want contribution like this from as much people as possible.

Sven


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #37 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449

yes, yes... I will integrate it this week :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #38 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #39 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449

in 2.0 479


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker