Issue 6449 in pharo: [ENH]: MCHttpRepository Authentication

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
41 messages Options
123
Reply | Threaded
Open this post in threaded view
|

Issue 6449 in pharo: [ENH]: MCHttpRepository Authentication

pharo
Status: Accepted
Owner: [hidden email]
Labels: Type-Bug Milestone-2.0

New issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449

We should be able to say, "MCHttpRepository logInto: serverUrl as: username  
withPassword: passwordString"

Is there any use case for not using the server credentials with a  
particular repo i.e. myserver/ss has credentials, but myserver/ss/myrepo  
uses different/no credentials? If we assume that all repos with a given  
prefix will use the same credentials, the implementation will be much  
simpler...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6449 in pharo: [ENH]: MCHttpRepository Authentication

pharo
Updates:
        Status: HumanReviewNeeded

Comment #1 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449

Conversation-starter in the inbox. Please do not integrate.

Name: SLICE-Issue-6449-ENH-MCHttpRepository-Authentication-SeanDeNigris.1
Hack together an implementation to start the conversation. ***This should  
NOT be integrated***


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6449 in pharo: [ENH]: MCHttpRepository Authentication

pharo

Comment #2 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449

Issue 6170 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6449 in pharo: [ENH]: MCHttpRepository Authentication

pharo
Updates:
        Status: FixToInclude

Comment #3 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6449 in pharo: [ENH]: MCHttpRepository Authentication

pharo
Updates:
        Status: HumanReviewNeeded
        Cc: [hidden email]
        Labels: -Type-Bug Type-Feature

Comment #4 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449

@esteban: If you think this is a good idea, let me take one more crack at  
it before we integrate. My first fix was just to spark conversation.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6449 in pharo: [ENH]: MCHttpRepository Authentication

pharo
Updates:
        Status: WorkNeeded

Comment #5 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449

he... I was integrating it... what I care is right now Gofer  
url:username:password: is not working at all, and it seems that this thingy  
fixes it... anyway, I can put it in "workneeded", then :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6449 in pharo: [ENH]: MCHttpRepository Authentication

pharo

Comment #6 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449

@esteban: okay, I'll bump it to the top of my list if it's important...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6449 in pharo: [ENH]: MCHttpRepository Authentication

pharo
Updates:
        Status: FixReviewNeeded

Comment #7 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449

Fix in inbox:  
SLICE-Issue-6449-ENH-MCHttpRepository-Authentication-SeanDeNigris.2

* Add MCServerRegistry, a singleton which stores credentials for  
MCHttpRepository locations (see #on:beUser:withPassword:)
* Add MCHttpRepository class>>location:, which uses any stored credentials,  
or empty user and password if none
        -Change all senders manually setting empty credentials to use #location.  
e.g.
        MCHttpRepository
                location: 'http://ss3.gemstone.com/ss/Pharo20'
                user: ''
                password: ''
        or worse
        MCHttpRepository new
          location: self inboxRepositoryUrlString;
                user: '';
                password: ''
        becomes:
        MCHttpRepository location: 'http://ss3.gemstone.com/ss/Pharo20'.
* Fix Gofer repo authentication
        - Replace switch statement with polymorphic delegation
        - Setting credentials only effects the repo for that Gofer instance; does  
not change the stored credentials
* Tests - added for new behavior, fixed relevant existing; all passing
* MCHttpRepository class>>location:user:password: only effects that repo;  
does not change the stored credentials

n.b. not related to  
SLICE-Issue-6449-ENH-MCHttpRepository-Authentication-SeanDeNigris.1 in  
inbox; restarted from scratch


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6449 in pharo: [ENH]: MCHttpRepository Authentication

pharo
Updates:
        Status: MonkeyIsChecking

Comment #8 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449#c8

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6449 in pharo: [ENH]: MCHttpRepository Authentication

pharo
Updates:
        Status: FixReviewNeeded

Comment #9 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6449 in pharo: [ENH]: MCHttpRepository Authentication

pharo
Updates:
        Status: MonkeyIsChecking

Comment #10 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449#c10

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6449 in pharo: [ENH]: MCHttpRepository Authentication

pharo
Updates:
        Status: FailingTest

Comment #11 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449#c11

Test Results:
-------------
Passed: 7051
        CollectionsTests-Arrayed (547)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (906)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (596)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1951)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        Gofer-Tests (44)
        KernelTests-Chronology (579)
        KernelTests-Classes (66)
        KernelTests-Exception (2)
        KernelTests-Methods (179)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (31)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)
        Tests-Bugs (25)
        Tests-CodeImport (9)
        Tests-Compression (10)
        Tests-Digital Signatures (8)
        Tests-Exceptions (28)
        Tests-Files (21)
        Tests-Finalization (1)
        Tests-Monticello (122)
        Tests-Multilingual (3)
        Tests-Object Events (24)
        Tests-ObjectsAsMethods (3)
        Tests-PackageInfo (2)
        Tests-Polymorph-Widgets (10)
        Tests-Release (5)
        Tests-ScriptLoader (4)
        Tests-System (271)
        Tests-System-CommandLine (14)
        Tests-SystemChangeNotification (1)
        Tests-SystemHistory (14)
        Tests-TextEditors (3)
        Tests-Traits (58)
        Tests-Traits-MOP (3)
        Tests-VM (10)
        ToolsTest-Base (2)
        ToolsTest-Debugger (10)
        ToolsTest-Finder (9)
        ToolsTest-Inspector (1)
        ToolsTest-MessageTally (5)
        ToolsTest-PointerFinder (3)


Failures: 1
        ReleaseTest>>#testObsoleteClasses

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6449-ENH-MCHttpRepository-Authentication-SeanDeNigris.2 from  
http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20277-a on CoInterpreter  
VMMaker-oscog-IgorStasenko.162 uuid: e4554f9a-cc90-4826-a807-ac282b782fe4  
Sep  3 2012
StackToRegisterMappingCogit VMMaker-oscog-IgorStasenko.162 uuid:  
e4554f9a-cc90-4826-a807-ac282b782fe4 Sep  3 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
aeb0705cde4b8fc57cb262dc051c5ee6dfa72a14 Date: 2012-07-26 16:38:48 +0200  
By: Igor Stasenko <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6449 in pharo: [ENH]: MCHttpRepository Authentication

pharo
Updates:
        Status: FixReviewNeeded

Comment #12 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449

Redid slice... v. 3 in inbox


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6449 in pharo: [ENH]: MCHttpRepository Authentication

pharo
Updates:
        Status: MonkeyIsChecking

Comment #13 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449#c13

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6449 in pharo: [ENH]: MCHttpRepository Authentication

pharo
Updates:
        Status: FailingTest

Comment #14 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449#c14

Test Results:
-------------
Passed: 7055
        CollectionsTests-Arrayed (547)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (906)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (596)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1951)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        Gofer-Tests (44)
        KernelTests-Chronology (583)
        KernelTests-Classes (66)
        KernelTests-Exception (2)
        KernelTests-Methods (179)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (31)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)
        Tests-Bugs (25)
        Tests-CodeImport (9)
        Tests-Compression (10)
        Tests-Digital Signatures (8)
        Tests-Exceptions (28)
        Tests-Files (21)
        Tests-Finalization (1)
        Tests-Monticello (122)
        Tests-Multilingual (3)
        Tests-Object Events (24)
        Tests-ObjectsAsMethods (3)
        Tests-PackageInfo (2)
        Tests-Polymorph-Widgets (10)
        Tests-Release (5)
        Tests-ScriptLoader (4)
        Tests-System (271)
        Tests-System-CommandLine (14)
        Tests-SystemChangeNotification (1)
        Tests-SystemHistory (14)
        Tests-TextEditors (3)
        Tests-Traits (58)
        Tests-Traits-MOP (3)
        Tests-VM (10)
        ToolsTest-Base (2)
        ToolsTest-Debugger (10)
        ToolsTest-Finder (9)
        ToolsTest-Inspector (1)
        ToolsTest-MessageTally (5)
        ToolsTest-PointerFinder (3)


Failures: 1
        ReleaseTest>>#testObsoleteClasses

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6449-ENH-MCHttpRepository-Authentication-SeanDeNigris.3 from  
http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20277-a on CoInterpreter  
VMMaker-oscog-IgorStasenko.162 uuid: e4554f9a-cc90-4826-a807-ac282b782fe4  
Sep  3 2012
StackToRegisterMappingCogit VMMaker-oscog-IgorStasenko.162 uuid:  
e4554f9a-cc90-4826-a807-ac282b782fe4 Sep  3 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
aeb0705cde4b8fc57cb262dc051c5ee6dfa72a14 Date: 2012-07-26 16:38:48 +0200  
By: Igor Stasenko <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6449 in pharo: [ENH]: MCHttpRepository Authentication

pharo
Updates:
        Status: HumanReviewNeeded
        Cc: [hidden email]

Comment #15 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449

Okay, I give up for now. I don't think this failing test has anything to do  
with the slice... when I load manually, the test passes... I don't know if  
the problem is with the monkey or what...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6449 in pharo: [ENH]: MCHttpRepository Authentication

pharo

Comment #16 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449

should check if the monkey leaves some obsolete classes behind...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6449 in pharo: [ENH]: MCHttpRepository Authentication

pharo
Updates:
        Status: FixToInclude

Comment #17 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449

the obsolete classes are due the NewClassOrganizer integration, nothing to  
do with this issue or with ulysse (afaik)



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6449 in pharo: [ENH]: MCHttpRepository Authentication

pharo
Updates:
        Status: Integrated

Comment #18 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449

in 20278


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6449 in pharo: [ENH]: MCHttpRepository Authentication

pharo
Updates:
        Status: FixToInclude

Comment #19 on issue 6449 by [hidden email]: [ENH]: MCHttpRepository  
Authentication
http://code.google.com/p/pharo/issues/detail?id=6449

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
123