Issue 6496 in pharo: Remove Source Code Authors

Status: Accepted
Owner: ----
Labels: Milestone-2.0 Type-Feature

New issue 6496 by [hidden email]: Remove Source Code Authors
http://code.google.com/p/pharo/issues/detail?id=6496

In various places we have author names in the method comments.
This is superfluous and incorrect data in many places as we can deduce the  
author from the version history.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #1 on issue 6496 by [hidden email]: Remove Source Code  
Authors
http://code.google.com/p/pharo/issues/detail?id=6496

Name: SLICE-Issue-6496-Remove-Source-Code-Authors-CamilloBruni.1
Author: CamilloBruni
Time: 1 August 2012, 4:29:58.745 pm
UUID: 066790cc-dea0-4844-8ed7-d00aaf02c7d8
Ancestors:
Dependencies: Traits-CamilloBruni.431, Polymorph-CamilloBruni.2,  
UIManager-CamilloBruni.74, Deprecated20-CamilloBruni.18,  
Graphics-Files-CamilloBruni.31, Collections-Abstract-CamilloBruni.177,  
Monticello-CamilloBruni.650, System-Changes-CamilloBruni.165,  
Refactoring-Core-CamilloBruni.159, Polymorph-Widgets-CamilloBruni.684,  
Graphics-Primitives-CamilloBruni.88, Compiler-CamilloBruni.343,  
Kernel-CamilloBruni.1168, Files-CamilloBruni.ducasse.272,  
Graphics-CamilloBruni.6, FileSystem-Core-CamilloBruni.43,  
Tools-CamilloBruni.912, Collections-Unordered-CamilloBruni.137,  
Network-Protocols-CamilloBruni.79, Graphics-Fonts-CamilloBruni.63,  
System-CamilloBruni.9, Morphic-CamilloBruni.1206,  
Collections-Strings-CamilloBruni.222, Text-CamilloBruni.17,  
Collections-Streams-CamilloBruni.117, Graphics-Display  
Objects-CamilloBruni.80, System-Support-CamilloBruni.683

- removed log statements in the source code comments
- removed some author references in the source code
- minor source comment cleanups


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #2 on issue 6496 by [hidden email]: Remove Source Code  
Authors
http://code.google.com/p/pharo/issues/detail?id=6496#c2

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #3 on issue 6496 by [hidden email]: Remove Source Code  
Authors
http://code.google.com/p/pharo/issues/detail?id=6496#c3

Monkey went bananas:
--------------------
Error while loading  
SLICE-Issue-6496-Remove-Source-Code-Authors-CamilloBruni.1 from  
http://ss3.gemstone.com/ss/PharoInbox:
        MCMergeOrLoadWarning: You are about to load new versions of the following  
packages
that have unsaved changes in the image:

   Monticello
   Monticello

If you continue, you will lose these changes:
  1: MCVersionLoader>>warnAboutLosingChangesTo:ifCancel:ifMerge:
  2: MCVersionLoader>>checkForModificationsIfCancel:ifMerge:
  3: MCVersionLoader>>loadWithNameLike:
  4: MCVersionLoader>>load
  5: GoferLoad>>execute
  6: Gofer>>execute:do:
  7: Gofer>>execute:
  8: Gofer>>load
  9: GoferResolvedReference>>load
10: [self slice load] in UlysseTheMonkey>>loadSlice
        ...
----------------------------------------------------------
Loaded Source: SLICE-Issue-6496-Remove-Source-Code-Authors-CamilloBruni.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20238-a on CoInterpreter  
VMMaker-oscog-IgorStasenko.162 uuid: e4554f9a-cc90-4826-a807-ac282b782fe4  
Jul 26 2012
StackToRegisterMappingCogit VMMaker-oscog-IgorStasenko.162 uuid:  
e4554f9a-cc90-4826-a807-ac282b782fe4 Jul 26 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
aeb0705cde4b8fc57cb262dc051c5ee6dfa72a14 Date: 2012-07-26 16:38:48 +0200  
By: Igor Stasenko <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #4 on issue 6496 by [hidden email]: Remove Source Code  
Authors
http://code.google.com/p/pharo/issues/detail?id=6496

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #5 on issue 6496 by [hidden email]: Remove Source Code  
Authors
http://code.google.com/p/pharo/issues/detail?id=6496#c5

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #6 on issue 6496 by [hidden email]: Remove Source Code  
Authors
http://code.google.com/p/pharo/issues/detail?id=6496#c6

Monkey went bananas:
--------------------
Error while loading  
SLICE-Issue-6496-Remove-Source-Code-Authors-CamilloBruni.4 from  
http://ss3.gemstone.com/ss/PharoInbox:
        MCMergeOrLoadWarning: You are about to load new versions of the following  
packages
that have unsaved changes in the image:

   Compiler
   Compiler
   Kernel
   Kernel
   Monticello
   Monticello

If you continue, you will lose these changes:
  1: MCVersionLoader>>warnAboutLosingChangesTo:ifCancel:ifMerge:
  2: MCVersionLoader>>checkForModificationsIfCancel:ifMerge:
  3: MCVersionLoader>>loadWithNameLike:
  4: MCVersionLoader>>load
  5: GoferLoad>>execute
  6: Gofer>>execute:do:
  7: Gofer>>execute:
  8: Gofer>>load
  9: GoferResolvedReference>>load
10: [self slice load] in UlysseTheMonkey>>loadSlice
        ...
----------------------------------------------------------
Loaded Source: SLICE-Issue-6496-Remove-Source-Code-Authors-CamilloBruni.4  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20246-a on CoInterpreter  
VMMaker-oscog-IgorStasenko.162 uuid: e4554f9a-cc90-4826-a807-ac282b782fe4  
Aug  3 2012
StackToRegisterMappingCogit VMMaker-oscog-IgorStasenko.162 uuid:  
e4554f9a-cc90-4826-a807-ac282b782fe4 Aug  3 2012
git://gitorious.org/cogvm/blessed.git Commit:  
aeb0705cde4b8fc57cb262dc051c5ee6dfa72a14 Date: 2012-07-26 16:38:48 +0200  
By: Igor Stasenko <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: HumanReviewNeeded

Comment #7 on issue 6496 by [hidden email]: Remove Source Code  
Authors
http://code.google.com/p/pharo/issues/detail?id=6496

loads fine locally, some monkey issue here


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #8 on issue 6496 by [hidden email]: Remove Source Code Authors
http://code.google.com/p/pharo/issues/detail?id=6496

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #9 on issue 6496 by [hidden email]: Remove Source Code Authors
http://code.google.com/p/pharo/issues/detail?id=6496

in 20249


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email] [hidden email] [hidden email]  
[hidden email]

Comment #10 on issue 6496 by marianopeck: Remove Source Code Authors
http://code.google.com/p/pharo/issues/detail?id=6496

This slices of this issue creates an evil general package "Graphics". I  
have to remove it doing

(MCWorkingCopy forPackage: (MCPackage named: 'Graphics')) unregister

This is not the first time. We already have the problem with Pavel  
with 'System'. It seems "general" packages are being created. Maybe this  
can be related to: http://code.google.com/p/pharo/issues/detail?id=6461


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker