Issue 6505 in pharo: hasUnacceptedEdits breaks the debugger

Status: Accepted
Owner: [hidden email]
Labels: Type-Bug Milestone-2.0

New issue 6505 by [hidden email]: hasUnacceptedEdits breaks the  
debugger
http://code.google.com/p/pharo/issues/detail?id=6505

and SystemWindow

A slice is incoming implementing those methods


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #1 on issue 6505 by [hidden email]: hasUnacceptedEdits  
breaks the debugger
http://code.google.com/p/pharo/issues/detail?id=6505

Slice in the inbox


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #2 on issue 6505 by [hidden email]: hasUnacceptedEdits  
breaks the debugger
http://code.google.com/p/pharo/issues/detail?id=6505#c2

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20240

Comment #3 on issue 6505 by [hidden email]: hasUnacceptedEdits  
breaks the debugger
http://code.google.com/p/pharo/issues/detail?id=6505#c3

This Issue has been checked by Ulysse the Monkey
       
6420 tests passed in 00:04:23s:
===============================
        CollectionsTests-Arrayed (547)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (906)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (596)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1951)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        KernelTests-Chronology (583)
        KernelTests-Classes (67)
        KernelTests-Exception (2)
        KernelTests-Methods (178)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (31)
        MorphicTests-Basic (16)
        MorphicTests-Event (9)
        MorphicTests-Kernel (8)
        MorphicTests-Text Support (4)
        MorphicTests-Widgets (3)
        MorphicTests-WindowNotification (8)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)
        Tests-Polymorph-Widgets (10)
        ToolsTest-Base (2)
        ToolsTest-Debugger (10)
        ToolsTest-Finder (9)
        ToolsTest-Inspector (1)
        ToolsTest-MessageTally (5)
        ToolsTest-PointerFinder (3)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6505-hasUnacceptedEdits-breaks-the-debugger-BenjaminVanRyseghem.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20240-a on CoInterpreter  
VMMaker-oscog-IgorStasenko.162 uuid: e4554f9a-cc90-4826-a807-ac282b782fe4  
Jul 26 2012
StackToRegisterMappingCogit VMMaker-oscog-IgorStasenko.162 uuid:  
e4554f9a-cc90-4826-a807-ac282b782fe4 Jul 26 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
aeb0705cde4b8fc57cb262dc051c5ee6dfa72a14 Date: 2012-07-26 16:38:48 +0200  
By: Igor Stasenko <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #4 on issue 6505 by [hidden email]: hasUnacceptedEdits  
breaks the debugger
http://code.google.com/p/pharo/issues/detail?id=6505

It was removed in http://code.google.com/p/pharo/issues/detail?id=5899

I proposed a fix there to add it in MorphicModel (no good reason). What did  
you end up doing?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 6505 by [hidden email]: hasUnacceptedEdits  
breaks the debugger
http://code.google.com/p/pharo/issues/detail?id=6505

Returning false each time is a bit too manichean no ? :)

What I do here is to select first the dependents (or submorphs for the  
window) which understand #hasUnacceptedEdits and then I check if any of  
them has some

Sounds a bit hacky :s


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #6 on issue 6505 by [hidden email]: hasUnacceptedEdits  
breaks the debugger
http://code.google.com/p/pharo/issues/detail?id=6505

I missed a package


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 6505 by [hidden email]: hasUnacceptedEdits  
breaks the debugger
http://code.google.com/p/pharo/issues/detail?id=6505

"Returning false each time is a bit too manichean no ? :)"
I did the simplest possible to avoid the DNU... I didn't say it was a  
/good/ fix! ;-)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #8 on issue 6505 by [hidden email]: hasUnacceptedEdits  
breaks the debugger
http://code.google.com/p/pharo/issues/detail?id=6505#c8

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey

Comment #9 on issue 6505 by [hidden email]: hasUnacceptedEdits  
breaks the debugger
http://code.google.com/p/pharo/issues/detail?id=6505#c9

This Issue has been checked by Ulysse the Monkey
       
6420 tests passed in 00:02:15s:
===============================
        CollectionsTests-Arrayed (547)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (906)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (596)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1951)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        KernelTests-Chronology (583)
        KernelTests-Classes (67)
        KernelTests-Exception (2)
        KernelTests-Methods (178)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (31)
        MorphicTests-Basic (16)
        MorphicTests-Event (9)
        MorphicTests-Kernel (8)
        MorphicTests-Text Support (4)
        MorphicTests-Widgets (3)
        MorphicTests-WindowNotification (8)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)
        Tests-Polymorph-Widgets (10)
        ToolsTest-Base (2)
        ToolsTest-Debugger (10)
        ToolsTest-Finder (9)
        ToolsTest-Inspector (1)
        ToolsTest-MessageTally (5)
        ToolsTest-PointerFinder (3)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6505-hasUnacceptedEdits-breaks-the-debugger-BenjaminVanRyseghem.2  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20240-a on CoInterpreter  
VMMaker-oscog-IgorStasenko.162 uuid: e4554f9a-cc90-4826-a807-ac282b782fe4  
Jul 26 2012
StackToRegisterMappingCogit VMMaker-oscog-IgorStasenko.162 uuid:  
e4554f9a-cc90-4826-a807-ac282b782fe4 Jul 26 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
aeb0705cde4b8fc57cb262dc051c5ee6dfa72a14 Date: 2012-07-26 16:38:48 +0200  
By: Igor Stasenko <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #10 on issue 6505 by [hidden email]: hasUnacceptedEdits breaks  
the debugger
http://code.google.com/p/pharo/issues/detail?id=6505

ok, I don't like the #respondsTo:, but there is no other easy way to do  
it :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #11 on issue 6505 by [hidden email]: hasUnacceptedEdits breaks  
the debugger
http://code.google.com/p/pharo/issues/detail?id=6505

in 20241


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #12 on issue 6505 by [hidden email]: hasUnacceptedEdits  
breaks the debugger
http://code.google.com/p/pharo/issues/detail?id=6505

Issue 5899 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker