Issue 6523 in pharo: Bug in RPackage >> systemSubPackages

Status: Accepted
Owner: marianopeck
CC: [hidden email],  [hidden email],  [hidden email]
Labels: Type-Bug Milestone-2.0

New issue 6523 by marianopeck: Bug in RPackage >> systemSubPackages
http://code.google.com/p/pharo/issues/detail?id=6523

hi. It says:

systemSubPackages

        "return all RPackages matching with systemCategories of this RPackage"
        |tmpPackages|
        tmpPackages := OrderedCollection new.
        self systemCategories do: [:aString |
                (aString asSymbol = self name) ifFalse: [
                        |tmpPackage|
                        "Maybe a RPackage matching the subcategory name does not yet exist in  
the organizer (Because packageInfo lazily register category from system).  
In this case, We should also lazily register a new RPackage with the right  
contents inside:"
                        tmpPackage := self organizer packageNamed: aString asSymbol ifAbsent:  
[self organizer importFromPackageInfo: (PackageInfo named: aString)].
                        tmpPackages add: (tmpPackage).
                        ].
                ].
        ^ tmpPackages


but when it does "self organizer default" should be "self organizer"

slice coming


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #1 on issue 6523 by marianopeck: Bug in RPackage >>  
systemSubPackages
http://code.google.com/p/pharo/issues/detail?id=6523

Fix in inbox

Name:  
SLICE-Issue-6523-Bug-in-RPackage-systemSubPackages-MarianoMartinezPeck.1
Author: MarianoMartinezPeck
Time: 4 August 2012, 6:03:07.444 pm
UUID: 4139a5c9-f571-42b3-87ef-2f71e3b2e1fe
Ancestors:
Dependencies: RPackage-Core-MarianoMartinezPeck.151

Fix to issue 6523


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #2 on issue 6523 by [hidden email]: Bug in RPackage >>  
systemSubPackages
http://code.google.com/p/pharo/issues/detail?id=6523#c2

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20244

Comment #3 on issue 6523 by [hidden email]: Bug in RPackage >>  
systemSubPackages
http://code.google.com/p/pharo/issues/detail?id=6523#c3

This Issue has been checked by Ulysse the Monkey
       
6332 tests passed in 00:01:28s:
===============================
        CollectionsTests-Arrayed (547)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (906)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (596)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1951)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        KernelTests-Chronology (583)
        KernelTests-Classes (67)
        KernelTests-Exception (2)
        KernelTests-Methods (178)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (31)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6523-Bug-in-RPackage-systemSubPackages-MarianoMartinezPeck.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20244-a on CoInterpreter  
VMMaker-oscog-IgorStasenko.162 uuid: e4554f9a-cc90-4826-a807-ac282b782fe4  
Aug  3 2012
StackToRegisterMappingCogit VMMaker-oscog-IgorStasenko.162 uuid:  
e4554f9a-cc90-4826-a807-ac282b782fe4 Aug  3 2012
git://gitorious.org/cogvm/blessed.git Commit:  
aeb0705cde4b8fc57cb262dc051c5ee6dfa72a14 Date: 2012-07-26 16:38:48 +0200  
By: Igor Stasenko <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #4 on issue 6523 by marianopeck: Bug in RPackage >>  
systemSubPackages
http://code.google.com/p/pharo/issues/detail?id=6523

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 6523 by [hidden email]: Bug in RPackage >>  
systemSubPackages
http://code.google.com/p/pharo/issues/detail?id=6523

berk what is subsystemPackages?
Who call that?
We should kill that there is no such thing as subsystemPackages


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 6523 by [hidden email]: Bug in RPackage >>  
systemSubPackages
http://code.google.com/p/pharo/issues/detail?id=6523

Mariano nobody should use this method and everything in the compatibility  
layer should get killed

allDefinedClasses
allMethodReferences

have no senders so we should get rid of them.




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 6523 by marianopeck: Bug in RPackage >>  
systemSubPackages
http://code.google.com/p/pharo/issues/detail?id=6523

I am using both of them #allDefinedClasses #allMethodReferences for Tanker  
(both for kernel reconstruction and for Seaside export/import). If you  
remove that, the only way is to use PackageInfo. And we don't want that,  
right?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 6523 by [hidden email]: Bug in RPackage >>  
systemSubPackages
http://code.google.com/p/pharo/issues/detail?id=6523

I believe that for tanker you should specify the exact package names...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 6523 by [hidden email]: Bug in RPackage >>  
systemSubPackages
http://code.google.com/p/pharo/issues/detail?id=6523

Again let me repeat it: can we think in terms of layers?
You should not rely on MC layer for fuel.

Use PackageInfo for now and be ready to migrate to RPackage.
MC will be building MCPackage based on RPackage.

Is it clear?

Stef


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 6523 by [hidden email]: Bug in RPackage >>  
systemSubPackages
http://code.google.com/p/pharo/issues/detail?id=6523

ok, I will integrate this, just because is there... Mariano, pls check  
stefs recommendations.
As I said, you need to stop thinking on terms of X-A, X-B. X-C and start  
thinking on X (with tags A, B, C).


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #11 on issue 6523 by [hidden email]: Bug in RPackage >>  
systemSubPackages
http://code.google.com/p/pharo/issues/detail?id=6523

in 20245


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker