Issue 6524 in pharo: StartupPreferences loads non-Smalltalk files

Status: Accepted
Owner: [hidden email]
Labels: Type-Bug Milestone-2.0 Difficulty-Easy

New issue 6524 by [hidden email]: StartupPreferences loads  
non-Smalltalk files
http://code.google.com/p/pharo/issues/detail?id=6524

If there are other files in the preferences folders, without .st  
extensions, Pharo tries to load them and gives compiler errors.

Slice incoming...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #1 on issue 6524 by [hidden email]: StartupPreferences loads  
non-Smalltalk files
http://code.google.com/p/pharo/issues/detail?id=6524

Fix in inbox:  
SLICE-Issue-6524-StartupPreferences-loads-non-Smalltalk-files-SeanDeNigris.1

* Refactor script lookup to reduce duplication
* Only load files with .st extensions
* Small cleanups - e.g. method comments


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #2 on issue 6524 by [hidden email]: StartupPreferences loads  
non-Smalltalk files
http://code.google.com/p/pharo/issues/detail?id=6524#c2

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20244

Comment #3 on issue 6524 by [hidden email]: StartupPreferences loads  
non-Smalltalk files
http://code.google.com/p/pharo/issues/detail?id=6524#c3

This Issue has been checked by Ulysse the Monkey
       
6332 tests passed in 00:01:27s:
===============================
        CollectionsTests-Arrayed (547)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (906)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (596)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1951)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        KernelTests-Chronology (583)
        KernelTests-Classes (67)
        KernelTests-Exception (2)
        KernelTests-Methods (178)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (31)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6524-StartupPreferences-loads-non-Smalltalk-files-SeanDeNigris.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20244-a on CoInterpreter  
VMMaker-oscog-IgorStasenko.162 uuid: e4554f9a-cc90-4826-a807-ac282b782fe4  
Aug  3 2012
StackToRegisterMappingCogit VMMaker-oscog-IgorStasenko.162 uuid:  
e4554f9a-cc90-4826-a807-ac282b782fe4 Aug  3 2012
git://gitorious.org/cogvm/blessed.git Commit:  
aeb0705cde4b8fc57cb262dc051c5ee6dfa72a14 Date: 2012-07-26 16:38:48 +0200  
By: Igor Stasenko <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #4 on issue 6524 by marianopeck: StartupPreferences loads  
non-Smalltalk files
http://code.google.com/p/pharo/issues/detail?id=6524

I have just checked your changes and I like them!! Let's integrate it :)



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #5 on issue 6524 by [hidden email]: StartupPreferences loads  
non-Smalltalk files
http://code.google.com/p/pharo/issues/detail?id=6524

in 20246


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker