Issue 6529 in pharo: Method changes not picked up by MC Browser

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 6529 in pharo: Method changes not picked up by MC Browser

pharo
Status: Accepted
Owner: [hidden email]
Labels: Type-Bug Milestone-2.0 Importance-High

New issue 6529 by [hidden email]: Method changes not picked up by MC  
Browser
http://code.google.com/p/pharo/issues/detail?id=6529

Pharo2.0a
Latest update: #20244

DoIt: AnnouncementSetTest compile: 'testInstanceCreation
        |set|
        set := AnnouncementMockA, AnnouncementMockB.
        self assert: set size = 2.' classified: 'testing'.

Opening MC Browser, the Announcements-Tests-Core package shows no changes

Now, if you select the package and the pharo 2.0 repo and click changes, it  
will mark as dirty and show the change


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6529 in pharo: Method changes not picked up by MC Browser

pharo
Updates:
        Cc: [hidden email]

Comment #1 on issue 6529 by [hidden email]: Method changes not  
picked up by MC Browser
http://code.google.com/p/pharo/issues/detail?id=6529

This was broken in 20244
-----

Issue 6516: SystemChangeNotifier - cleanup Step 3
         http://code.google.com/p/pharo/issues/detail?id=6516


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6529 in pharo: Method changes not picked up by MC Browser

pharo

Comment #2 on issue 6529 by marianopeck: Method changes not picked up by MC  
Browser
http://code.google.com/p/pharo/issues/detail?id=6529

Hi, yes, I have seen this problem as well:

- dirty packages do not appear to be dirty to MC
- to packages I am sure I have changed something (even if they do not  
appear as dirty), I do a "changes" with MC and it says "no changes" when  
there actually were a lot


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6529 in pharo: Method changes not picked up by MC Browser

pharo
Updates:
        Status: FixReviewNeeded

Comment #3 on issue 6529 by [hidden email]: Method changes not  
picked up by MC Browser
http://code.google.com/p/pharo/issues/detail?id=6529

MCWorkingCopy has to be subscribed to announcements in addition to  
MCPackageManager.

Slice in inbox  
(SLICE-Issue-6529-Method-changes-not-picked-up-by-MC-Browser-GuillermoPolito.2)

PostLoad: "SystemAnnouncer restoreAllNotifications"

can someone check? :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6529 in pharo: Method changes not picked up by MC Browser

pharo
Updates:
        Status: MonkeyIsChecking

Comment #4 on issue 6529 by [hidden email]: Method changes not  
picked up by MC Browser
http://code.google.com/p/pharo/issues/detail?id=6529#c4

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6529 in pharo: Method changes not picked up by MC Browser

pharo
Updates:
        Status: WorkNeeded

Comment #5 on issue 6529 by [hidden email]: Method changes not  
picked up by MC Browser
http://code.google.com/p/pharo/issues/detail?id=6529#c5

Monkey went bananas:
--------------------
Error while loading  
SLICE-Issue-6529-Method-changes-not-picked-up-by-MC-Browser-GuillermoPolito.2  
from http://ss3.gemstone.com/ss/PharoInbox:
        MCMergeOrLoadWarning: You are about to load new versions of the following  
packages
that have unsaved changes in the image:

   Monticello
   Monticello

If you continue, you will lose these changes:
  1: MCVersionLoader>>warnAboutLosingChangesTo:ifCancel:ifMerge:
  2: MCVersionLoader>>checkForModificationsIfCancel:ifMerge:
  3: MCVersionLoader>>loadWithNameLike:
  4: MCVersionLoader>>load
  5: GoferLoad>>execute
  6: Gofer>>execute:do:
  7: Gofer>>execute:
  8: Gofer>>load
  9: GoferResolvedReference>>load
10: [self slice load] in UlysseTheMonkey>>loadSlice
        ...
----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6529-Method-changes-not-picked-up-by-MC-Browser-GuillermoPolito.2  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20244-a on CoInterpreter  
VMMaker-oscog-IgorStasenko.162 uuid: e4554f9a-cc90-4826-a807-ac282b782fe4  
Aug  3 2012
StackToRegisterMappingCogit VMMaker-oscog-IgorStasenko.162 uuid:  
e4554f9a-cc90-4826-a807-ac282b782fe4 Aug  3 2012
git://gitorious.org/cogvm/blessed.git Commit:  
aeb0705cde4b8fc57cb262dc051c5ee6dfa72a14 Date: 2012-07-26 16:38:48 +0200  
By: Igor Stasenko <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6529 in pharo: Method changes not picked up by MC Browser

pharo
Updates:
        Cc: [hidden email]

Comment #6 on issue 6529 by [hidden email]: Method changes not  
picked up by MC Browser
http://code.google.com/p/pharo/issues/detail?id=6529

The slice fixed my use case in the original comment


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6529 in pharo: Method changes not picked up by MC Browser

pharo
Updates:
        Status: FixToInclude

Comment #7 on issue 6529 by marianopeck: Method changes not picked up by MC  
Browser
http://code.google.com/p/pharo/issues/detail?id=6529

It works and seems fine. FixToInclude :(
Thanks Guille


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6529 in pharo: Method changes not picked up by MC Browser

pharo

Comment #8 on issue 6529 by marianopeck: Method changes not picked up by MC  
Browser
http://code.google.com/p/pharo/issues/detail?id=6529

uuh sorrt, s/:(/:)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6529 in pharo: Method changes not picked up by MC Browser

pharo
Updates:
        Status: Integrated

Comment #9 on issue 6529 by [hidden email]: Method changes not picked  
up by MC Browser
http://code.google.com/p/pharo/issues/detail?id=6529

in 20246


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker