Issue 6531 in pharo: Not possible to save one click image on Windows

Status: Accepted
Owner: [hidden email]
Labels: Type-Bug

New issue 6531 by [hidden email]: Not possible to save one click  
image on Windows
http://code.google.com/p/pharo/issues/detail?id=6531

- Pharo2.0a Latest update: #20244
- WindowsXP

Steps to reproduce
A) Download the one click image from Jenkins

     
https://ci.lille.inria.fr/pharo/view/Pharo%202.0/job/Pharo-2.0/lastSuccessfulBuild/artifact/Pharo-2.0-one-click.zip

    Extract the archive and start "Pharo-2.0-one-click.bat"

B) Go to the world menu and select "Save"

=> Message appears "Got startup errors"




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Milestone-2.0

Comment #1 on issue 6531 by [hidden email]: Not possible to save one  
click image on Windows
http://code.google.com/p/pharo/issues/detail?id=6531

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 6531 by [hidden email]: Not possible to save one  
click image on Windows
http://code.google.com/p/pharo/issues/detail?id=6531

Looks like the system tries to open the changes file a second time.

FileReference allInstances

returns two instances on the changes file.

This is a blocker to use Pharo 2.0 on Windows ...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Target-Filesystem Importance-High

Comment #3 on issue 6531 by [hidden email]: Not possible to save one  
click image on Windows
http://code.google.com/p/pharo/issues/detail?id=6531

During image save #checkAndOpenSourcesAndChanges is called - which
tries to open the changes file for a second time (due to the mixed
old and new filesystem code) - which is not possible on windows since
it is already open. In fact it should just be opened once - but this
seems to be no problem on other platforms than windows.

Just evaluate

  SmalltalkImage current checkAndOpenSourcesAndChanges

in a workspace right after opening a freshly downloaded
2.0 one click image from CI server and you can easily hit the error.

If you debug you will notice that in FileSystem>>writeStreamOn:
  - the file is opened first time (by sending #open:#writable: to self)
  - and a second time by sending a #writeStream in the same method
    (which ends up in  FileStream>>onHandle: returning nil since
     it tries to open the file again instead of using the existing
     handle)

Maybe someone with more insights into the intentions of the
new filesystem logic can look into this and help.









_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 6531 by [hidden email]: Not possible to save  
one click image on Windows
http://code.google.com/p/pharo/issues/detail?id=6531

Today we were checking it with Ezequiel(he has a windowze machine). The  
problem seems to be in

StandardFileStream>>open: fileName forWrite: writeMode
...
        fileID := StandardFileStream retryWithGC:[self primOpen: f writable:  
writeMode]
                                        until:[:id| id notNil]
                                        forFileNamed: fileName.
...

that expression yields nil in Windows while in Mac/Unix it yields a file  
handle.

Still looking at it.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #5 on issue 6531 by [hidden email]: Not possible to save one  
click image on Windows
http://code.google.com/p/pharo/issues/detail?id=6531

The expression yields nil since you are not allowed to open multiple write  
streams on the same file in Windows.

A valid solution is to only open change file as part of startUp when we are  
actually resuming an image, see  
SLICE-Issue-6531-Not-possible-to-save-one-click-image-on-Windows--HenrikSperreJohansen.1


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #6 on issue 6531 by [hidden email]: Not possible to save one  
click image on Windows
http://code.google.com/p/pharo/issues/detail?id=6531#c6

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20305

Comment #7 on issue 6531 by [hidden email]: Not possible to save one  
click image on Windows
http://code.google.com/p/pharo/issues/detail?id=6531#c7

This Issue has been checked by Ulysse the Monkey
       
6355 tests passed in 00:01:48s:
===============================
        CollectionsTests-Arrayed (553)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (912)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (602)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1954)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        KernelTests-Chronology (583)
        KernelTests-Classes (68)
        KernelTests-Exception (2)
        KernelTests-Methods (179)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (31)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6531-Not-possible-to-save-one-click-image-on-Windows--HenrikSperreJohansen.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20305-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.164 uuid:  
d77dee73-00f5-4d00-847b-00646b08329d Sep 25 2012
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.164 uuid:  
d77dee73-00f5-4d00-847b-00646b08329d Sep 25 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
bfc9fe2c4abcd2972c8bd9eac1c77f9baaf23e8a Date: 2012-09-25 13:34:47 +0200  
By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 6531 by [hidden email]: Not possible to save one  
click image on Windows
http://code.google.com/p/pharo/issues/detail?id=6531

For the record, FileHandle open:writable: currently does nothing, the  
actual file is only opened by FileStream onHandle: method.

The duplicate opening that caused the error happened since startUp tried  
opening changes file irregardless of whether any were already open (when  
saved without quitting) or not (when resuming an image snapshot)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #9 on issue 6531 by [hidden email]: Not possible to save one  
click image on Windows
http://code.google.com/p/pharo/issues/detail?id=6531

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #10 on issue 6531 by [hidden email]: Not possible to save  
one click image on Windows
http://code.google.com/p/pharo/issues/detail?id=6531

in 3.0 307


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #11 on issue 6531 by [hidden email]: Not possible to save one  
click image on Windows
http://code.google.com/p/pharo/issues/detail?id=6531

THANKS !!!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker