Issue 6544 in pharo: [ENH]: SystemPreferences - Notify Errors

Status: Accepted
Owner: [hidden email]
CC: [hidden email]
Labels: Type-Enh Milestone-2.0 Difficulty-Easy

New issue 6544 by [hidden email]: [ENH]: SystemPreferences - Notify  
Errors
http://code.google.com/p/pharo/issues/detail?id=6544

Right now, errors are logged, but there is no notification.

How about simply opening up an explorer on the errors?

Slice incoming...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #1 on issue 6544 by [hidden email]: [ENH]: SystemPreferences  
- Notify Errors
http://code.google.com/p/pharo/issues/detail?id=6544

Slice in inbox:  
SLICE-Issue-6544-ENH-SystemPreferences---Notify-Errors-SeanDeNigris.1
Open an explorer on StartupPreferences errors


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #2 on issue 6544 by [hidden email]: [ENH]: SystemPreferences  
- Notify Errors
http://code.google.com/p/pharo/issues/detail?id=6544#c2

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20248

Comment #3 on issue 6544 by [hidden email]: [ENH]: SystemPreferences  
- Notify Errors
http://code.google.com/p/pharo/issues/detail?id=6544#c3

This Issue has been checked by Ulysse the Monkey
       
6333 tests passed in 00:01:33s:
===============================
        CollectionsTests-Arrayed (547)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (906)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (596)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1951)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        KernelTests-Chronology (583)
        KernelTests-Classes (67)
        KernelTests-Exception (2)
        KernelTests-Methods (179)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (31)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6544-ENH-SystemPreferences---Notify-Errors-SeanDeNigris.1 from  
http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20248-a on CoInterpreter  
VMMaker-oscog-IgorStasenko.162 uuid: e4554f9a-cc90-4826-a807-ac282b782fe4  
Aug  3 2012
StackToRegisterMappingCogit VMMaker-oscog-IgorStasenko.162 uuid:  
e4554f9a-cc90-4826-a807-ac282b782fe4 Aug  3 2012
git://gitorious.org/cogvm/blessed.git Commit:  
aeb0705cde4b8fc57cb262dc051c5ee6dfa72a14 Date: 2012-07-26 16:38:48 +0200  
By: Igor Stasenko <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #4 on issue 6544 by [hidden email]: [ENH]: SystemPreferences -  
Notify Errors
http://code.google.com/p/pharo/issues/detail?id=6544

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: HumanReviewNeeded

Comment #5 on issue 6544 by [hidden email]: [ENH]: SystemPreferences -  
Notify Errors
http://code.google.com/p/pharo/issues/detail?id=6544

sorry, Sean... why not add the load in a deferred startup, so it just show  
a debugger? Is not better than open an explorer?



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #6 on issue 6544 by [hidden email]: [ENH]: SystemPreferences  
- Notify Errors
http://code.google.com/p/pharo/issues/detail?id=6544

@esteban: Sure, that sounds great. The load is actually /already/ done in a  
deferred startup action, so it seems all we have to do is not catch the  
errors. The relevant bit is:
        StartupAction>>execute
                ...
                block on: Halt,Error do: [:ex | StartupLoader default errors add: {ex.  
self}. correctlyExecuted := false].
                self hasBeenExecuted: correctlyExecuted.

If we pass the exceptions on, that would take care of this immediate  
problem:
                block on: Halt,Error do: [:ex | StartupLoader default errors add: {ex.  
self}. ex pass].

Question: Should we still collect the errors in StartupLoader? What was/is  
the purpose of this?

New slice in inbox:  
SLICE-Issue-6544-ENH-SystemPreferences---Notify-Errors-SeanDeNigris.3
Pass StartupAction errors after logging them

This version: if #pass returns, then the error was fixed in the debugger,  
so mark the StartupAction as having been executed.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #7 on issue 6544 by [hidden email]: [ENH]: SystemPreferences -  
Notify Errors
http://code.google.com/p/pharo/issues/detail?id=6544

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 6544 by [hidden email]: [ENH]: SystemPreferences -  
Notify Errors
http://code.google.com/p/pharo/issues/detail?id=6544

no idea about the collection on startup... camillo can say something,  
probably :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #9 on issue 6544 by [hidden email]: [ENH]: SystemPreferences -  
Notify Errors
http://code.google.com/p/pharo/issues/detail?id=6544

in 20250


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker