Issue 6558 in pharo: CompiledMethod>>#package does not resolve well with Class side methods

Status: Accepted
Owner: [hidden email]
Labels: Type-Bug Milestone-2.0

New issue 6558 by [hidden email]: CompiledMethod>>#package does  
not resolve well with Class side methods
http://code.google.com/p/pharo/issues/detail?id=6558

(FileStream class>>#onHandle:) package
  -> yields nil


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #1 on issue 6558 by [hidden email]:  
CompiledMethod>>#package does not resolve well with Class side methods
http://code.google.com/p/pharo/issues/detail?id=6558

Slice in inbox with fix + test.

Come monkey


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #2 on issue 6558 by [hidden email]: CompiledMethod>>#package  
does not resolve well with Class side methods
http://code.google.com/p/pharo/issues/detail?id=6558#c2

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #3 on issue 6558 by [hidden email]: CompiledMethod>>#package  
does not resolve well with Class side methods
http://code.google.com/p/pharo/issues/detail?id=6558#c3

Monkey went bananas:
--------------------
Error while loading  
SLICE-Issue-6558-CompiledMethodgtgtpackage-does-not-resolve-well-with-Class-side-methods-GuillermoPolito.1  
from http://ss3.gemstone.com/ss/PharoInbox:
        Error: Working copy for  
SLICE-Issue-6558-CompiledMethodgtgtpackage-does-not-resolve-well-with-Class-side-methods  
not found
  1: GoferPackageReference(Object)>>error:
  2: [self error: 'Working copy for ' , self name , ' not found'] in  
GoferPackageReference(GoferReference)>>workingCopy
  3: Array(Collection)>>detect:ifNone:
  4: GoferPackageReference(GoferReference)>>workingCopy
  5: GoferMerge(GoferWorking)>>addReference:
  6: GoferMerge(GoferUpdate)>>addReference:
  7: [:each | self addReference: each] in  
GoferMerge(GoferWorking)>>initializeOn:
  8: Array(SequenceableCollection)>>do:
  9: GoferMerge(GoferWorking)>>initializeOn:
10: GoferMerge class(GoferOperation class)>>on:
        ...
----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6558-CompiledMethodgtgtpackage-does-not-resolve-well-with-Class-side-methods-GuillermoPolito.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20250-a on CoInterpreter  
VMMaker-oscog-IgorStasenko.162 uuid: e4554f9a-cc90-4826-a807-ac282b782fe4  
Aug  3 2012
StackToRegisterMappingCogit VMMaker-oscog-IgorStasenko.162 uuid:  
e4554f9a-cc90-4826-a807-ac282b782fe4 Aug  3 2012
git://gitorious.org/cogvm/blessed.git Commit:  
aeb0705cde4b8fc57cb262dc051c5ee6dfa72a14 Date: 2012-07-26 16:38:48 +0200  
By: Igor Stasenko <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: HumanReviewNeeded

Comment #4 on issue 6558 by [hidden email]:  
CompiledMethod>>#package does not resolve well with Class side methods
http://code.google.com/p/pharo/issues/detail?id=6558

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude
        Cc: [hidden email]

Comment #5 on issue 6558 by marianopeck: CompiledMethod>>#package does not  
resolve well with Class side methods
http://code.google.com/p/pharo/issues/detail?id=6558

Ok. Looks good. but  #includesSelector:ofMetaclassName:  is a really really  
bad name because the last argument is actually the name of the class, not  
the metaclass.




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 6558 by [hidden email]: CompiledMethod>>#package  
does not resolve well with Class side methods
http://code.google.com/p/pharo/issues/detail?id=6558

Well how do you name a method that check wether the selector of a metaclass  
***NAME*** is included?
And without having to parse and validate the argument? Because  
passing 'Point class' is not a solution

includesSelector:ofClassName: 'Point'

is for a class

includesSelector:ofMetaClassName: 'Point'
is for the metaclass Point class


So I can you that I pay really attention about these selector names.




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #7 on issue 6558 by [hidden email]: CompiledMethod>>#package  
does not resolve well with Class side methods
http://code.google.com/p/pharo/issues/detail?id=6558

in 2.0 251


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 6558 by [hidden email]: CompiledMethod>>#package  
does not resolve well with Class side methods
http://code.google.com/p/pharo/issues/detail?id=6558

I merged the pacakge but there was no changed code inside? Maybe it was  
already added?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker