Issue 6632 in pharo: assert:equals: reverse the order of the printed arguments

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
14 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 6632 in pharo: assert:equals: reverse the order of the printed arguments

pharo
Status: Accepted
Owner: ----
Labels: Milestone-2.0 Type-Feature

New issue 6632 by [hidden email]: assert:equals: reverse the order  
of the printed arguments
http://code.google.com/p/pharo/issues/detail?id=6632

assert:equals: has been subject to wild argument swaps over the past.
The main reason for that lies in the order of the printed error message:

self assert: 1 equals: 2.

results in the warning: "Expected 2 but was 1" which does NOT correspond
to the order in the sources.

I suggest using: "Got 1 instead of 2" which helps more


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6632 in pharo: assert:equals: reverse the order of the printed arguments

pharo

Comment #1 on issue 6632 by [hidden email]: assert:equals: reverse  
the order of the printed arguments
http://code.google.com/p/pharo/issues/detail?id=6632

Also, the actual value, which is more likely to be interesting, will be  
less likely to be truncated in the window title


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6632 in pharo: assert:equals: reverse the order of the printed arguments

pharo

Comment #2 on issue 6632 by [hidden email]: assert:equals: reverse  
the order of the printed arguments
http://code.google.com/p/pharo/issues/detail?id=6632

might make sense to popup something like a diff dialog if the thing is too  
long to compare :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6632 in pharo: assert:equals: reverse the order of the printed arguments

pharo
Updates:
        Status: FixReviewNeeded

Comment #3 on issue 6632 by [hidden email]: assert:equals: reverse  
the order of the printed arguments
http://code.google.com/p/pharo/issues/detail?id=6632

Name:  
SLICE-Issue-6632-assertequals-reverse-the-order-of-the-printed-arguments-CamilloBruni.1
Author: CamilloBruni
Time: 22 September 2012, 7:17:59.839 pm
UUID: 4904278b-8cc7-4069-a264-30d7e41a2d19
Ancestors:
Dependencies: SUnit-Core-CamilloBruni.51, SUnit-Tests-CamilloBruni.15

changed description of assert:equals: to 'Got ... instead of ...'


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6632 in pharo: assert:equals: reverse the order of the printed arguments

pharo
Updates:
        Status: MonkeyIsChecking

Comment #4 on issue 6632 by [hidden email]: assert:equals: reverse  
the order of the printed arguments
http://code.google.com/p/pharo/issues/detail?id=6632#c4

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6632 in pharo: assert:equals: reverse the order of the printed arguments

pharo
Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20301

Comment #5 on issue 6632 by [hidden email]: assert:equals: reverse  
the order of the printed arguments
http://code.google.com/p/pharo/issues/detail?id=6632#c5

This Issue has been checked by Ulysse the Monkey
       
6418 tests passed in 00:01:59s:
===============================
        CollectionsTests-Arrayed (547)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (906)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (596)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1951)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        KernelTests-Chronology (583)
        KernelTests-Classes (68)
        KernelTests-Exception (2)
        KernelTests-Methods (179)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (31)
        SUnit-Core-Extensions (6)
        SUnit-Core-Utilities (6)
        SUnit-Tests-Core (156)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6632-assertequals-reverse-the-order-of-the-printed-arguments-CamilloBruni.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20301-a on CoInterpreter  
VMMaker-oscog-IgorStasenko.162 uuid: e4554f9a-cc90-4826-a807-ac282b782fe4  
Sep 21 2012
StackToRegisterMappingCogit VMMaker-oscog-IgorStasenko.162 uuid:  
e4554f9a-cc90-4826-a807-ac282b782fe4 Sep 21 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
2bb83f5f8aba323abaa0a2f530cf4322dfef8158 Date: 2012-09-18 13:24:46 +0200  
By: Igor Stasenko <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6632 in pharo: assert:equals: reverse the order of the printed arguments

pharo
Updates:
        Status: WorkNeeded

Comment #6 on issue 6632 by [hidden email]: assert:equals: reverse  
the order of the printed arguments
http://code.google.com/p/pharo/issues/detail?id=6632

Slice has 5 clonflicts


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6632 in pharo: assert:equals: reverse the order of the printed arguments

pharo
Updates:
        Status: FixReviewNeeded

Comment #7 on issue 6632 by [hidden email]: assert:equals: reverse  
the order of the printed arguments
http://code.google.com/p/pharo/issues/detail?id=6632

no conflicts here, otherwise the monkey would have barked (what's the  
monkey noise?) as well


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6632 in pharo: assert:equals: reverse the order of the printed arguments

pharo
Updates:
        Status: MonkeyIsChecking

Comment #8 on issue 6632 by [hidden email]: assert:equals: reverse  
the order of the printed arguments
http://code.google.com/p/pharo/issues/detail?id=6632#c8

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6632 in pharo: assert:equals: reverse the order of the printed arguments

pharo
Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20303

Comment #9 on issue 6632 by [hidden email]: assert:equals: reverse  
the order of the printed arguments
http://code.google.com/p/pharo/issues/detail?id=6632#c9

This Issue has been checked by Ulysse the Monkey
       
6439 tests passed in 00:03:26s:
===============================
        CollectionsTests-Arrayed (553)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (912)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (602)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1954)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        KernelTests-Chronology (583)
        KernelTests-Classes (68)
        KernelTests-Exception (2)
        KernelTests-Methods (179)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (31)
        SUnit-Core-Extensions (6)
        SUnit-Core-Utilities (6)
        SUnit-Tests-Core (156)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6632-assertequals-reverse-the-order-of-the-printed-arguments-CamilloBruni.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20303-a on CoInterpreter  
VMMaker-oscog-IgorStasenko.162 uuid: e4554f9a-cc90-4826-a807-ac282b782fe4  
Sep 21 2012
StackToRegisterMappingCogit VMMaker-oscog-IgorStasenko.162 uuid:  
e4554f9a-cc90-4826-a807-ac282b782fe4 Sep 21 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
2bb83f5f8aba323abaa0a2f530cf4322dfef8158 Date: 2012-09-18 13:24:46 +0200  
By: Igor Stasenko <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6632 in pharo: assert:equals: reverse the order of the printed arguments

pharo
Updates:
        Status: MonkeyIsChecking

Comment #10 on issue 6632 by [hidden email]: assert:equals: reverse  
the order of the printed arguments
http://code.google.com/p/pharo/issues/detail?id=6632#c10

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6632 in pharo: assert:equals: reverse the order of the printed arguments

pharo
Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20304

Comment #11 on issue 6632 by [hidden email]: assert:equals: reverse  
the order of the printed arguments
http://code.google.com/p/pharo/issues/detail?id=6632#c11

This Issue has been checked by Ulysse the Monkey
       
6439 tests passed in 00:01:55s:
===============================
        CollectionsTests-Arrayed (553)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (912)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (602)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1954)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        KernelTests-Chronology (583)
        KernelTests-Classes (68)
        KernelTests-Exception (2)
        KernelTests-Methods (179)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (31)
        SUnit-Core-Extensions (6)
        SUnit-Core-Utilities (6)
        SUnit-Tests-Core (156)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6632-assertequals-reverse-the-order-of-the-printed-arguments-CamilloBruni.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20304-a on CoInterpreter  
VMMaker-oscog-IgorStasenko.162 uuid: e4554f9a-cc90-4826-a807-ac282b782fe4  
Sep 21 2012
StackToRegisterMappingCogit VMMaker-oscog-IgorStasenko.162 uuid:  
e4554f9a-cc90-4826-a807-ac282b782fe4 Sep 21 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
2bb83f5f8aba323abaa0a2f530cf4322dfef8158 Date: 2012-09-18 13:24:46 +0200  
By: Igor Stasenko <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6632 in pharo: assert:equals: reverse the order of the printed arguments

pharo
Updates:
        Status: FixToInclude

Comment #12 on issue 6632 by [hidden email]: assert:equals: reverse  
the order of the printed arguments
http://code.google.com/p/pharo/issues/detail?id=6632

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6632 in pharo: assert:equals: reverse the order of the printed arguments

pharo
Updates:
        Status: Integrated

Comment #13 on issue 6632 by [hidden email]: assert:equals: reverse  
the order of the printed arguments
http://code.google.com/p/pharo/issues/detail?id=6632

in 2.0 306


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker