Issue 6650 in pharo: RBInternalSpellChecker not using 2.0 API

Status: Accepted
Owner: ----
Labels: Milestone-2.0 Type-Bug

New issue 6650 by [hidden email]: RBInternalSpellChecker not using  
2.0 API
http://code.google.com/p/pharo/issues/detail?id=6650

RBInternalSpellChecker is still using HTTPSocket instead of ZnClient and is  
not fully ported to FileSystem.

Slice is coming, but here are the relevant changes:

RBInternalSpellChecker>>downloadData
        "Download data from a server."

        ZnClient new
  systemPolicy;
                beOneShot;
                url: self uri;
                downloadTo: self directory

RBInternalSpellChecker>>loadData
        "Load data from an external file as fast as possible."

        | result stream |
        (self directory / self filename) exists
                ifFalse: [ self downloadData ].
        (self directory / self filename) exists
                ifFalse: [ self error: 'The spelling dictionary cannot be downloaded from  
<' , self url , '>.' ].
        stream := (self directory / self filename) readStream.
        [ | zstream size |
                zstream := ZLibReadStream on: stream binary.
                result := Array new: (size := zstream nextInt32).
                1 to: size do: [ :index | result at: index put: (String withAll: (zstream  
next: zstream next)) ] ]
                        ensure: [ stream close ].
        ^ result

This has to wait for a Zn update.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Blockedon: pharo:6658

Comment #1 on issue 6650 by [hidden email]: RBInternalSpellChecker  
not using 2.0 API
http://code.google.com/p/pharo/issues/detail?id=6650

part of this refactoring will be done in

https://code.google.com/p/pharo/issues/detail?id=6658

so the only thing left is the Zn update


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #2 on issue 6650 by [hidden email]: RBInternalSpellChecker  
not using 2.0 API
http://code.google.com/p/pharo/issues/detail?id=6650

RB spellchecker makes no sense, there are *far* too much false positives.

We should just remove it.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: HumanReviewNeeded

Comment #3 on issue 6650 by [hidden email]: RBInternalSpellChecker  
not using 2.0 API
http://code.google.com/p/pharo/issues/detail?id=6650

Name:  
SLICE-Issue-6650-RBInternalSpellChecker-not-using-20-API-SvenVanCaekenberghe.1
Author: SvenVanCaekenberghe
Time: 26 September 2012, 5:39:10.835 pm
UUID: c2236e38-8008-4f03-b460-86dda13bd1f7
Ancestors:
Dependencies: Refactoring-Spelling-SvenVanCaekenberghe.34

port to use ZnClient and FileSystem


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 6650 by [hidden email]: RBInternalSpellChecker  
not using 2.0 API
http://code.google.com/p/pharo/issues/detail?id=6650

@marcus: even if we don't like this class, it is in the image and it uses  
the wrong API, this ifx cleans it and gets us closer to removing  
HTTP[Socket|Client]


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #5 on issue 6650 by [hidden email]: RBInternalSpellChecker  
not using 2.0 API
http://code.google.com/p/pharo/issues/detail?id=6650

New version with bugfix (tested against #20308

Name:  
SLICE-Issue-6650-RBInternalSpellChecker-not-using-20-API-SvenVanCaekenberghe.2
Author: SvenVanCaekenberghe
Time: 26 September 2012, 10:12:40.161 pm
UUID: 6a24a407-d65e-4a2c-b90d-5d23d33a9992
Ancestors:  
SLICE-Issue-6650-RBInternalSpellChecker-not-using-20-API-SvenVanCaekenberghe.1
Dependencies: Refactoring-Spelling-SvenVanCaekenberghe.35

Bugfix to RBInternalSpellChecker>>#downloadData (#beOneShot and streaming  
#downloadTo: do not mix)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #6 on issue 6650 by [hidden email]: RBInternalSpellChecker  
not using 2.0 API
http://code.google.com/p/pharo/issues/detail?id=6650#c6

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20308

Comment #7 on issue 6650 by [hidden email]: RBInternalSpellChecker  
not using 2.0 API
http://code.google.com/p/pharo/issues/detail?id=6650#c7

This Issue has been checked by Ulysse the Monkey
       
6356 tests passed in 00:01:41s:
===============================
        CollectionsTests-Arrayed (553)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (912)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (604)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1954)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        KernelTests-Chronology (582)
        KernelTests-Classes (68)
        KernelTests-Exception (2)
        KernelTests-Methods (179)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (31)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6650-RBInternalSpellChecker-not-using-20-API-SvenVanCaekenberghe.2  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20308-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.164 uuid:  
d77dee73-00f5-4d00-847b-00646b08329d Sep 26 2012
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.164 uuid:  
d77dee73-00f5-4d00-847b-00646b08329d Sep 26 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
bfc9fe2c4abcd2972c8bd9eac1c77f9baaf23e8a Date: 2012-09-25 13:34:47 +0200  
By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #8 on issue 6650 by [hidden email]: RBInternalSpellChecker  
not using 2.0 API
http://code.google.com/p/pharo/issues/detail?id=6650

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated
        Blockedon: -pharo:6658

Comment #9 on issue 6650 by [hidden email]: RBInternalSpellChecker  
not using 2.0 API
http://code.google.com/p/pharo/issues/detail?id=6650

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker