Issue 6675 in pharo: ZnNetworkUtils is not using proxy exceptions.

Status: Accepted
Owner: [hidden email]
CC: [hidden email],  [hidden email]
Labels: Milestone-2.0 Type-Bug

New issue 6675 by [hidden email]: ZnNetworkUtils is not using proxy  
exceptions.
http://code.google.com/p/pharo/issues/detail?id=6675

#ZnNetworkingUtils
>> shouldProxyUrl: url
        "Even when a proxy is set, some URLs should not be proxied.
        There is no setting for this in the image.
        We exclude localhost access from being proxied."
       
        ^ self isProxySet and: [ url isLocalHost not ]


It just look if the url is localhost. It must query NetworkSystemSettings  
for exceptions.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #1 on issue 6675 by [hidden email]: ZnNetworkUtils is not  
using proxy exceptions.
http://code.google.com/p/pharo/issues/detail?id=6675

I added #NetworkSystemSettings >> isAnExceptionFor: anUrl; called from  
#ZnNetworkingUtils >> shouldProxyUrl: url

in the slice:
Time: 17 September 2012, 12:09:20.824 am
UUID: 28c44607-1493-4264-9433-bdd0f9de7f69


Tomorrow i'll make an exaustive test in a real proxied environment.






_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #2 on issue 6675 by [hidden email]: ZnNetworkUtils is not  
using proxy exceptions.
http://code.google.com/p/pharo/issues/detail?id=6675#c2

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 6675 by [hidden email]: ZnNetworkUtils is not  
using proxy exceptions.
http://code.google.com/p/pharo/issues/detail?id=6675

Yeah, I thought about that as well, with the cleaned up settings code, this  
is cool. Thx.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: HumanReviewNeeded

Comment #4 on issue 6675 by [hidden email]: ZnNetworkUtils is not  
using proxy exceptions.
http://code.google.com/p/pharo/issues/detail?id=6675

should this be added?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 6675 by [hidden email]: ZnNetworkUtils is not  
using proxy exceptions.
http://code.google.com/p/pharo/issues/detail?id=6675

I just reviewed the code.

As far as I understood, the idea of the HTTP proxy exceptions is to also  
allow patterns, like *.internal.foo.com

There is no need to add #isAnExceptionFor: because there is already  
#isHttpProxyException: which is a better name and does the match:-ing.

The Zn code then becomes:

ZnNetworkingUtils>>#shouldProxyUrl: url
        ^ self isProxySet and: [ (url isLocalHost or: [ NetworkSystemSettings  
isHttpProxyException: url host ]) not ]

And yes this has to be tested in the real setup.






_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #6 on issue 6675 by [hidden email]: ZnNetworkUtils is not  
using proxy exceptions.
http://code.google.com/p/pharo/issues/detail?id=6675

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 6675 by [hidden email]: ZnNetworkUtils is not  
using proxy exceptions.
http://code.google.com/p/pharo/issues/detail?id=6675

@Santiago, did you check this at your site ?

I can take over the code from here, but you have to validate it first.

Sven


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 6675 by [hidden email]: ZnNetworkUtils is not  
using proxy exceptions.
http://code.google.com/p/pharo/issues/detail?id=6675

Issue 6663 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #9 on issue 6675 by [hidden email]: ZnNetworkUtils is not  
using proxy exceptions.
http://code.google.com/p/pharo/issues/detail?id=6675

I already tested it (i said it in the 6663 issue, i dont realized to say it  
here), and it looks to work.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #10 on issue 6675 by [hidden email]: ZnNetworkUtils is not  
using proxy exceptions.
http://code.google.com/p/pharo/issues/detail?id=6675#c10

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #11 on issue 6675 by [hidden email]: ZnNetworkUtils is not  
using proxy exceptions.
http://code.google.com/p/pharo/issues/detail?id=6675#c11

Monkey went bananas:
--------------------
Error while loading  
SLICE-Issue-6675-ZnNetworkUtils-is-not-using-proxy-exception-SantiagoBragagnolo.1  
from http://ss3.gemstone.com/ss/PharoInbox:
        MessageNotUnderstood: GoferResolvedReference>>merge
  1: GoferResolvedReference(Object)>>doesNotUnderstand: #merge
  2: [self slice merge] in UlysseTheMonkey>>loadSlice
  3: BlockClosure>>on:do:
  4: UlysseTheMonkey>>loadSlice
  5: [self loadSlice] in UlysseTheMonkey>>loadAndTestSlice
  6: [loadStopwatch reset activate.
                aBlock value.
                loadStopwatch suspend.
                testResult := self runTests.
                self removeFalseErrors] in UlysseTheMonkey>>testChangeImpact:
  7: BlockClosure>>on:do:
  8: UlysseTheMonkey>>testChangeImpact:
  9: UlysseTheMonkey>>loadAndTestSlice
10: UlysseTheMonkey>>loadAndTest
        ...
----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6675-ZnNetworkUtils-is-not-using-proxy-exception-SantiagoBragagnolo.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20374-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.164 uuid:  
d77dee73-00f5-4d00-847b-00646b08329d Oct 26 2012
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.164 uuid:  
d77dee73-00f5-4d00-847b-00646b08329d Oct 26 2012
git://gitorious.org/cogvm/blessed.git Commit:  
48af8595004fd0ec3a3ac6d44c3d7516a87981ca Date: 2012-10-24 16:56:20 +0200  
By: Igor Stasenko <[hidden email]> Jenkins build #131


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: HumanReviewNeeded

Comment #12 on issue 6675 by [hidden email]: ZnNetworkUtils is not  
using proxy exceptions.
http://code.google.com/p/pharo/issues/detail?id=6675

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Accepted

Comment #13 on issue 6675 by [hidden email]: ZnNetworkUtils is not  
using proxy exceptions.
http://code.google.com/p/pharo/issues/detail?id=6675

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #14 on issue 6675 by [hidden email]: ZnNetworkUtils is not  
using proxy exceptions.
http://code.google.com/p/pharo/issues/detail?id=6675

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #15 on issue 6675 by [hidden email]: ZnNetworkUtils is not  
using proxy exceptions.
http://code.google.com/p/pharo/issues/detail?id=6675#c15

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #16 on issue 6675 by [hidden email]: ZnNetworkUtils is not  
using proxy exceptions.
http://code.google.com/p/pharo/issues/detail?id=6675

OK, i commited a reviewed version (i found a bug), in any case i need a way  
to commit just the changes, instead of the whole Zink package, cause the  
image behaves bad when you try to re-compile all the system used to get the  
same package.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: HumanReviewNeeded

Comment #17 on issue 6675 by [hidden email]: ZnNetworkUtils is not  
using proxy exceptions.
http://code.google.com/p/pharo/issues/detail?id=6675

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #18 on issue 6675 by [hidden email]: ZnNetworkUtils is not  
using proxy exceptions.
http://code.google.com/p/pharo/issues/detail?id=6675

OK I merged the second version.
Let me know if this is the good one.
In 20381 :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #19 on issue 6675 by [hidden email]: ZnNetworkUtils is not  
using proxy exceptions.
http://code.google.com/p/pharo/issues/detail?id=6675

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker