Issue 6704 in pharo: Debugger looks for a context at index 0

Status: Accepted
Owner: [hidden email]
Labels: Type-Bug Milestone-2.0

New issue 6704 by [hidden email]: Debugger looks for a context  
at index 0
http://code.google.com/p/pharo/issues/detail?id=6704

Debugger>>selectedContext

        ((contextStackIndex = 0) or: [contextStack isEmpty])
                ifTrue: [ ^ contextStackTop ].
       
        (contextStackIndex > contextStack size)
                ifTrue: [ ^ contextStack at: 0].
               
        ^contextStack at: contextStackIndex


"at: 0" looks bad! Shouldn't it be "at: 1" or #first  :/?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #1 on issue 6704 by [hidden email]: Debugger looks for a  
context at index 0
http://code.google.com/p/pharo/issues/detail?id=6704

yes, 1.

But the whole stuff is very crapy... contextStackIndex is used as an index  
of contextStack but it can be 0...

For now: just put first there.

Name:  
SLICE-Issue-6704-Debugger-looks-for-a-context-at-index-0-MarcusDenker.1
Author: MarcusDenker
Time: 24 September 2012, 2:37:10.317 pm
UUID: 2190b770-c3c4-46e8-b487-66a816f1f096
Ancestors:
Dependencies: Tools-MarcusDenker.927

Issue 6704: Debugger looks for a context at index 0


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #2 on issue 6704 by [hidden email]: Debugger looks for a  
context at index 0
http://code.google.com/p/pharo/issues/detail?id=6704#c2

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20303

Comment #3 on issue 6704 by [hidden email]: Debugger looks for a  
context at index 0
http://code.google.com/p/pharo/issues/detail?id=6704#c3

This Issue has been checked by Ulysse the Monkey
       
6384 tests passed in 00:02:59s:
===============================
        CollectionsTests-Arrayed (553)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (912)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (602)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1954)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        KernelTests-Chronology (582)
        KernelTests-Classes (68)
        KernelTests-Exception (2)
        KernelTests-Methods (179)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (31)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)
        ToolsTest-Base (2)
        ToolsTest-Debugger (10)
        ToolsTest-Finder (9)
        ToolsTest-Inspector (1)
        ToolsTest-MessageTally (5)
        ToolsTest-PointerFinder (3)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6704-Debugger-looks-for-a-context-at-index-0-MarcusDenker.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20303-a on CoInterpreter  
VMMaker-oscog-IgorStasenko.162 uuid: e4554f9a-cc90-4826-a807-ac282b782fe4  
Sep 21 2012
StackToRegisterMappingCogit VMMaker-oscog-IgorStasenko.162 uuid:  
e4554f9a-cc90-4826-a807-ac282b782fe4 Sep 21 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
2bb83f5f8aba323abaa0a2f530cf4322dfef8158 Date: 2012-09-18 13:24:46 +0200  
By: Igor Stasenko <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #4 on issue 6704 by [hidden email]: Debugger looks for a  
context at index 0
http://code.google.com/p/pharo/issues/detail?id=6704

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #5 on issue 6704 by [hidden email]: Debugger looks for a  
context at index 0
http://code.google.com/p/pharo/issues/detail?id=6704

in 2.0 304


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker