Issue 6718 in pharo: broken symlink call to start script / missing parameter call

Status: New
Owner: ----
Labels: Milestone-1.4 Type-Bug Milestone-2.0 Target-Filesystem  
Difficulty-Easy

New issue 6718 by [hidden email]: broken symlink call to start  
script / missing parameter call
http://code.google.com/p/pharo/issues/detail?id=6718


Pharo image: Pharo-1.4-one-click
Pharo core version: Pharo1.4 Latest update: #14457
Virtual machine used: pharo one click linux vm

Steps to reproduce:
1. create symlink to start script:
ln -s ~/.local/opt/Pharo-1.4-one-click.app/Pharo-1.4-one-click.sh pharo

pharo ->  
/home/kurella/.local/opt/Pharo-1.4-one-click.app/Pharo-1.4-one-click.sh

2. call pharo without parameter:
3. wrong image location is searched, pharo cannot start as path to sources  
is wrong

2. call pharo with image file as parameter
3. image is not called, rest see above




Paste or attach stack trace if applicable (look at the file PharoDebug.log
located in the same directory as your image):



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 6718 by [hidden email]: broken symlink call to  
start script / missing parameter call
http://code.google.com/p/pharo/issues/detail?id=6718

The fix is rather easy: Do the symlink interpretation first and pass any  
given parameter to the actual call:

Attachments:
        Pharo-1.4-one-click.sh  876 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 6718 by [hidden email]: broken symlink call to  
start script / missing parameter call
http://code.google.com/p/pharo/issues/detail?id=6718

One could easily enhance this by checking if the last parameter is an  
*.image file and still pass to the autoselection if not


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: HumanReviewNeeded

Comment #3 on issue 6718 by [hidden email]: broken symlink call to  
start script / missing parameter call
http://code.google.com/p/pharo/issues/detail?id=6718

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 6718 by [hidden email]: broken symlink call to  
start script / missing parameter call
http://code.google.com/p/pharo/issues/detail?id=6718

This is because the script itself is broken. It first calls dirname and  
then readlink, it should be the other way round.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 6718 by [hidden email]: broken symlink call to  
start script / missing parameter call
http://code.google.com/p/pharo/issues/detail?id=6718

Issue 6813 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 6718 by [hidden email]: broken symlink call to  
start script / missing parameter call
http://code.google.com/p/pharo/issues/detail?id=6718

This is relavant fo rboth 1.4 and 2.0


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #7 on issue 6718 by [hidden email]: broken symlink call to  
start script / missing parameter call
http://code.google.com/p/pharo/issues/detail?id=6718

Will be in Jenkins builds starting #390 (of 2.0) and #463 (1.4)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker