Issue 6720 in pharo: Improve Trait usage in Tools

Status: Accepted
Owner: ----
Labels: Milestone-2.0 Type-Feature Target-Trait

New issue 6720 by [hidden email]: Improve Trait usage in Tools
http://code.google.com/p/pharo/issues/detail?id=6720

- don't show traits in implementors/senders
- warn the user when you compile a trait method, choose to
     - override the trait method
     - compile in the trait
- properly indicate trait methods in Nautilus


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #1 on issue 6720 by [hidden email]: Improve Trait usage in  
Tools
http://code.google.com/p/pharo/issues/detail?id=6720

Name: SLICE-Issue-6720-Improve-Trait-usage-in-Tools--CamilloBruni.1
Author: CamilloBruni
Time: 22 September 2012, 9:50:15.549 pm
UUID: b72d881a-1af6-44c6-a184-594523356ad8
Ancestors:
Dependencies: UIManager-CamilloBruni.77, Kernel-CamilloBruni.1203,  
Nautilus-CamilloBruni.355, Ring-Core-Kernel-CamilloBruni.74,  
Tools-CamilloBruni.928, Ring-Tests-Kernel-CamilloBruni.32,  
NautilusCommon-CamilloBruni.91, RPackage-Core-CamilloBruni.187

- added basic isFromTrait implementation on RGMethodDefinition
- warn user when overriding trait methods
- don't show trait methods in implementors/senders
- clicking the Trait item in Nautilus directly jumps to the method not just  
the trait


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Issue 6720: Improve Trait usage in Tools
http://code.google.com/p/pharo/issues/detail?id=6720

This issue is now blocking issue pharo:6618.
See http://code.google.com/p/pharo/issues/detail?id=6618

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #3 on issue 6720 by [hidden email]: Improve Trait usage in  
Tools
http://code.google.com/p/pharo/issues/detail?id=6720#c3

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #4 on issue 6720 by marianopeck: Improve Trait usage in Tools
http://code.google.com/p/pharo/issues/detail?id=6720

Cami, I don't agree with the change of NOT showing the trait in the  
implementors/senders. This way, when watching implementors, you won't see  
the trait and you would directly modify the methods of classes. That will  
generate a different CompiledMethod than the trait.... So when using Trait  
someone needs to always modify in the Traits, not the users.

I also agree we should also display the classes in the impl/senders that  
uses the trait. Of course, what I would love is that impl/senders tells me  
when a method comes from a trait.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #5 on issue 6720 by [hidden email]: Improve Trait usage in  
Tools
http://code.google.com/p/pharo/issues/detail?id=6720

I discusse that with mister trait damien cassou :). Included Trait methods  
don't belong in implementors / senders, the same way methods from  
superclasses are not shown there. What you want to see is the methods in  
the Trait-class itself.

So basically you only want to show the real definition, otherwise you end  
up exactly with the mess we have currently. You refactor a method, which  
actually came from a trait, and add it as a copy instead of changing the  
Trait.

- I show the methods of the Traits
- I don't show the compiled-in methods of Traits (e.g. users)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #6 on issue 6720 by [hidden email]: Improve Trait usage in  
Tools
http://code.google.com/p/pharo/issues/detail?id=6720#c6

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #7 on issue 6720 by [hidden email]: Improve Trait usage in  
Tools
http://code.google.com/p/pharo/issues/detail?id=6720

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #8 on issue 6720 by [hidden email]: Improve Trait usage in  
Tools
http://code.google.com/p/pharo/issues/detail?id=6720#c8

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: HumanReviewNeeded

Comment #9 on issue 6720 by [hidden email]: Improve Trait usage in  
Tools
http://code.google.com/p/pharo/issues/detail?id=6720

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #10 on issue 6720 by [hidden email]: Improve Trait usage in  
Tools
http://code.google.com/p/pharo/issues/detail?id=6720

in 2.0 314


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker