Issue 6725 in pharo: Character Conversion Cleanup

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
24 messages Options
12
Reply | Threaded
Open this post in threaded view
|

Issue 6725 in pharo: Character Conversion Cleanup

pharo
Status: Accepted
Owner: ----
Labels: Milestone-2.0 Type-Feature

New issue 6725 by [hidden email]: Character Conversion Cleanup
http://code.google.com/p/pharo/issues/detail?id=6725

Split of issue 4725: Clean a bit the Character conversion
- remove code duplication
- simplify methods


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6725 in pharo: Character Conversion Cleanup

pharo
Issue 6725: Character Conversion Cleanup
http://code.google.com/p/pharo/issues/detail?id=6725

This issue is now blocking issue pharo:4725.
See http://code.google.com/p/pharo/issues/detail?id=4725

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6725 in pharo: Character Conversion Cleanup

pharo
In reply to this post by pharo

Comment #2 on issue 6725 by [hidden email]: Character Conversion  
Cleanup
http://code.google.com/p/pharo/issues/detail?id=6725

Name: SLICE-Issue-6725-Character-Conversion-Cleanup-CamilloBruni.1
Author: CamilloBruni
Time: 23 September 2012, 11:44:51.914 pm
UUID: b889eeb8-7bdf-4358-9597-1159fa45c692
Ancestors:
Dependencies: Kernel-CamilloBruni.1204,  
Multilingual-Encodings-CamilloBruni.32, Collections-Strings-CamilloBruni.229

- use Unicode to convert characters case
- changed Unicode conversion protocol
- updated WideString / WideCharacter to use new conversion protocol
- cleanup some methods on character


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6725 in pharo: Character Conversion Cleanup

pharo
Updates:
        Status: FixReviewNeeded

Comment #3 on issue 6725 by [hidden email]: Character Conversion  
Cleanup
http://code.google.com/p/pharo/issues/detail?id=6725

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6725 in pharo: Character Conversion Cleanup

pharo
Updates:
        Status: MonkeyIsChecking

Comment #4 on issue 6725 by [hidden email]: Character Conversion  
Cleanup
http://code.google.com/p/pharo/issues/detail?id=6725#c4

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6725 in pharo: Character Conversion Cleanup

pharo
Updates:
        Status: FailingTest

Comment #5 on issue 6725 by [hidden email]: Character Conversion  
Cleanup
http://code.google.com/p/pharo/issues/detail?id=6725#c5

Test Results:
-------------
Passed: 7563
        CollectionsTests-Arrayed (547)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (906)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (595)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1951)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        KernelTests-Chronology (1166)
        KernelTests-Classes (136)
        KernelTests-Exception (5)
        KernelTests-Methods (359)
        KernelTests-Numbers (552)
        KernelTests-Objects (172)
        KernelTests-Pragmas (6)
        KernelTests-Processes (62)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)

Errors: 1
        SymbolTest>>#testNumArgs2


----------------------------------------------------------
Loaded Source: SLICE-Issue-6725-Character-Conversion-Cleanup-CamilloBruni.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20301-a on CoInterpreter  
VMMaker-oscog-IgorStasenko.162 uuid: e4554f9a-cc90-4826-a807-ac282b782fe4  
Sep 21 2012
StackToRegisterMappingCogit VMMaker-oscog-IgorStasenko.162 uuid:  
e4554f9a-cc90-4826-a807-ac282b782fe4 Sep 21 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
2bb83f5f8aba323abaa0a2f530cf4322dfef8158 Date: 2012-09-18 13:24:46 +0200  
By: Igor Stasenko <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6725 in pharo: Character Conversion Cleanup

pharo
Updates:
        Status: HumanReviewNeeded

Comment #6 on issue 6725 by [hidden email]: Character Conversion  
Cleanup
http://code.google.com/p/pharo/issues/detail?id=6725

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6725 in pharo: Character Conversion Cleanup

pharo

Comment #7 on issue 6725 by [hidden email]: Character Conversion Cleanup
http://code.google.com/p/pharo/issues/detail?id=6725

numArgs: need to follow the old strategy of creating a string and then  
converting to symbol.

Alternatively, numArgs: and its sender (defaultSelector) should be removed,  
seems like a leftover from when DoIt's were installed in a class' method  
dictionary...
Or is there still a valid case where a method with nil selector can be  
found?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6725 in pharo: Character Conversion Cleanup

pharo
Updates:
        Status: WorkNeeded

Comment #8 on issue 6725 by [hidden email]: Character Conversion Cleanup
http://code.google.com/p/pharo/issues/detail?id=6725

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6725 in pharo: Character Conversion Cleanup

pharo
Updates:
        Status: FixReviewNeeded

Comment #9 on issue 6725 by [hidden email]: Character Conversion  
Cleanup
http://code.google.com/p/pharo/issues/detail?id=6725

I cannot reproduce the failure on my machine, most probably due to  
dependencies of other issues..


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6725 in pharo: Character Conversion Cleanup

pharo
Updates:
        Status: MonkeyIsChecking

Comment #10 on issue 6725 by [hidden email]: Character Conversion  
Cleanup
http://code.google.com/p/pharo/issues/detail?id=6725#c10

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6725 in pharo: Character Conversion Cleanup

pharo
Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20306

Comment #11 on issue 6725 by [hidden email]: Character Conversion  
Cleanup
http://code.google.com/p/pharo/issues/detail?id=6725#c11

This Issue has been checked by Ulysse the Monkey
       
7585 tests passed in 00:04:41s:
===============================
        CollectionsTests-Arrayed (553)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (912)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (602)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1954)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        KernelTests-Chronology (1166)
        KernelTests-Classes (136)
        KernelTests-Exception (5)
        KernelTests-Methods (359)
        KernelTests-Numbers (552)
        KernelTests-Objects (172)
        KernelTests-Pragmas (6)
        KernelTests-Processes (62)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)

----------------------------------------------------------
Loaded Source: SLICE-Issue-6725-Character-Conversion-Cleanup-CamilloBruni.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20306-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.164 uuid:  
d77dee73-00f5-4d00-847b-00646b08329d Sep 25 2012
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.164 uuid:  
d77dee73-00f5-4d00-847b-00646b08329d Sep 25 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
bfc9fe2c4abcd2972c8bd9eac1c77f9baaf23e8a Date: 2012-09-25 13:34:47 +0200  
By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6725 in pharo: Character Conversion Cleanup

pharo
Updates:
        Status: FixToInclude

Comment #12 on issue 6725 by [hidden email]: Character Conversion  
Cleanup
http://code.google.com/p/pharo/issues/detail?id=6725

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6725 in pharo: Character Conversion Cleanup

pharo
Updates:
        Status: Integrated

Comment #13 on issue 6725 by [hidden email]: Character Conversion  
Cleanup
http://code.google.com/p/pharo/issues/detail?id=6725

in 2.0 307


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6725 in pharo: Character Conversion Cleanup

pharo
Updates:
        Status: WorkNeeded

Comment #14 on issue 6725 by [hidden email]: Character Conversion  
Cleanup
http://code.google.com/p/pharo/issues/detail?id=6725

Something calls #withOutTrailingBlanks which is deprecated?

Whatever, I can't make an update after loading this (debugger is broken,  
too)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6725 in pharo: Character Conversion Cleanup

pharo

Comment #15 on issue 6725 by [hidden email]: Character Conversion  
Cleanup
http://code.google.com/p/pharo/issues/detail?id=6725

checkin...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6725 in pharo: Character Conversion Cleanup

pharo
Updates:
        Blockedon: pharo:6724

Comment #16 on issue 6725 by [hidden email]: Character Conversion  
Cleanup
http://code.google.com/p/pharo/issues/detail?id=6725

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6725 in pharo: Character Conversion Cleanup

pharo

Comment #17 on issue 6725 by [hidden email]: Character Conversion  
Cleanup
http://code.google.com/p/pharo/issues/detail?id=6725

replace #withOutTrailingBlanks with #trimRight.

which makes me think that we maybe should keep both, since this implies  
left-to-right writing :P


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6725 in pharo: Character Conversion Cleanup

pharo

Comment #18 on issue 6725 by [hidden email]: Character Conversion Cleanup
http://code.google.com/p/pharo/issues/detail?id=6725

trimStart/trimEnd perhaps?
Direction of characters in a string is constant regardless of how it is  
being written/edited (not that THAT is going to be supported anytime  
soon..), but I guess the correctness of using left and right depends on the  
mental model :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6725 in pharo: Character Conversion Cleanup

pharo
Updates:
        Status: FixReviewNeeded

Comment #19 on issue 6725 by [hidden email]: Character Conversion  
Cleanup
http://code.google.com/p/pharo/issues/detail?id=6725

well for now we simply don't care :P since pharo is still struggling with  
other issues than multidirection string displaying :), but trimStart/End  
seems to be a better choice...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
12