Issue 6734 in pharo: Adding some morph navigation through keymappings

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
22 messages Options
12
Reply | Threaded
Open this post in threaded view
|

Issue 6734 in pharo: Adding some morph navigation through keymappings

pharo
Status: Accepted
Owner: [hidden email]
Labels: Type-Enh Milestone-2.0

New issue 6734 by [hidden email]: Adding some morph navigation  
through keymappings
http://code.google.com/p/pharo/issues/detail?id=6734

Setting morph navigation with arrows, pageup, pagedown and tabs via  
keymappings.

Extracted from issue 6656


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6734 in pharo: Adding some morph navigation through keymappings

pharo
Updates:
        Status: FixReviewNeeded
        Cc: [hidden email]
        Blockedon: pharo:6730

Comment #1 on issue 6734 by [hidden email]: Adding some morph  
navigation through keymappings
http://code.google.com/p/pharo/issues/detail?id=6734

Looks good in general, but:

- tab does navigate on the other wise as expected in some morphs...
- ctrl tab does not work (I'm it is a vm problem so it's no problem :P)



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6734 in pharo: Adding some morph navigation through keymappings

pharo

Comment #2 on issue 6734 by [hidden email]: Adding some morph  
navigation through keymappings
http://code.google.com/p/pharo/issues/detail?id=6734

I made it depend on 6730 with some other enhancements I made :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6734 in pharo: Adding some morph navigation through keymappings

pharo
Updates:
        Status: MonkeyIsChecking

Comment #3 on issue 6734 by [hidden email]: Adding some morph  
navigation through keymappings
http://code.google.com/p/pharo/issues/detail?id=6734#c3

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6734 in pharo: Adding some morph navigation through keymappings

pharo

Comment #4 on issue 6734 by [hidden email]: Adding some morph  
navigation through keymappings
http://code.google.com/p/pharo/issues/detail?id=6734

I'll try with a fresh image. Under Linux, it's Shift-tab (and  
shift-ctrl-tab) which isn't generated :-(.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6734 in pharo: Adding some morph navigation through keymappings

pharo

Comment #5 on issue 6734 by [hidden email]: Adding some morph  
navigation through keymappings
http://code.google.com/p/pharo/issues/detail?id=6734

Ouch. Loading 6734 alone is "interesting".


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6734 in pharo: Adding some morph navigation through keymappings

pharo
Updates:
        Status: FixReviewNeeded

Comment #6 on issue 6734 by [hidden email]: Adding some morph  
navigation through keymappings
http://code.google.com/p/pharo/issues/detail?id=6734

Monkey, you're not blocked any more.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6734 in pharo: Adding some morph navigation through keymappings

pharo
Updates:
        Status: MonkeyIsChecking

Comment #7 on issue 6734 by [hidden email]: Adding some morph  
navigation through keymappings
http://code.google.com/p/pharo/issues/detail?id=6734#c7

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6734 in pharo: Adding some morph navigation through keymappings

pharo

Comment #8 on issue 6734 by [hidden email]: Adding some morph  
navigation through keymappings
http://code.google.com/p/pharo/issues/detail?id=6734

@Thierry, I'd include all but the tab navigation, due to the inverse  
navigation in some morphs.

When a solution for the tab navigation appears, we can look forward for it,  
what do you think?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6734 in pharo: Adding some morph navigation through keymappings

pharo

Comment #9 on issue 6734 by [hidden email]: Adding some morph  
navigation through keymappings
http://code.google.com/p/pharo/issues/detail?id=6734

Inverse navigation : do you mean navigation going backward from what it  
should be ? Or shift-tab being unavaible ?

I'll ask my blind friend his opinion on having only one way navigation (but  
it's certainly better than none, or a not really working one).


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6734 in pharo: Adding some morph navigation through keymappings

pharo

Comment #10 on issue 6734 by [hidden email]: Adding some morph  
navigation through keymappings
http://code.google.com/p/pharo/issues/detail?id=6734

I trust you to merge what's working now :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6734 in pharo: Adding some morph navigation through keymappings

pharo

Comment #11 on issue 6734 by [hidden email]: Adding some morph  
navigation through keymappings
http://code.google.com/p/pharo/issues/detail?id=6734

I mean that the navigation (using tab) goes backwards when you expect it  
forwards, think it's related to the way morphs are added to their parents...

The problem is that it's not consistent. In some morphs it works well, in  
some others it doesn't, so it may be confusing...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6734 in pharo: Adding some morph navigation through keymappings

pharo

Comment #12 on issue 6734 by [hidden email]: Adding some morph  
navigation through keymappings
http://code.google.com/p/pharo/issues/detail?id=6734

I think that's because navigation never worked before that nobody was  
paying attention to the way they were adding morphs :(

What's your opinion on trying to fix that in the applications ?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6734 in pharo: Adding some morph navigation through keymappings

pharo
Updates:
        Status: FixToInclude

Comment #13 on issue 6734 by [hidden email]: Adding some morph  
navigation through keymappings
http://code.google.com/p/pharo/issues/detail?id=6734

ok, you convinced me :P.

Next iteration we improve tools.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6734 in pharo: Adding some morph navigation through keymappings

pharo

Comment #14 on issue 6734 by [hidden email]: Adding some morph  
navigation through keymappings
http://code.google.com/p/pharo/issues/detail?id=6734

Thanks.

I'll probably try to convert a morph at a time as well.

What about the new keymaps we define this way ? Should they go into  
Keymapping-Core or in the Morph or application package ? It's a bit of both  
in the current code.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6734 in pharo: Adding some morph navigation through keymappings

pharo

Comment #15 on issue 6734 by [hidden email]: Adding some morph  
navigation through keymappings
http://code.google.com/p/pharo/issues/detail?id=6734

I think they should go into the application package by now.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6734 in pharo: Adding some morph navigation through keymappings

pharo

Comment #16 on issue 6734 by [hidden email]: Adding some morph  
navigation through keymappings
http://code.google.com/p/pharo/issues/detail?id=6734

Ok, I'll follow that then.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6734 in pharo: Adding some morph navigation through keymappings

pharo
Updates:
        Status: WorkNeeded

Comment #17 on issue 6734 by [hidden email]: Adding some morph  
navigation through keymappings
http://code.google.com/p/pharo/issues/detail?id=6734

So what is the status on this? I hate discussions that end with "I will  
do". So does that mean that this entry needs work? Can be closed?

What is the *next action* for this issue?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6734 in pharo: Adding some morph navigation through keymappings

pharo

Comment #18 on issue 6734 by [hidden email]: Adding some morph  
navigation through keymappings
http://code.google.com/p/pharo/issues/detail?id=6734

For me, the issue status is this:  
http://code.google.com/p/pharo/issues/detail?id=6734#c13.

The rest relates to future issues. Guillermo, is that right ?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6734 in pharo: Adding some morph navigation through keymappings

pharo

Comment #19 on issue 6734 by [hidden email]: Adding some morph  
navigation through keymappings
http://code.google.com/p/pharo/issues/detail?id=6734

The problem right now is that the navigation through morph using tabs is  
broken. This issue solves that by adding navigation using the order in the  
#submorphs composition.

Once installed this slice:
- some morphs navigates forward through tab
- some backwards

(because the submorphs collection should be inverted)

The next action (regarding morphic) is to fix some tools that have their  
submorphs built inverted.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
12