Issue 6739 in pharo: Remove URI client classes concept

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 6739 in pharo: Remove URI client classes concept

pharo
Status: Accepted
Owner: ----
Labels: Milestone-2.0 Type-Feature

New issue 6739 by [hidden email]: Remove URI client classes concept
http://code.google.com/p/pharo/issues/detail?id=6739

Remove the #clientClasses concept from URI because it is not used and its  
implementation is broken.

This also remove the single user of HTTPClient in the image, preparing  
HTTPClient itself for later removal.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6739 in pharo: Remove URI client classes concept

pharo

Comment #1 on issue 6739 by [hidden email]: Remove URI client  
classes concept
http://code.google.com/p/pharo/issues/detail?id=6739

Name:  
SLICE-Issue-6739-Remove-URI-client-classes-concept-SvenVanCaekenberghe.1
Author: SvenVanCaekenberghe
Time: 26 September 2012, 10:46:41.626 am
UUID: 0415e391-fb5e-46b7-bbe4-59d173b840d3
Ancestors:
Dependencies: Network-URI-SvenVanCaekenberghe.40

Remove unused #clientClass from URI and remove broken methods from the  
retrieval protocol;
remove the ClientClasses class variable;
this kills the last user in the image of HTTPClient


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6739 in pharo: Remove URI client classes concept

pharo
Updates:
        Status: FixReviewNeeded

Comment #2 on issue 6739 by [hidden email]: Remove URI client  
classes concept
http://code.google.com/p/pharo/issues/detail?id=6739

I hope the slice is OK, the changes against Network-URI-MarcusDenker.39  
were weird.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6739 in pharo: Remove URI client classes concept

pharo
Updates:
        Status: MonkeyIsChecking

Comment #3 on issue 6739 by [hidden email]: Remove URI client  
classes concept
http://code.google.com/p/pharo/issues/detail?id=6739#c3

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6739 in pharo: Remove URI client classes concept

pharo
Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20307

Comment #4 on issue 6739 by [hidden email]: Remove URI client  
classes concept
http://code.google.com/p/pharo/issues/detail?id=6739#c4

This Issue has been checked by Ulysse the Monkey
       
6357 tests passed in 00:01:39s:
===============================
        CollectionsTests-Arrayed (553)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (912)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (604)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1954)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        KernelTests-Chronology (583)
        KernelTests-Classes (68)
        KernelTests-Exception (2)
        KernelTests-Methods (179)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (31)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6739-Remove-URI-client-classes-concept-SvenVanCaekenberghe.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20307-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.164 uuid:  
d77dee73-00f5-4d00-847b-00646b08329d Sep 25 2012
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.164 uuid:  
d77dee73-00f5-4d00-847b-00646b08329d Sep 25 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
bfc9fe2c4abcd2972c8bd9eac1c77f9baaf23e8a Date: 2012-09-25 13:34:47 +0200  
By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6739 in pharo: Remove URI client classes concept

pharo

Comment #5 on issue 6739 by [hidden email]: Remove URI client  
classes concept
http://code.google.com/p/pharo/issues/detail?id=6739

Here is a changeset, just in case:

Attachments:
        Issue6739.cs  1.1 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6739 in pharo: Remove URI client classes concept

pharo
Updates:
        Status: FixToInclude

Comment #6 on issue 6739 by [hidden email]: Remove URI client  
classes concept
http://code.google.com/p/pharo/issues/detail?id=6739

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6739 in pharo: Remove URI client classes concept

pharo
Updates:
        Status: Integrated

Comment #7 on issue 6739 by [hidden email]: Remove URI client  
classes concept
http://code.google.com/p/pharo/issues/detail?id=6739

in 2.0 308


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker