Issue 6741 in pharo: Replace the whole HttpUrl downloading protocol

Status: Accepted
Owner: ----
Labels: Milestone-2.0 Type-Feature

New issue 6741 by [hidden email]: Replace the whole HttpUrl  
downloading protocol
http://code.google.com/p/pharo/issues/detail?id=6741

All the methods in the HttpUrl downloading protocol are a complete mess,  
even passwords and realms are managed in this class itself !

For non-trivial HTTP client work, ZnClient offers a better interface with  
lots more features.

I propose to only keep #retrieveContents but changing the return type from  
MIMEDocument to String or ByteArray.

This should kill the last user of HTTPSocket in the system, apart from  
HTTPClient which has to go as well.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #1 on issue 6741 by [hidden email]: Replace the whole  
HttpUrl downloading protocol
http://code.google.com/p/pharo/issues/detail?id=6741

Name:  
SLICE-Issue-6741-Replace-the-whole-HttpUrl-downloading-protocol-SvenVanCaekenberghe.1
Author: SvenVanCaekenberghe
Time: 27 September 2012, 11:36:35.67 am
UUID: 686b963c-03f5-4ed5-ac6e-b38a8ba19e36
Ancestors:
Dependencies: NetworkTests-SvenVanCaekenberghe.74,  
Network-Url-SvenVanCaekenberghe.75

remove the whole HttpUrl downloading protocol as well as the instance  
variable realm and class variable Passwords and replace it with a single  
#retrieveContents message that delegates to ZnUrl>>#retrieveContents - this  
does change the return type but it should be an improvement; more complex  
HTTP interaction should be done with ZnClient anyway;
added HttpUrlTest>>#testRetrieveContents


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #2 on issue 6741 by [hidden email]: Replace the whole  
HttpUrl downloading protocol
http://code.google.com/p/pharo/issues/detail?id=6741#c2

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20309

Comment #3 on issue 6741 by [hidden email]: Replace the whole  
HttpUrl downloading protocol
http://code.google.com/p/pharo/issues/detail?id=6741#c3

This Issue has been checked by Ulysse the Monkey
       
6554 tests passed in 00:01:48s:
===============================
        CollectionsTests-Arrayed (553)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (912)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (604)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1954)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        KernelTests-Chronology (583)
        KernelTests-Classes (68)
        KernelTests-Exception (2)
        KernelTests-Methods (179)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (31)
        NetworkTests-Kernel (32)
        NetworkTests-Mail (5)
        NetworkTests-Protocols (3)
        NetworkTests-RFC822 (1)
        NetworkTests-URI (105)
        NetworkTests-UUID (14)
        NetworkTests-Url (37)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6741-Replace-the-whole-HttpUrl-downloading-protocol-SvenVanCaekenberghe.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20309-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.164 uuid:  
d77dee73-00f5-4d00-847b-00646b08329d Sep 26 2012
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.164 uuid:  
d77dee73-00f5-4d00-847b-00646b08329d Sep 26 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
bfc9fe2c4abcd2972c8bd9eac1c77f9baaf23e8a Date: 2012-09-25 13:34:47 +0200  
By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #4 on issue 6741 by [hidden email]: Replace the whole  
HttpUrl downloading protocol
http://code.google.com/p/pharo/issues/detail?id=6741#c4

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20310

Comment #5 on issue 6741 by [hidden email]: Replace the whole  
HttpUrl downloading protocol
http://code.google.com/p/pharo/issues/detail?id=6741#c5

This Issue has been checked by Ulysse the Monkey
       
6554 tests passed in 00:01:46s:
===============================
        CollectionsTests-Arrayed (553)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (912)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (604)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1954)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        KernelTests-Chronology (583)
        KernelTests-Classes (68)
        KernelTests-Exception (2)
        KernelTests-Methods (179)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (31)
        NetworkTests-Kernel (32)
        NetworkTests-Mail (5)
        NetworkTests-Protocols (3)
        NetworkTests-RFC822 (1)
        NetworkTests-URI (105)
        NetworkTests-UUID (14)
        NetworkTests-Url (37)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6741-Replace-the-whole-HttpUrl-downloading-protocol-SvenVanCaekenberghe.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20310-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.164 uuid:  
d77dee73-00f5-4d00-847b-00646b08329d Sep 26 2012
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.164 uuid:  
d77dee73-00f5-4d00-847b-00646b08329d Sep 26 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
bfc9fe2c4abcd2972c8bd9eac1c77f9baaf23e8a Date: 2012-09-25 13:34:47 +0200  
By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #6 on issue 6741 by [hidden email]: Replace the whole  
HttpUrl downloading protocol
http://code.google.com/p/pharo/issues/detail?id=6741#c6

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20311

Comment #7 on issue 6741 by [hidden email]: Replace the whole  
HttpUrl downloading protocol
http://code.google.com/p/pharo/issues/detail?id=6741#c7

This Issue has been checked by Ulysse the Monkey
       
6554 tests passed in 00:01:52s:
===============================
        CollectionsTests-Arrayed (553)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (912)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (604)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1954)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        KernelTests-Chronology (583)
        KernelTests-Classes (68)
        KernelTests-Exception (2)
        KernelTests-Methods (179)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (31)
        NetworkTests-Kernel (32)
        NetworkTests-Mail (5)
        NetworkTests-Protocols (3)
        NetworkTests-RFC822 (1)
        NetworkTests-URI (105)
        NetworkTests-UUID (14)
        NetworkTests-Url (37)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6741-Replace-the-whole-HttpUrl-downloading-protocol-SvenVanCaekenberghe.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20311-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.164 uuid:  
d77dee73-00f5-4d00-847b-00646b08329d Sep 26 2012
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.164 uuid:  
d77dee73-00f5-4d00-847b-00646b08329d Sep 26 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
bfc9fe2c4abcd2972c8bd9eac1c77f9baaf23e8a Date: 2012-09-25 13:34:47 +0200  
By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #8 on issue 6741 by [hidden email]: Replace the whole  
HttpUrl downloading protocol
http://code.google.com/p/pharo/issues/detail?id=6741

in 2.0 312


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker