Status: Accepted
Owner: ---- CC: [hidden email] Labels: Milestone-2.0 Type-Bug New issue 6747 by [hidden email]: Unicode class has wrong CaseMapping http://code.google.com/p/pharo/issues/detail?id=6747 The fix from issue 6725 exposes a bug in the Unicode mapping table when converting Characters. Currently $k asUppercase = $K is wrong, $k asUppercase value == 8490 which is the Kelvin sign. Unicode>>#parseCaseMappingFrom: builds the 2 way mapping by always adding the inverse of the uppercase mapping provided by http://www.unicode.org/Public/UNIDATA/CaseFolding.txt but it should not overwrite existing entries. According to ftp://ftp.unicode.org/Public/3.0-Update/UnicodeData-3.0.0.html the file http://www.unicode.org/Public/UNIDATA/UnicodeData.txt contains explicit lowercase <=> uppercase mappings . _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #1 on issue 6747 by [hidden email]: Unicode class has wrong CaseMapping http://code.google.com/p/pharo/issues/detail?id=6747 This slice just exposes the bug a bit better, no fix provided yet Name: SLICE-Issue-6747-Unicode-class-has-wrong-CaseMapping-CamilloBruni.1 Author: CamilloBruni Time: 28 September 2012, 3:13:13.193 pm UUID: f40adad0-4c09-4847-9db7-4f825d27beb0 Ancestors: Dependencies: CollectionsTests-CamilloBruni.570, Nautilus-CamilloBruni.356, Multilingual-Encodings-CamilloBruni.34 - added basic character conversion tests - fixed caseMapping loading - made nautilus ui selector test more verbose _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: worAccepted Comment #2 on issue 6747 by [hidden email]: Unicode class has wrong CaseMapping http://code.google.com/p/pharo/issues/detail?id=6747 (No comment was entered for this change.) _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: WorkNeeded Comment #3 on issue 6747 by [hidden email]: Unicode class has wrong CaseMapping http://code.google.com/p/pharo/issues/detail?id=6747 (No comment was entered for this change.) _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: FixReviewNeeded Comment #4 on issue 6747 by [hidden email]: Unicode class has wrong CaseMapping http://code.google.com/p/pharo/issues/detail?id=6747 Name: SLICE-Issue-6747-Unicode-class-has-wrong-CaseMapping-CamilloBruni.2 Author: CamilloBruni Time: 28 September 2012, 5:36:47.837 pm UUID: 04ed9cff-5988-4343-afdb-f0eadd1b2c5d Ancestors: SLICE-Issue-6747-Unicode-class-has-wrong-CaseMapping-CamilloBruni.1 Dependencies: CollectionsTests-CamilloBruni.570, Nautilus-CamilloBruni.356, Multilingual-Encodings-CamilloBruni.35 fixing unicode case map table loading, don't override existing entries while loading Attachments: postscript.st 348 bytes _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: MonkeyIsChecking Comment #5 on issue 6747 by [hidden email]: Unicode class has wrong CaseMapping http://code.google.com/p/pharo/issues/detail?id=6747#c5 The Monkey is currently checking this issue. Please don't change it! _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: FailingTest Comment #6 on issue 6747 by [hidden email]: Unicode class has wrong CaseMapping http://code.google.com/p/pharo/issues/detail?id=6747#c6 Test Results: ------------- Passed: 11231 CollectionsTests-Arrayed (1106) CollectionsTests-Atomic (24) CollectionsTests-Sequenceable (1824) CollectionsTests-SplitJoin (54) CollectionsTests-Stack (32) CollectionsTests-Streams (74) CollectionsTests-Strings (1210) CollectionsTests-Support (24) CollectionsTests-Unordered (3908) CollectionsTests-Weak (1478) CompilerTests (179) KernelTests-Chronology (583) KernelTests-Classes (68) KernelTests-Exception (2) KernelTests-Methods (179) KernelTests-Numbers (276) KernelTests-Objects (86) KernelTests-Pragmas (3) KernelTests-Processes (31) Nautilus-Tests (7) SUnit-Core-Extensions (3) SUnit-Core-Utilities (3) SUnit-Tests-Core (77) Failures: 2 CharacterTest>>#testAsUppercaseBasicAsciiRange CharacterTest>>#testAsUppercaseBasicAsciiRange ---------------------------------------------------------- Loaded Source: SLICE-Issue-6747-Unicode-class-has-wrong-CaseMapping-CamilloBruni.2 from http://ss3.gemstone.com/ss/PharoInbox"postscript.st" from Comment #4 Tested using Pharo-2.0-20313-a on CoInterpreter VMMaker-oscog-EstebanLorenzano.164 uuid: d77dee73-00f5-4d00-847b-00646b08329d Sep 26 2012 StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.164 uuid: d77dee73-00f5-4d00-847b-00646b08329d Sep 26 2012 https://git.gitorious.org/cogvm/blessed.git Commit: bfc9fe2c4abcd2972c8bd9eac1c77f9baaf23e8a Date: 2012-09-25 13:34:47 +0200 By: Esteban Lorenzano <[hidden email]> _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: HumanReviewNeeded Comment #7 on issue 6747 by [hidden email]: Unicode class has wrong CaseMapping http://code.google.com/p/pharo/issues/detail?id=6747 (No comment was entered for this change.) _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Cc: [hidden email] Comment #8 on issue 6747 by [hidden email]: Unicode class has wrong CaseMapping http://code.google.com/p/pharo/issues/detail?id=6747 Issue 6743 has been merged into this issue. _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: WorkNeeded Comment #9 on issue 6747 by [hidden email]: Unicode class has wrong CaseMapping http://code.google.com/p/pharo/issues/detail?id=6747 When I merge the slice I see *a lot* of methods changes where source is decompiled (t1 t2...) _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #10 on issue 6747 by [hidden email]: Unicode class has wrong CaseMapping http://code.google.com/p/pharo/issues/detail?id=6747 ok must have broken my image while fixing it :/ _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: HumanReviewNeeded Comment #11 on issue 6747 by [hidden email]: Unicode class has wrong CaseMapping http://code.google.com/p/pharo/issues/detail?id=6747 fixed, don't forget the postscript... Name: SLICE-Issue-6747-Unicode-class-has-wrong-CaseMapping-CamilloBruni.3 Author: CamilloBruni Time: 29 September 2012, 4:27:00.414 pm UUID: 5f289892-4a39-4b83-8fbc-2cd710d6843e Ancestors: Dependencies: CollectionsTests-CamilloBruni.571, Nautilus-CamilloBruni.357, Multilingual-Encodings-CamilloBruni.36 recomittin clean character fix _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: Integrated Comment #12 on issue 6747 by [hidden email]: Unicode class has wrong CaseMapping http://code.google.com/p/pharo/issues/detail?id=6747 in 2.0 315 _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #13 on issue 6747 by [hidden email]: Unicode class has wrong CaseMapping http://code.google.com/p/pharo/issues/detail?id=6747 in 2.0 315 _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Free forum by Nabble | Edit this page |