Issue 6785 in pharo: Do we really need to cache DebuggerMethodMap?

Status: Accepted
Owner: [hidden email]
Labels: Type-Cleanup Milestone-2.0

New issue 6785 by [hidden email]: Do we really need to cache  
DebuggerMethodMap?
http://code.google.com/p/pharo/issues/detail?id=6785

When I remove the cache in DebuggerMethodMap, the debugger does not feel  
much slower...




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #1 on issue 6785 by [hidden email]: Do we really need to  
cache DebuggerMethodMap?
http://code.google.com/p/pharo/issues/detail?id=6785

Name:  
SLICE-Issue-6785-Do-we-really-need-to-cache-DebuggerMethodMap-MarcusDenker.1
Author: MarcusDenker
Time: 9 October 2012, 10:17:49.291 pm
UUID: 474d8b33-ea76-46b3-a37a-4937931806e4
Ancestors:
Dependencies: Kernel-MarcusDenker.1211, CompilerTests-MarcusDenker.124,  
System-Support-MarcusDenker.718

Issue 6785: Do we really need to cache DebuggerMethodMap?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #2 on issue 6785 by [hidden email]: Do we really need to  
cache DebuggerMethodMap?
http://code.google.com/p/pharo/issues/detail?id=6785#c2

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #3 on issue 6785 by [hidden email]: Do we really need to  
cache DebuggerMethodMap?
http://code.google.com/p/pharo/issues/detail?id=6785#c3

Monkey went bananas:
--------------------
Error while loading  
SLICE-Issue-6785-Do-we-really-need-to-cache-DebuggerMethodMap-MarcusDenker.1  
from http://ss3.gemstone.com/ss/PharoInbox:
        UndeclaredVariableWarning: DebuggerMethodMap>>#markRecentlyUsed  
('timestamp' is Undeclared)
  1: EncoderForV3PlusClosures(Encoder)>>undeclared:
  2: Parser>>correctVariable:interval:
  3: [self
                        correctVariable: varName
                        interval: (varStart to: varEnd)] in Parser>>variable
  4: [(self
                                lookupInPools: name
                                ifFound: [:assoc | varNode := self global: assoc name: name])
                        ifTrue: [varNode]
                        ifFalse: [^ action value]] in  
EncoderForV3PlusClosures(Encoder)>>encodeVariable:sourceRange:ifUnknown:
  5: Dictionary>>at:ifAbsent:
  6: EncoderForV3PlusClosures(Encoder)>>encodeVariable:sourceRange:ifUnknown:
  7: Parser>>variable
  8: Parser>>expression
  9: Parser>>statements:innerBlock:blockNode:
10: Parser>>statements:innerBlock:
        ...
----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6785-Do-we-really-need-to-cache-DebuggerMethodMap-MarcusDenker.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20333-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.164 uuid:  
d77dee73-00f5-4d00-847b-00646b08329d Oct  2 2012
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.164 uuid:  
d77dee73-00f5-4d00-847b-00646b08329d Oct  2 2012
git://gitorious.org/cogvm/blessed.git Commit:  
bfc9fe2c4abcd2972c8bd9eac1c77f9baaf23e8a Date: 2012-09-25 13:34:47 +0200  
By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: HumanReviewNeeded

Comment #4 on issue 6785 by [hidden email]: Do we really need to  
cache DebuggerMethodMap?
http://code.google.com/p/pharo/issues/detail?id=6785

Merges fine... bad monkey.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 6785 by [hidden email]: Do we really need to  
cache DebuggerMethodMap?
http://code.google.com/p/pharo/issues/detail?id=6785

Looks ok to me. I don't see any impact on speed either, and having a chache  
for 16 items when our debuggers are far larger does not make much sense (we  
probably have cache miss all the time :P)...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #6 on issue 6785 by [hidden email]: Do we really need to  
cache DebuggerMethodMap?
http://code.google.com/p/pharo/issues/detail?id=6785

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #7 on issue 6785 by [hidden email]: Do we really need to  
cache DebuggerMethodMap?
http://code.google.com/p/pharo/issues/detail?id=6785

in 2.0 345


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker