Issue 6795 in pharo: Tango ST80 Syntax Coloring Scheme

Status: Accepted
Owner: [hidden email]
Labels: Type-Feature Milestone-2.0

New issue 6795 by [hidden email]: Tango ST80 Syntax Coloring Scheme
http://code.google.com/p/pharo/issues/detail?id=6795

The current syntax coloring scheme is very limited in respect to the  
different elements of the source code.
We suggest using a less saturated scheme based on the colors from the tango  
desktop icon theme.
Furthermore we tried to distinguish properly arguments/temps from inst  
vars, classvars and pool variables.

-------------------
Slice is in the inbox


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #1 on issue 6795 by [hidden email]: Tango ST80 Syntax  
Coloring Scheme
http://code.google.com/p/pharo/issues/detail?id=6795#c1

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #2 on issue 6795 by [hidden email]: Tango ST80 Syntax  
Coloring Scheme
http://code.google.com/p/pharo/issues/detail?id=6795#c2

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #3 on issue 6795 by [hidden email]: Tango ST80 Syntax  
Coloring Scheme
http://code.google.com/p/pharo/issues/detail?id=6795

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #4 on issue 6795 by [hidden email]: Tango ST80 Syntax  
Coloring Scheme
http://code.google.com/p/pharo/issues/detail?id=6795#c4

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20337

Comment #5 on issue 6795 by [hidden email]: Tango ST80 Syntax  
Coloring Scheme
http://code.google.com/p/pharo/issues/detail?id=6795#c5

This Issue has been checked by Ulysse the Monkey
       
6372 tests passed in 00:01:52s:
===============================
        CollectionsTests-Arrayed (553)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (912)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (606)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1954)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        KernelTests-Chronology (583)
        KernelTests-Classes (68)
        KernelTests-Exception (2)
        KernelTests-Methods (179)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (37)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)
        ShoutTests-Parsing (5)
        ShoutTests-Styling (2)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6795-Tango-ST80-Syntax-Coloring-Scheme-CamilloBruni.2 from  
http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20337-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.164 uuid:  
d77dee73-00f5-4d00-847b-00646b08329d Oct  2 2012
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.164 uuid:  
d77dee73-00f5-4d00-847b-00646b08329d Oct  2 2012
git://gitorious.org/cogvm/blessed.git Commit:  
bfc9fe2c4abcd2972c8bd9eac1c77f9baaf23e8a Date: 2012-09-25 13:34:47 +0200  
By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 6795 by [hidden email]: Tango ST80 Syntax  
Coloring Scheme
http://code.google.com/p/pharo/issues/detail?id=6795

For those wondering how it might look like.

Attachments:
        Screen Shot 2012-10-13 at 15.10.35.png  63.1 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 6795 by [hidden email]: Tango ST80 Syntax  
Coloring Scheme
http://code.google.com/p/pharo/issues/detail?id=6795

Yummy !

This _is_ important too, thanks for taking care.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #8 on issue 6795 by [hidden email]: Tango ST80 Syntax  
Coloring Scheme
http://code.google.com/p/pharo/issues/detail?id=6795

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #9 on issue 6795 by [hidden email]: Tango ST80 Syntax  
Coloring Scheme
http://code.google.com/p/pharo/issues/detail?id=6795

in 2.0 338


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 6795 by [hidden email]: Tango ST80 Syntax  
Coloring Scheme
http://code.google.com/p/pharo/issues/detail?id=6795

Camillo

What I really regret is that comments are really important and grey is not  
a good color for them.
Personnally I do not see why red would make any sense for a pool. I would  
prefer it for self so that
I see immediately that I'm doing self calls.

Stef


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #11 on issue 6795 by [hidden email]: Tango ST80 Syntax  
Coloring Scheme
http://code.google.com/p/pharo/issues/detail?id=6795

Camillo

What I really regret is that comments are really important and grey is not  
a good color for them.
Personnally I do not see why red would make any sense for a pool. I would  
prefer it for self so that
I see immediately that I'm doing self calls.

Stef


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #12 on issue 6795 by [hidden email]: Tango ST80 Syntax  
Coloring Scheme
http://code.google.com/p/pharo/issues/detail?id=6795

May be dark blue for comments would make it.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #13 on issue 6795 by [hidden email]: Tango ST80 Syntax  
Coloring Scheme
http://code.google.com/p/pharo/issues/detail?id=6795

Maybe we can try to live with it a bit and then come up with changes ?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #14 on issue 6795 by [hidden email]: Tango ST80 Syntax  
Coloring Scheme
http://code.google.com/p/pharo/issues/detail?id=6795

comments are not really that important. I still quote Oscar Nierstrasz  
here ;), saying that you almost never need them. The only real comment you  
need is on the class. If anything then a a slightly darker gray.

But you know you can change that for yourself easily, StartupPreferences +  
Settings...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #15 on issue 6795 by [hidden email]: Tango ST80 Syntax  
Coloring Scheme
http://code.google.com/p/pharo/issues/detail?id=6795

BTW, comments are grey today as well ;-)

I completely subscribe to the idea that beautiful well written code should  
be its own explanation.

But writing a couple of high level sentences explaining what you are/were  
is often very helpfull both to fix your thoughts when you are writing the  
code as well as for yourself and others to understand things afterwards.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker