Issue 6897 in pharo: More user friendly Create Button in Debugger

Status: FixReviewNeeded
Owner: [hidden email]
Labels: Type-Bug Milestone-2.0

New issue 6897 by [hidden email]: More user friendly Create Button  
in Debugger
http://code.google.com/p/pharo/issues/detail?id=6897

allMethodCategoriesIntegratedThrough: mostGenericClass
        "Answer a list of all the method categories of the receiver and all its  
superclasses, up through mostGenericClass"

        | otherClassCategories thisClassCategories combinedClassCategories |
        otherClassCategories := OrderedCollection new.
        self allSuperclasses
                do: [ :aClass |
                        (aClass includesBehavior: mostGenericClass)
                                ifTrue: [ otherClassCategories addAll: aClass organization categories ]  
].
        otherClassCategories remove: 'no messages' asSymbol ifAbsent: [  ].
        thisClassCategories := self organization categories asSortedCollection:  
[ :a :b | a asLowercase < b asLowercase ].
        ^ Array
                streamContents: [ :stream |
                        stream
                                nextPutAll: thisClassCategories;
                                nextPutAll:
                                                ((otherClassCategories asSet removeAllSuchThat: [ :each |  
thisClassCategories includes: each ])
                                                                asSortedCollection: [ :a :b | a asLowercase < b asLowercase ]) ]

Attachments:
        ClassDescription-allMethodCategoriesIntegratedThrough.st  1.1 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 6897 by [hidden email]: More user friendly  
Create Button in Debugger
http://code.google.com/p/pharo/issues/detail?id=6897

Hi-

When I create methods using the Debugger's 'Create' button I am never sure  
which categories are used in the class I'm adding the method to versus  
those in its super classes. In an effort to not have to think about that  
any more I've adapted the  
ClassDescription>>#allMethodCategoriesIntegratedThrough: to put the method  
categories that are used in the target class first, then those in the super  
classes after that.


I think this should work in Pharo and Squeak but I've only tested it in  
Pharo 1.4.  I've attached a changeset and also pasted the method below


Paul


--- Stef: I'm not sure that Paul signed the license agreement.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 6897 by [hidden email]: More user friendly  
Create Button in Debugger
http://code.google.com/p/pharo/issues/detail?id=6897

The FixReviewNeeded will fail because there is no slice attached.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 6897 by [hidden email]: More user friendly  
Create Button in Debugger
http://code.google.com/p/pharo/issues/detail?id=6897

Issue 6896 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #4 on issue 6897 by [hidden email]: More user friendly  
Create Button in Debugger
http://code.google.com/p/pharo/issues/detail?id=6897#c4

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #5 on issue 6897 by [hidden email]: More user friendly  
Create Button in Debugger
http://code.google.com/p/pharo/issues/detail?id=6897#c5

Monkey went bananas:
--------------------
Error while  
loading "ClassDescription-allMethodCategoriesIntegratedThrough.st" from  
Comment #0:
        MessageNotUnderstood: ReadStream>>fileIn
  1: ReadStream(Object)>>doesNotUnderstand: #fileIn
  2: [attachment contents asString readStream fileIn] in [:attachment |  
[attachment contents asString readStream fileIn]
                        on: Error
                        do: [:e |
                                self addError: e forFile: attachment description.
                                self debug: e]] in UlysseTheMonkey>>loadChangeSet
  3: BlockClosure>>on:do:
  4: [:attachment | [attachment contents asString readStream fileIn]
                        on: Error
                        do: [:e |
                                self addError: e forFile: attachment description.
                                self debug: e]] in UlysseTheMonkey>>loadChangeSet
  5: Array(SequenceableCollection)>>do:
  6: UlysseTheMonkey>>loadChangeSet
  7: [self loadChangeSet] in UlysseTheMonkey>>loadAndTestChangeSet
  8: [loadStopwatch reset activate.
                aBlock value.
                loadStopwatch suspend.
                testResult := self runTests.
                self removeFalseErrors] in UlysseTheMonkey>>testChangeImpact:
  9: BlockClosure>>on:do:
10: UlysseTheMonkey>>testChangeImpact:
        ...
----------------------------------------------------------
Loaded Source: "ClassDescription-allMethodCategoriesIntegratedThrough.st"  
from Comment #0
Tested using Pharo-2.0-20372-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.164 uuid:  
d77dee73-00f5-4d00-847b-00646b08329d Oct 26 2012
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.164 uuid:  
d77dee73-00f5-4d00-847b-00646b08329d Oct 26 2012
git://gitorious.org/cogvm/blessed.git Commit:  
48af8595004fd0ec3a3ac6d44c3d7516a87981ca Date: 2012-10-24 16:56:20 +0200  
By: Igor Stasenko <[hidden email]> Jenkins build #131


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 6897 by [hidden email]: More user friendly Create  
Button in Debugger
http://code.google.com/p/pharo/issues/detail?id=6897

Name:  
SLICE-Issue-6897-More-user-friendly-Create-Button-in-Debugger-ClementBara.1
Author: ClementBara
Time: 2 November 2012, 10:40:25.638 am
UUID: 915096c1-eb92-41f2-bf2a-f8a945da623a
Ancestors:
Dependencies: Kernel-ClementBara.1230

see bug description

same solution but written in a more explicit way


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #8 on issue 6897 by [hidden email]: More user friendly  
Create Button in Debugger
http://code.google.com/p/pharo/issues/detail?id=6897

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #9 on issue 6897 by [hidden email]: More user friendly  
Create Button in Debugger
http://code.google.com/p/pharo/issues/detail?id=6897#c9

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20372

Comment #10 on issue 6897 by [hidden email]: More user friendly  
Create Button in Debugger
http://code.google.com/p/pharo/issues/detail?id=6897#c10

This Issue has been checked by Ulysse the Monkey
       
7622 tests passed in 00:04:35s:
===============================
        CollectionsTests-Arrayed (553)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (912)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (606)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1954)
        CollectionsTests-Weak (739)
        CompilerTests (180)
        KernelTests-Chronology (1186)
        KernelTests-Classes (136)
        KernelTests-Exception (5)
        KernelTests-Methods (359)
        KernelTests-Numbers (552)
        KernelTests-Objects (172)
        KernelTests-Pragmas (6)
        KernelTests-Processes (74)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6897-More-user-friendly-Create-Button-in-Debugger-ClementBara.1  
from  
http://ss3.gemstone.com/ss/PharoInbox"ClassDescription-allMethodCategoriesIntegratedThrough.st"  
from Comment #0
Tested using Pharo-2.0-20372-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.164 uuid:  
d77dee73-00f5-4d00-847b-00646b08329d Oct 26 2012
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.164 uuid:  
d77dee73-00f5-4d00-847b-00646b08329d Oct 26 2012
git://gitorious.org/cogvm/blessed.git Commit:  
48af8595004fd0ec3a3ac6d44c3d7516a87981ca Date: 2012-10-24 16:56:20 +0200  
By: Igor Stasenko <[hidden email]> Jenkins build #131


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #11 on issue 6897 by [hidden email]: More user friendly  
Create Button in Debugger
http://code.google.com/p/pharo/issues/detail?id=6897

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #12 on issue 6897 by [hidden email]: More user friendly  
Create Button in Debugger
http://code.google.com/p/pharo/issues/detail?id=6897

in 2.0 373


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #13 on issue 6897 by [hidden email]: More user friendly  
Create Button in Debugger
http://code.google.com/p/pharo/issues/detail?id=6897

Is one able to confirm that Paul signed the license agreement?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #14 on issue 6897 by [hidden email]: More user friendly  
Create Button in Debugger
http://code.google.com/p/pharo/issues/detail?id=6897

Clement rewrote the method completely, so copyright does not apply.

But for further fixes, he should send the agreeement.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker