Issue 6917 in pharo: save as... to an already existing image throws a DNU

Status: Accepted
Owner: ----
Labels: Milestone-2.0 Type-Bug

New issue 6917 by [hidden email]: save as... to an already existing  
image throws a DNU
http://code.google.com/p/pharo/issues/detail?id=6917

if you try to save and overwrite an image, you get a dnu (something about  
changes file)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 6917 by [hidden email]: save as... to an already  
existing image throws a DNU
http://code.google.com/p/pharo/issues/detail?id=6917

Yes an additional data, this happens only the first time, try again if it  
will works.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 6917 by [hidden email]: save as... to an already  
existing image throws a DNU
http://code.google.com/p/pharo/issues/detail?id=6917

Issue 6924 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 6917 by [hidden email]: save as... to an already  
existing image throws a DNU
http://code.google.com/p/pharo/issues/detail?id=6917

Issue 6124 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 6917 by [hidden email]: save as... to an  
already existing image throws a DNU
http://code.google.com/p/pharo/issues/detail?id=6917

Original problem is that the existing changes file could not be overwritten  
with a new changes file. New functionality has been created in  
FileReference to overwrite on copy. This is now called from  
SmalltalkImage>>saveChangesInFileNamed:

(Oscar Callau & Johan Fabry)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: HumanReviewNeeded
        Cc: [hidden email] [hidden email]

Comment #5 on issue 6917 by [hidden email]: save as... to an already  
existing image throws a DNU
http://code.google.com/p/pharo/issues/detail?id=6917

In #20514, I don't get a DNU. I get "FileExists: Path / ...  
/ 'Pharo-20514.changes'"

How about just short-circuiting if the name is the same, and doing a  
regular save?

SLICE-Issue-6917-save-as-to-an-already-existing-image-throws-a-DNU-SeanDeNigris.1
Intercept #saveAs: of image to same file name, and just do a regular save

b.t.w. this area could use a cleaning... e.g. it's passing around strings  
representing files instead of actual files


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 6917 by [hidden email]: save as... to an already  
existing image throws a DNU
http://code.google.com/p/pharo/issues/detail?id=6917

yeah, I guess I only touched half of it, still too messy down there :) =>  
sprint on friday?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 6917 by [hidden email]: save as... to an already  
existing image throws a DNU
http://code.google.com/p/pharo/issues/detail?id=6917

Try it on Windows - it is not possible to save with the same  
filename/override since Pharo laments that the changes file already  
exists....


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 6917 by [hidden email]: save as... to an already  
existing image throws a DNU
http://code.google.com/p/pharo/issues/detail?id=6917

A new slice has been created. Before saving the image, we ensure that the  
destination file is not the same as the source  
(SmalltalkImage>>#saveChangesInFileNamed)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 6917 by [hidden email]: save as... to an already  
existing image throws a DNU
http://code.google.com/p/pharo/issues/detail?id=6917



Name:  
SLICE-Issue-6917-save-as-to-an-already-existing-image-throws-a-DNU-GuillaumeLarcheveque.1
Author: GuillaumeLarcheveque
Time: 8 February 2013, 1:10:21.294 pm
UUID: 6f7d1749-b565-4d89-b0a8-0522da24aa14
Ancestors:
Dependencies: System-Support-GuillaumeLarcheveque.774

if you try to save and overwrite an image, you get a dnu (something about  
changes file)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #10 on issue 6917 by [hidden email]: save as... to an  
already existing image throws a DNU
http://code.google.com/p/pharo/issues/detail?id=6917

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #11 on issue 6917 by [hidden email]: save as... to an  
already existing image throws a DNU
http://code.google.com/p/pharo/issues/detail?id=6917

in 2.0 529


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker