Issue 6996 in pharo: SoundSystem cleanup

Status: Accepted
Owner: [hidden email]
Labels: Type-Bug

New issue 6996 by [hidden email]: SoundSystem cleanup
http://code.google.com/p/pharo/issues/detail?id=6996

Do this Sound subsystem refactorings:
- remove SoundService class
- rename AbstractSoundSystem to SoundSystem
- make SoundSystem registration (SoundSystem current) with DummySoundSystem  
as default
- make a setting SoundSystem soundEnable
- use beep primitive for DummySoundSystem in case that sound is enabled
- use SoundSystem current beep instead of Beeper peep
- remove Beeper class
- add System-Sound (SystemSound, DummpySoundSystem) to Pharo Kernel
- fix Pharo Kernel shrinking


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded
        Labels: Milestone-2.0

Comment #1 on issue 6996 by [hidden email]: SoundSystem cleanup
http://code.google.com/p/pharo/issues/detail?id=6996

SLICE-Issue-6996-SoundSystem-cleanup-PavelKrivanek.1


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 6996 by [hidden email]: SoundSystem cleanup
http://code.google.com/p/pharo/issues/detail?id=6996

Have you tested these with/updated the PharoSound package on squeaksource?
http://www.squeaksource.com/PharoSound

IIRC, it broke with some earlier base-refactorings, would be nice to have a  
non-dummy soundsystem loadable again in 2.0 :D


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 6996 by [hidden email]: SoundSystem cleanup
http://code.google.com/p/pharo/issues/detail?id=6996

I had no clue about it


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 6996 by [hidden email]: SoundSystem cleanup
http://code.google.com/p/pharo/issues/detail?id=6996

AFAICT, it is what Stephane was talking of when stating "I see when we load  
the sound package beep is not using beep primitive but the associated  
sound.", and that registration of default sound system is broken (when  
loaded, it tries to install a non-dummy soundsystem as default)

See f.ex. Issue 5250, I never got any feedback on comment 2 if that was an  
ok way to fix things.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 6996 by [hidden email]: SoundSystem cleanup
http://code.google.com/p/pharo/issues/detail?id=6996

I like the move to Class-based delegation rather than using an AppRegistry,  
though not how it forces users to rewrite from SoundService default xxx to  
SoundSystem current xxx for no additional benefit.

What is potentially missing compared to AppRegistry, is requesting the  
available systems.
Shouldn't be a huge issue, if you load a more capable sound system, you  
usually want that to be installed as the current one anyways, and as far as  
I can tell, it is unlikely one would want to load more than one extra.
(And in that case, autoresolve based on system capabilities rather than  
leave it as a choice for the user)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 6996 by [hidden email]: SoundSystem cleanup
http://code.google.com/p/pharo/issues/detail?id=6996

The main reason why I want AppRegistry out is that it makes problems in  
Pharo Kernel. AppRegistry should be used for registration of applications.  
And such thing makes no sense to in headless images without UI.

In similar cases we simply enumerate subclasses (in this case of  
SoundSystem).


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #7 on issue 6996 by [hidden email]: SoundSystem cleanup
http://code.google.com/p/pharo/issues/detail?id=6996

I think we should move mark it as Milestone-3.0, it doesn't fit our beta  
policy. And open an issue that will remove related Undeclared from Pharo  
Kernel


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: -Milestone-2.0 Milestone-3.0

Comment #8 on issue 6996 by [hidden email]: SoundSystem cleanup
http://code.google.com/p/pharo/issues/detail?id=6996

ok, I put the 3.0


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker