Issue 7016 in pharo: repackage restoreAllNotifications

Status: Accepted
Owner: [hidden email]
Labels: Type-Bug Milestone-2.0

New issue 7016 by [hidden email]: repackage  
restoreAllNotifications
http://code.google.com/p/pharo/issues/detail?id=7016

the method SystemAnnouncer class >> #restoreAllNotifications is dependent  
on PragmaCollector that is not present in Pharo Kernel and it makes  
Undeclared there.

Move it to the package System-PragmaCollector as an extension


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #1 on issue 7016 by [hidden email]: repackage  
restoreAllNotifications
http://code.google.com/p/pharo/issues/detail?id=7016

SLICE-Issue-7016-repackage-restoreAllNotifications--PavelKrivanek.1


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 7016 by [hidden email]: repackage  
restoreAllNotifications
http://code.google.com/p/pharo/issues/detail?id=7016

to me #restoreAllNotifications sounds like very basic functionality...  
maybe PragmaCollector should be moved close to the Pragma class and be part  
of the kernel?



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 7016 by [hidden email]: repackage  
restoreAllNotifications
http://code.google.com/p/pharo/issues/detail?id=7016

Ok, should I create a slice?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 7016 by [hidden email]: repackage  
restoreAllNotifications
http://code.google.com/p/pharo/issues/detail?id=7016

yes!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 7016 by [hidden email]: repackage  
restoreAllNotifications
http://code.google.com/p/pharo/issues/detail?id=7016

SLICE-Issue-7016-repackage-restoreAllNotifications--PavelKrivanek.2

The reason I originally didn't wanted to add PragmaCollector to the Pharo  
Kernel is that there even Pragmas are not present. But it is clear that  
sooner or later it must be there.
I kept the System-PragmaCollector package name so the only thing change is  
that Kernel-Pragmas and System-PragmaCollector are now part of the Pharo  
Kernel. Shrinking goes well.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 7016 by [hidden email]: repackage  
restoreAllNotifications
http://code.google.com/p/pharo/issues/detail?id=7016

Why don't we move the PragmaCollector close to the Pragma class?

Simplify, Simplify! The package structure is far too arcane already.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 7016 by [hidden email]: repackage  
restoreAllNotifications
http://code.google.com/p/pharo/issues/detail?id=7016

SLICE-Issue-7016-repackage-restoreAllNotifications--PavelKrivanek.3

PragmrasCollector moved to Kernel-Pragmras package, category  
Kernel-Pragmas-Collector, old package can be unregistered


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 7016 by [hidden email]: repackage  
restoreAllNotifications
http://code.google.com/p/pharo/issues/detail?id=7016

I think that alain did it like that because you have a structure: Pragmas  
and tools that manipulate them: PragmaCollector.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #9 on issue 7016 by [hidden email]: repackage  
restoreAllNotifications
http://code.google.com/p/pharo/issues/detail?id=7016

in 2.0 416


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker