Issue 7050 in pharo: Critics Browser

Status: Accepted
Owner: [hidden email]
Labels: Type-Bug

New issue 7050 by [hidden email]: Critics Browser
http://code.google.com/p/pharo/issues/detail?id=7050

Could you please fix:

         - CriticBrowser class comment
         - CriticRulesBrowser class comment (especially the example that is  
not working at all)
                 - add the example as an example method on class side
         - Add class comment for all your classes (did you run SmallLint  
rules over your package ?)
         - No one mind this :
Instance Variables
        browseModel: <Object>
        criticHolder: <Object>
        falsepositiveModel: <Object>
        ruleHolder: <Object>
        transformModel: <Object>
       etc.

          Just remove all this useless pieces of information

         + If CriticRulesBrowser is the entry point of your package, why is  
it called Manifest-CriticBrowser ? It's very disturbing because everyone  
will first have a look a CriticBrowser, then spent 10 minutes to figure out  
that it's not the main class.

         - Add an example for CriticBrowser (now named  
SingleRuleCriticBrowser)


Slice is incoming fixing already a lot of issues


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded
        Labels: Milestone-2.0

Comment #1 on issue 7050 by [hidden email]: Critics Browser
http://code.google.com/p/pharo/issues/detail?id=7050

Slice in the inbox


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 7050 by [hidden email]: Critics Browser
http://code.google.com/p/pharo/issues/detail?id=7050

It was cool to pair-program. We should do that more often.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 7050 by [hidden email]: Critics Browser
http://code.google.com/p/pharo/issues/detail?id=7050

That's why we should have more "pair programming friday afternoon" :D


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 7050 by [hidden email]: Critics Browser
http://code.google.com/p/pharo/issues/detail?id=7050

Yes we should do that more and I should travel less.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #5 on issue 7050 by [hidden email]: Critics Browser
http://code.google.com/p/pharo/issues/detail?id=7050

in 2.0 419


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker