Issue 7064 in pharo: Snapshot announcement

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
16 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 7064 in pharo: Snapshot announcement

pharo
Status: Accepted
Owner: ----
Labels: Milestone-2.0 Type-Feature

New issue 7064 by [hidden email]: Snapshot announcement
http://code.google.com/p/pharo/issues/detail?id=7064

The idea is provide an announcement when an snapshot is done


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7064 in pharo: Snapshot announcement

pharo
Updates:
        Status: FixReviewNeeded

Comment #1 on issue 7064 by [hidden email]: Snapshot announcement
http://code.google.com/p/pharo/issues/detail?id=7064

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7064 in pharo: Snapshot announcement

pharo
Updates:
        Status: WorkNeeded

Comment #2 on issue 7064 by [hidden email]: Snapshot announcement
http://code.google.com/p/pharo/issues/detail?id=7064

The method snapshot:andQuit: has a reference to the non-existing class  
CHGChangeMonitor


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7064 in pharo: Snapshot announcement

pharo

Comment #3 on issue 7064 by [hidden email]: Snapshot announcement
http://code.google.com/p/pharo/issues/detail?id=7064

Yes, I'll delete this line and upload it again


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7064 in pharo: Snapshot announcement

pharo
Updates:
        Status: FixReviewNeeded

Comment #4 on issue 7064 by [hidden email]: Snapshot announcement
http://code.google.com/p/pharo/issues/detail?id=7064

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7064 in pharo: Snapshot announcement

pharo
Updates:
        Blockedon: pharo:7063

Comment #5 on issue 7064 by [hidden email]: Snapshot announcement
http://code.google.com/p/pharo/issues/detail?id=7064

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7064 in pharo: Snapshot announcement

pharo
Updates:
        Status: WorkNeeded

Comment #6 on issue 7064 by [hidden email]: Snapshot announcement
http://code.google.com/p/pharo/issues/detail?id=7064

Waiting for Issue 7063


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7064 in pharo: Snapshot announcement

pharo

Comment #7 on issue 7064 by [hidden email]: Snapshot announcement
http://code.google.com/p/pharo/issues/detail?id=7064

NextStep
- introduce an SnapshotAnnouncement
- signal it


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7064 in pharo: Snapshot announcement

pharo
Updates:
        Labels: sprintChile

Comment #8 on issue 7064 by [hidden email]: Snapshot announcement
http://code.google.com/p/pharo/issues/detail?id=7064

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7064 in pharo: Snapshot announcement

pharo

Comment #9 on issue 7064 by [hidden email]: Snapshot announcement
http://code.google.com/p/pharo/issues/detail?id=7064

Added a SnapshotDone announcement :) and made the announce in  
snapshot:andQuit:


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7064 in pharo: Snapshot announcement

pharo

Comment #10 on issue 7064 by [hidden email]: Snapshot announcement
http://code.google.com/p/pharo/issues/detail?id=7064

The behavior looks good, but I think the name #isNewImage is misleading. I  
think "booting", the old variable name captures the idea better. The cases  
where it makes a difference are:
1. Running image -> Save and Quit
   - The slice reports isNewImage = true when the image is restarted, but  
there is no image
2. Running image -> Save As...
   a) current state is saved to new image file
   b) last save point remains under former name
   - The slice reports "a" as "not new image" and "b" as "new image", which  
doesn't make sense to me. What does make sense is that "b" #isBooting the  
next time it is launched, just like the image from #1


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7064 in pharo: Snapshot announcement

pharo
Updates:
        Status: WorkNeeded-Conclusion
        Cc: [hidden email]

Comment #11 on issue 7064 by [hidden email]: Snapshot announcement
http://code.google.com/p/pharo/issues/detail?id=7064

@cami: what was the rationale of renaming the temporary in  
snapshot:andQuit: from resuming to booting to isNewImage. I think resuming  
was fine, booting is okay, and isNewImage is misleading (see above)... Let  
me know... When we decide on the terminology, this is ready to include.

I think for the temp and the announcement isResuming is best. Unless we're  
thinking that in the near future, an image might be constructed by some  
other route than a previously saved image, in which case I think isBooting  
is best...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7064 in pharo: Snapshot announcement

pharo

Comment #12 on issue 7064 by [hidden email]: Snapshot announcement
http://code.google.com/p/pharo/issues/detail?id=7064

I feel like changing everything there and use blocks to properly deletage  
actions.

I want to look at it from the user point of view. resuming can be anything,  
resuming after we saved, resuming after opening the saved image? resuming  
is very fuzzy for me.

And I discussed with Igor about it, which had the same doubts, so we went  
for newImage or newSession to make clear what we want. If you save the  
image and stay in the same session / same image, I think this is obviously  
isNewImage=false, whereas if we launch a new image and *resume* execution  
there it is isNewImage=true.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7064 in pharo: Snapshot announcement

pharo
Updates:
        Labels: -sprintChile

Comment #13 on issue 7064 by [hidden email]: Snapshot announcement
http://code.google.com/p/pharo/issues/detail?id=7064

"if we launch a new image and *resume* execution there it is  
isNewImage=true"
Yes, but look at comment #10 scenario one (with typo fixed):
     1. Running image -> Save and Quit
       - The slice reports isNewImage = true when the image is restarted,  
but there is no new image
"Resuming" and "booting" are indeed vague, but that's because they describe  
vague information! If we want to distinguish between forking an image  
vs.normal booting vs. whatever, let's do it; but in the current state,  
isNewImage implies more information than we actually have.

IMHO we should keep resuming/booting, at least until you do a larger  
rewrite that makes more finely-grained distinctions.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7064 in pharo: Snapshot announcement

pharo

Comment #14 on issue 7064 by [hidden email]: Snapshot announcement
http://code.google.com/p/pharo/issues/detail?id=7064

the term Igor suggested was isNewSession, which is more precise.

indeed so maybe we can switch it back.. well I don't care since I use the  
latest images all the time, so there is no discontinuity from 2.0 to 3.0 ;)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7064 in pharo: Snapshot announcement

pharo
Updates:
        Labels: -Milestone-2.0 Milestone-3.0

Comment #15 on issue 7064 by [hidden email]: Snapshot announcement
http://code.google.com/p/pharo/issues/detail?id=7064

I think we can move this to 3.0


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker