Issue 7102 in pharo: Don't insert spaces between SmartCharacters

Status: WorkNeeded-Conclusion
Owner: ----
CC: [hidden email]
Labels: Milestone-2.0 Type-Bug

New issue 7102 by [hidden email]: Don't insert spaces between  
SmartCharacters
http://code.google.com/p/pharo/issues/detail?id=7102

I am not sure if we should make this an option.
But I prefer not to have a space when opening smart character.

In the following cases spaces are definitely not needed:
- ''
- ""

In the following case I prefer spaces at both ends
- [  ]
- {  }


() is ambiguous as it might be used for (a subexpression) or #( a literal  
Array ), where I like spaces again.

Conclusion:
-----------
Either 2 or 0 spaces make most sense


Discussion:
-----------
- always 1 or always 2?
- 1/2 depending on the character?



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 7102 by [hidden email]: Don't insert spaces  
between SmartCharacters
http://code.google.com/p/pharo/issues/detail?id=7102

I do not know. No time to think about it. Now what I know is that I needed  
the space to distinguish

aaa|
+ "

=>

aaa"
and not
aaa""




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 7102 by [hidden email]: Don't insert spaces  
between SmartCharacters
http://code.google.com/p/pharo/issues/detail?id=7102

I must agree with Camillo.

The extra space for single or double quotes is annoying.

For square and curly braces two space with the cursor between them would  
make more sense.

This will annoy end users ...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #3 on issue 7102 by [hidden email]: Don't insert spaces  
between SmartCharacters
http://code.google.com/p/pharo/issues/detail?id=7102

+1 with Sven... I think we can definitely agree to remove the space from  
inside quotes forthwith... it is very annoying


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 7102 by [hidden email]: Don't insert spaces  
between SmartCharacters
http://code.google.com/p/pharo/issues/detail?id=7102

I started a configurable implementation, where you can specify a list of  
characters in the Settings for which you want zero, one or two spaces.
Though looks like the whole thing is hairier than I thought |(


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: -Type-Bug Type-Enh

Comment #5 on issue 7102 by [hidden email]: Don't insert spaces  
between SmartCharacters
http://code.google.com/p/pharo/issues/detail?id=7102

Good luck guy but if you change something it should work.
Because as I said spaces are important to distinguish the following  
situation and so far I do not see
how you can do it without space.

aaa|
+ "

=>

aaa"
and not
aaa""

because when I type

aaa "
I DONOT WANT aaa"" nor "aaa" I want aaa "



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 7102 by [hidden email]: Don't insert spaces  
between SmartCharacters
http://code.google.com/p/pharo/issues/detail?id=7102

And this is not a bug. Because right now everything works! Like removing  
the " and handling all the other key bindings.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 7102 by [hidden email]: Don't insert spaces  
between SmartCharacters
http://code.google.com/p/pharo/issues/detail?id=7102

I do not get what you mean stef.

If I type $" the autocompletion inserts a space afterwards. This is what we  
don't want. Your example shows in my opinion an unrelated thing of when to  
insert smart characters.

Currently when you type $" you get " " with the cursors somewhere in  
between, I want the two quotes without space "".

So I am only addressing the case where you actually insert a smart  
character.





_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]
        Labels: -Type-Enh Type-FirstImpressionsCount

Comment #8 on issue 7102 by [hidden email]: Don't insert spaces  
between SmartCharacters
http://code.google.com/p/pharo/issues/detail?id=7102

Why did it change to adding a space anyway? Can we revert to never adding a  
space while cami is working on a more flexible solution? This will be an  
annoyance to users (like me, lol) of 2.0


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 7102 by [hidden email]: Don't insert spaces  
between SmartCharacters
http://code.google.com/p/pharo/issues/detail?id=7102

In others IDE (eclipse, QT Creator, TextMate) , when you type a simple  
quote or a double quote, there is no space in between, and I think it makes  
sense.
Moreover, can someone tell me a case where you do NOT remove the space  
between the quotes ?

Camillo, is your code available somewhere ?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 7102 by [hidden email]: Don't insert spaces  
between SmartCharacters
http://code.google.com/p/pharo/issues/detail?id=7102

can you check the inbox? I think I uploaded it there.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #11 on issue 7102 by [hidden email]: Don't insert spaces  
between SmartCharacters
http://code.google.com/p/pharo/issues/detail?id=7102

nope, committing right now.

Name: NECompletion-CamilloBruni.71
Author: CamilloBruni
Time: 6 February 2013, 3:47:28.003 pm
UUID: e0598c2d-f224-4928-8bf0-186577f35a74
Ancestors: NECompletion-MarcusDenker.70

initial commit of smart char preferences


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #12 on issue 7102 by [hidden email]: Don't insert spaces  
between SmartCharacters
http://code.google.com/p/pharo/issues/detail?id=7102

I took care of the conflicts, merged it into latest and created a slice.

Two issues I noticed:
1. The cursor ends up before both spaces e.g. type $[, get "[cursor  ]"
2. The settings are doing something really weird in the Settings Browser,  
so I commented them out. If you uncomment them, and expand the completion  
settings in the browser, you will get the error from [1]

[1] Issue 7238: LazyListMorph>>selectionFrameForRow: fails with a 'should  
not happen' from Rectangle>>intersect:ifNone:


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #13 on issue 7102 by [hidden email]: Don't insert spaces  
between SmartCharacters
http://code.google.com/p/pharo/issues/detail?id=7102

I'll take a look at the insertion point. It would be great if someone who  
understands settings well investigates that...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Blockedon: pharo:7238

Comment #14 on issue 7102 by [hidden email]: Don't insert spaces  
between SmartCharacters
http://code.google.com/p/pharo/issues/detail?id=7102

Fixed the insertion point with spaces... settings may be fixed with Issue  
7238, but can't load slice due to "error: cannot remove empty categories"

New slice in inbox:  
SLICE-Issue-7102-Dont-insert-spaces-between-SmartCharacters-SeanDeNigris.2
Author: SeanDeNigris
- After inserting smart chars with spaces, put cursor in the center


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: OnHold

Comment #15 on issue 7102 by [hidden email]: Don't insert spaces  
between SmartCharacters
http://code.google.com/p/pharo/issues/detail?id=7102

Okay! Issue 7238 indeed fixes the settings issue. As soon as it is  
integrated, this is ready for review...

New slice in inbox: Name:  
SLICE-Issue-7102-Dont-insert-spaces-between-SmartCharacters-SeanDeNigris.3
- Uncomment new settings. They will work as soon as Issue 7238 is  
integrated.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #16 on issue 7102 by [hidden email]: Don't insert spaces  
between SmartCharacters
http://code.google.com/p/pharo/issues/detail?id=7102

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #17 on issue 7102 by [hidden email]: Don't insert spaces  
between SmartCharacters
http://code.google.com/p/pharo/issues/detail?id=7102

Go monkey, go! I tested several times by hand, should be okay :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #18 on issue 7102 by [hidden email]: Don't insert spaces  
between SmartCharacters
http://code.google.com/p/pharo/issues/detail?id=7102#c18

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20529

Comment #19 on issue 7102 by [hidden email]: Don't insert spaces  
between SmartCharacters
http://code.google.com/p/pharo/issues/detail?id=7102#c19

This Issue has been checked by Ulysse the Monkey
       
6447 tests passed in 00:02:26s:
===============================
        CollectionsTests-Arrayed (553)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (912)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (611)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1954)
        CollectionsTests-Weak (739)
        CompilerTests (181)
        KernelTests-Chronology (593)
        KernelTests-Classes (69)
        KernelTests-Exception (2)
        KernelTests-Methods (179)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (38)
        NECompletion-Tests (63)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-7102-Dont-insert-spaces-between-SmartCharacters-SeanDeNigris.3  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20529-a on NBCoInterpreter  
NativeBoost-CogPlugin-IgorStasenko.15 uuid:  
44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012
NBCogit NativeBoost-CogPlugin-IgorStasenko.15 uuid:  
44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
40ac7e7bdec6fef0e934d2c019b86db996053912 Date: 2012-11-19 18:54:49 +0100  
By: Mariano Martinez Peck <[hidden email]> Jenkins build #146


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker