Issue 7122 in pharo: Undeclared NBBasicExamples

Status: FailingTest
Owner: [hidden email]
Labels: Type-Bug Milestone-2.0

New issue 7122 by [hidden email]: Undeclared NBBasicExamples
http://code.google.com/p/pharo/issues/detail?id=7122

NBWin32Shell>>#getEnvironmentVariable: references non-existing  
NBBasicExamples


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #1 on issue 7122 by [hidden email]: Undeclared  
NBBasicExamples
http://code.google.com/p/pharo/issues/detail?id=7122

Igor can you take action?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 7122 by [hidden email]: Undeclared NBBasicExamples
http://code.google.com/p/pharo/issues/detail?id=7122

Ohhh ... Igor threw out NBBasicExamples - without checking for references.

The fix is easy. Just change NBWin32Shell>>#getEnvironmentVariable: to:

getEnvironmentVariable: variableName
        "Return the value of the given environment variable"
       
        <primitive: #primitiveNativeCall module: #NativeBoostPlugin error:  
errorCode >
         ^ self nbCall: #( String getenv (String variableName) ) module:  
NativeBoost CLibrary


But for whatever reason I do not have developer access to  
squeaksource/NativeBoost anymore. Igor: can you add me, stef and markus  
(but also ad administrator ?) so we can fix it.





_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 7122 by [hidden email]: Undeclared NBBasicExamples
http://code.google.com/p/pharo/issues/detail?id=7122

Fix including a test

Attachments:
        FixIssue7122.cs  1.1 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #4 on issue 7122 by [hidden email]: Undeclared  
NBBasicExamples
http://code.google.com/p/pharo/issues/detail?id=7122

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #5 on issue 7122 by [hidden email]: Undeclared  
NBBasicExamples
http://code.google.com/p/pharo/issues/detail?id=7122

I will integrate this in the image for now...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #6 on issue 7122 by [hidden email]: Undeclared  
NBBasicExamples
http://code.google.com/p/pharo/issues/detail?id=7122

in 2.0 449


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 7122 by [hidden email]: Undeclared NBBasicExamples
http://code.google.com/p/pharo/issues/detail?id=7122

sorry, missed this one.
Using a class from examples is a mistake, because it introduces circular  
dependency between NativeBoost-Win32 and NativeBoost-Examples.
But it was not my code :)

in ConfigurationOfNativeBoost-IgorStasenko.52 version 1.8


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 7122 by [hidden email]: Undeclared NBBasicExamples
http://code.google.com/p/pharo/issues/detail?id=7122

added (again) Torsten and Marcus as devs on NB.
Can't find Stef in list..


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker