Issue 7129 in pharo: Make automatic .source download fault tolerant

Status: Accepted
Owner: [hidden email]
Labels: Type-Bug Importance-High Milestone-2.0

New issue 7129 by [hidden email]: Make automatic .source download fault  
tolerant
http://code.google.com/p/pharo/issues/detail?id=7129

if, for any reason image cannot connect to provided url(s)
it will stuck indefinitely (or perhaps way too long for user's perception)
and won't give any feedback to user.
which makes image unusable.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 7129 by [hidden email]: Make automatic .source  
download fault tolerant
http://code.google.com/p/pharo/issues/detail?id=7129

That is a question of configuring the ZnClient timeouts and/or of providing  
some user feedback when possible.

There is a missing sources warning as well no ?

I was planning of going over all system users of ZnClient one of these days  
to see if we can make usage a bit more consistent.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 7129 by [hidden email]: Make automatic .source  
download fault tolerant
http://code.google.com/p/pharo/issues/detail?id=7129

The error handling is there: the code tries downloading from 2 locations,  
ignoring errors.

You should see this code as: if there is no .sources, try downloading it as  
an extra service, if that fails, give an error as before.

The only 'problem' is that the timeout might be too high.

As I said: I will go over all system users of ZnClient one of these days to  
make sure they are OK.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 7129 by [hidden email]: Make automatic .source  
download fault tolerant
http://code.google.com/p/pharo/issues/detail?id=7129

See some comments on http://code.google.com/p/pharo/issues/detail?id=7135


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 7129 by [hidden email]: Make automatic .source  
download fault tolerant
http://code.google.com/p/pharo/issues/detail?id=7129

Name:  
SLICE-Issue-7129-Make-automatic-source-download-fault-tolerant-CamilloBruni.1
Author: CamilloBruni
Time: 10 January 2013, 2:52:43.789 pm
UUID: 5f365b12-fa77-43e6-81b3-3422ff47e6b3
Ancestors:
Dependencies: System-Support-CamilloBruni.759

- reduce the source download timeout time, we want to fail pretty fast
- inform in detail what's going on when downloading the sources


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 7129 by [hidden email]: Make automatic .source download  
fault tolerant
http://code.google.com/p/pharo/issues/detail?id=7129

Nice !

Maybe do an automatic source reformat to harmonise spacing ;-)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #6 on issue 7129 by [hidden email]: Make automatic .source  
download fault tolerant
http://code.google.com/p/pharo/issues/detail?id=7129

Name:  
SLICE-Issue-7129-Make-automatic-source-download-fault-tolerant-CamilloBruni.3
Author: CamilloBruni
Time: 10 January 2013, 8:54:33.325 pm
UUID: ebf6bb62-36ab-4cf7-adeb-7874a63a0a2e
Ancestors:  
SLICE-Issue-7129-Make-automatic-source-download-fault-tolerant-CamilloBruni.2
Dependencies: System-Support-CamilloBruni.761

minor source code formatting to please sven :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 7129 by [hidden email]: Make automatic .source  
download fault tolerant
http://code.google.com/p/pharo/issues/detail?id=7129

bah actually it's useless to show a progress bar. since the download  
happens during the startup, so there is no UI thread yet :/


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #8 on issue 7129 by [hidden email]: Make automatic .source  
download fault tolerant
http://code.google.com/p/pharo/issues/detail?id=7129

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 7129 by [hidden email]: Make automatic .source  
download fault tolerant
http://code.google.com/p/pharo/issues/detail?id=7129

Name:  
SLICE-Issue-7129-Make-automatic-source-download-fault-tolerant-CamilloBruni.4
Author: CamilloBruni
Time: 10 January 2013, 11:55:39.564 pm
UUID: e83493cd-a2dd-4013-bb02-e3428f998495
Ancestors:  
SLICE-Issue-7129-Make-automatic-source-download-fault-tolerant-CamilloBruni.3
Dependencies: System-Support-CamilloBruni.762,  
Files-CamilloBruni.ducasse.288

externalize all source files handling to SourceFilesArray, instead of  
keeping everything in SmalltalkImage


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 7129 by [hidden email]: Make automatic .source download  
fault tolerant
http://code.google.com/p/pharo/issues/detail?id=7129

Aah, getting better all the time ;-)

I haven't loaded it but the code looks great.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #11 on issue 7129 by [hidden email]: Make automatic .source  
download fault tolerant
http://code.google.com/p/pharo/issues/detail?id=7129

Name:  
SLICE-Issue-7129-Make-automatic-source-download-fault-tolerant-CamilloBruni.5
Author: CamilloBruni
Time: 11 January 2013, 1:01:50.657 am
UUID: 5b990467-e820-4092-af83-485db462c425
Ancestors:  
SLICE-Issue-7129-Make-automatic-source-download-fault-tolerant-CamilloBruni.4
Dependencies: System-Support-CamilloBruni.762,  
Files-CamilloBruni.ducasse.289

more refactoring
- SourceFilesArray is now fully in charge of loading the .sources  
and .changes file
- further refactoring of SmalltalkImage:
        - delegate all sources file handling to SourceFilesArray
        - use streaming protocol for logging messages on SmalltalkImage


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #12 on issue 7129 by [hidden email]: Make automatic .source  
download fault tolerant
http://code.google.com/p/pharo/issues/detail?id=7129

- added #sourceFiles accessor on SmalltalkImage


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #13 on issue 7129 by [hidden email]: Make automatic .source  
download fault tolerant
http://code.google.com/p/pharo/issues/detail?id=7129

loaded in a fresh image, passed all Kernel* and Files* tests


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #14 on issue 7129 by [hidden email]: Make automatic .source  
download fault tolerant
http://code.google.com/p/pharo/issues/detail?id=7129

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #15 on issue 7129 by [hidden email]: Make automatic .source  
download fault tolerant
http://code.google.com/p/pharo/issues/detail?id=7129

Issue 7135 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #16 on issue 7129 by [hidden email]: Make automatic .source  
download fault tolerant
http://code.google.com/p/pharo/issues/detail?id=7129

Issue 7135 has been merged into this issue.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #17 on issue 7129 by [hidden email]: Make automatic .source  
download fault tolerant
http://code.google.com/p/pharo/issues/detail?id=7129

After loading this I made a test: delete the .changes.

--> image comes of with a white blocked screen


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #18 on issue 7129 by [hidden email]: Make automatic .source  
download fault tolerant
http://code.google.com/p/pharo/issues/detail?id=7129

After the red screen of death, the spinning wheel of death, the white  
screen of death :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #19 on issue 7129 by [hidden email]: Make automatic .source  
download fault tolerant
http://code.google.com/p/pharo/issues/detail?id=7129

:D, yup I can confirm that. and I discovered a couple of issues:
- I cannot print on stderr when initializing stuff in SmalltalkImage
- Warnings are eaten somewhere by the startup logic

=> for 3.0 we should really adapt Igor's idea of a lazy startup mechanism  
where everything is loaded on demand.

I will try to refactor the sources/changes loading further out and put the  
startup logic further to back to of the StartupList, like that we can at  
least inform the user what's going on.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker