Issue 7139 in pharo: Fixing some refactorings problem in 2.0

Status: Accepted
Owner: [hidden email]
CC: [hidden email]
Labels: Type-Bug Milestone-2.0

New issue 7139 by [hidden email]: Fixing some refactorings problem  
in 2.0
http://code.google.com/p/pharo/issues/detail?id=7139

I did some investigations and it seems to me that the problem comes from  
the ChangesBrowser. It stores the changes in a Set which in turn changes  
the order of declarations... So how can I define a method in a class that  
does not exit?
The PickListModel is the culprit ;)

Bellow you will find the snippet that I have promised...

model := RBNamespace  new .
className := 'ANewClassForTheSystem' asSymbol.
model defineClass:
                ('<1s>
                subclass: #<2s>
                instanceVariableNames: ''''
                classVariableNames: ''''
                poolDictionaries: ''''
                category: <3p>' expandMacrosWith: 'NBExternalStructure' with: className  
with: 'JustTesting').
               
model compile: 'myInstanceMethod  ^''Hello world'' ' in: (model classNamed:  
className) classified: 'method declaration'.

model compile: 'myClassMethod   ^self new ' in: (model metaclassNamed:  
className)  classified: 'method declaration'.
               
"(ChangesBrowser changes: model changes ) openWithSpec ."
(ChangesBrowser new change: model changes  ) openWithSpec .


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 7139 by [hidden email]: Fixing some refactorings  
problem in 2.0
http://code.google.com/p/pharo/issues/detail?id=7139

changing its pickedItemsHolder from Set new asValueHolder to  
OrderedCollection  new asValueHolder fixes my issue ... but of course I  
don't really now where in the system the items are used as set ... Maybe we  
can change its name to PickSetModel or PickUnorderedListModel...

by the way I find PickListModel not a good name at all It probably should  
be PickedListModel -> for the items picked from a list




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Duplicate
        Mergedinto: 7133

Comment #2 on issue 7139 by [hidden email]: Fixing some refactorings  
problem in 2.0
http://code.google.com/p/pharo/issues/detail?id=7139

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker