Status: Accepted
Owner: [hidden email] Labels: Type-Bug Milestone-2.0 New issue 7149 by [hidden email]: Selection is wrong in senders and Implementors http://code.google.com/p/pharo/issues/detail?id=7149 for example looking for the users of LayoutFrame will select asLayoutFrame while LayoutFrame appears before. _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #1 on issue 7149 by [hidden email]: Selection is wrong in senders and Implementors http://code.google.com/p/pharo/issues/detail?id=7149 It looks like it's highlighting all partial matches, and not just whole words, so LayoutFrame and as LayoutFrame are both highlighted _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Labels: sprintchile Comment #2 on issue 7149 by [hidden email]: Selection is wrong in senders and Implementors http://code.google.com/p/pharo/issues/detail?id=7149 (No comment was entered for this change.) _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #3 on issue 7149 by [hidden email]: Selection is wrong in senders and Implementors http://code.google.com/p/pharo/issues/detail?id=7149 This is a vicious bug. Before fixing it, let's give the definition of the faulting method (for archiving purpose): -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= MessageBrowser>>searchedString: searchedString in: aString | string interval firstIndex | searchedString ifNil: [ ^ 0 to: 0 ]. aString isEmptyOrNil ifTrue: [ ^0 to: 0 ]. string := aString asString. interval := 0 to: 0. (searchedString includes: $:) ifTrue: [ | list | list := searchedString subStrings: ':'. list size = 1 ifTrue: [" binary selector " firstIndex := 1. [ firstIndex isZero not and: [ (string at: (firstIndex +1)) isAlphaNumeric ]] whileTrue: [ firstIndex := string findString: searchedString startingAt: firstIndex+1. firstIndex isZero ifFalse: [ interval := firstIndex to: (firstIndex+searchedString size-1)]]] ifFalse: [| lastIndex | firstIndex := 1. [ firstIndex isZero not and: [ (string at: (firstIndex +1)) isAlphaNumeric ]] whileTrue: [ firstIndex := string findString: list first,':' startingAt: firstIndex+1. firstIndex isZero ifFalse: [ lastIndex := string findString: list last,':' startingAt: firstIndex+ (list first size -1). interval := firstIndex to: (lastIndex + list last size)]]]] ifFalse: [ " unary selector " firstIndex := 1. [ firstIndex isZero not and: [ (string at: (firstIndex +1)) isAlphaNumeric ]] whileTrue: [ firstIndex := string findString: searchedString startingAt: firstIndex +1. firstIndex isZero ifFalse: [ interval := firstIndex to: (firstIndex+searchedString size-1)]]]. ^ interval -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #4 on issue 7149 by [hidden email]: Selection is wrong in senders and Implementors http://code.google.com/p/pharo/issues/detail?id=7149 The problem with this code, is that it is actually made to always give the last occurrence. I am not sure why actually. What would be the need for getting the last occurrence? _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: FixReviewNeeded Comment #5 on issue 7149 by [hidden email]: Selection is wrong in senders and Implementors http://code.google.com/p/pharo/issues/detail?id=7149 Improvement of the searching when looking for the user of a selector or a class name. Tests for MessageBrowser have been added. Pair programmed with Milton Mamani during the Pharo Sprint organized by Object Profile in Santiago In the inbox! _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: MonkeyIsChecking Comment #6 on issue 7149 by [hidden email]: Selection is wrong in senders and Implementors http://code.google.com/p/pharo/issues/detail?id=7149#c6 The Monkey is currently checking this issue. Please don't change it! _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: ValidatedByTheMonkey Labels: CheckedIn20498 Comment #7 on issue 7149 by [hidden email]: Selection is wrong in senders and Implementors http://code.google.com/p/pharo/issues/detail?id=7149#c7 This Issue has been checked by Ulysse the Monkey 6409 tests passed in 00:02:36s: =============================== CollectionsTests-Arrayed (553) CollectionsTests-Atomic (12) CollectionsTests-Sequenceable (912) CollectionsTests-SplitJoin (27) CollectionsTests-Stack (16) CollectionsTests-Streams (37) CollectionsTests-Strings (611) CollectionsTests-Support (12) CollectionsTests-Unordered (1954) CollectionsTests-Weak (739) CompilerTests (181) KernelTests-Chronology (589) KernelTests-Classes (68) KernelTests-Exception (2) KernelTests-Methods (179) KernelTests-Numbers (276) KernelTests-Objects (86) KernelTests-Pragmas (3) KernelTests-Processes (38) SUnit-Core-Extensions (3) SUnit-Core-Utilities (3) SUnit-Tests-Core (78) ToolsTest-Base (2) ToolsTest-Debugger (10) ToolsTest-Finder (9) ToolsTest-Inspector (1) ToolsTest-MessageTally (5) ToolsTest-PointerFinder (3) ---------------------------------------------------------- Loaded Source: SLICE-Issue-7149-Selection-is-wrong-in-senders-and-Implementors-AlexandreBergel.2 from http://ss3.gemstone.com/ss/PharoInbox Tested using Pharo-2.0-20498-a on CoInterpreter VMMaker-oscog-EstebanLorenzano.166 uuid: 5773fcb9-2982-4507-8a9e-4308ec33731e Dec 12 2012 StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.166 uuid: 5773fcb9-2982-4507-8a9e-4308ec33731e Dec 12 2012 git://gitorious.org/cogvm/blessed.git Commit: 452863bdfba2ba0b188e7b172e9bc597a2caa928 Date: 2012-12-07 16:49:46 +0100 By: Esteban Lorenzano <[hidden email]> Jenkins build #5922 _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: MonkeyIsChecking Comment #8 on issue 7149 by [hidden email]: Selection is wrong in senders and Implementors http://code.google.com/p/pharo/issues/detail?id=7149#c8 The Monkey is currently checking this issue. Please don't change it! _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: ValidatedByTheMonkey Labels: CheckedIn20499 Comment #9 on issue 7149 by [hidden email]: Selection is wrong in senders and Implementors http://code.google.com/p/pharo/issues/detail?id=7149#c9 This Issue has been checked by Ulysse the Monkey 6413 tests passed in 00:02:31s: =============================== CollectionsTests-Arrayed (553) CollectionsTests-Atomic (12) CollectionsTests-Sequenceable (912) CollectionsTests-SplitJoin (27) CollectionsTests-Stack (16) CollectionsTests-Streams (37) CollectionsTests-Strings (611) CollectionsTests-Support (12) CollectionsTests-Unordered (1954) CollectionsTests-Weak (739) CompilerTests (181) KernelTests-Chronology (593) KernelTests-Classes (68) KernelTests-Exception (2) KernelTests-Methods (179) KernelTests-Numbers (276) KernelTests-Objects (86) KernelTests-Pragmas (3) KernelTests-Processes (38) SUnit-Core-Extensions (3) SUnit-Core-Utilities (3) SUnit-Tests-Core (78) ToolsTest-Base (2) ToolsTest-Debugger (10) ToolsTest-Finder (9) ToolsTest-Inspector (1) ToolsTest-MessageTally (5) ToolsTest-PointerFinder (3) ---------------------------------------------------------- Loaded Source: SLICE-Issue-7149-Selection-is-wrong-in-senders-and-Implementors-AlexandreBergel.2 from http://ss3.gemstone.com/ss/PharoInbox Tested using Pharo-2.0-20499-a on CoInterpreter VMMaker-oscog-EstebanLorenzano.166 uuid: 5773fcb9-2982-4507-8a9e-4308ec33731e Dec 12 2012 StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.166 uuid: 5773fcb9-2982-4507-8a9e-4308ec33731e Dec 12 2012 git://gitorious.org/cogvm/blessed.git Commit: 452863bdfba2ba0b188e7b172e9bc597a2caa928 Date: 2012-12-07 16:49:46 +0100 By: Esteban Lorenzano <[hidden email]> Jenkins build #5922 _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: MonkeyIsChecking Comment #10 on issue 7149 by [hidden email]: Selection is wrong in senders and Implementors http://code.google.com/p/pharo/issues/detail?id=7149#c10 The Monkey is currently checking this issue. Please don't change it! _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: ValidatedByTheMonkey Labels: CheckedIn20500 Comment #11 on issue 7149 by [hidden email]: Selection is wrong in senders and Implementors http://code.google.com/p/pharo/issues/detail?id=7149#c11 This Issue has been checked by Ulysse the Monkey 6413 tests passed in 00:01:55s: =============================== CollectionsTests-Arrayed (553) CollectionsTests-Atomic (12) CollectionsTests-Sequenceable (912) CollectionsTests-SplitJoin (27) CollectionsTests-Stack (16) CollectionsTests-Streams (37) CollectionsTests-Strings (611) CollectionsTests-Support (12) CollectionsTests-Unordered (1954) CollectionsTests-Weak (739) CompilerTests (181) KernelTests-Chronology (593) KernelTests-Classes (68) KernelTests-Exception (2) KernelTests-Methods (179) KernelTests-Numbers (276) KernelTests-Objects (86) KernelTests-Pragmas (3) KernelTests-Processes (38) SUnit-Core-Extensions (3) SUnit-Core-Utilities (3) SUnit-Tests-Core (78) ToolsTest-Base (2) ToolsTest-Debugger (10) ToolsTest-Finder (9) ToolsTest-Inspector (1) ToolsTest-MessageTally (5) ToolsTest-PointerFinder (3) ---------------------------------------------------------- Loaded Source: SLICE-Issue-7149-Selection-is-wrong-in-senders-and-Implementors-AlexandreBergel.2 from http://ss3.gemstone.com/ss/PharoInbox Tested using Pharo-2.0-20500-a on NBCoInterpreter NativeBoost-CogPlugin-IgorStasenko.15 uuid: 44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012 NBCogit NativeBoost-CogPlugin-IgorStasenko.15 uuid: 44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012 https://git.gitorious.org/cogvm/blessed.git Commit: 40ac7e7bdec6fef0e934d2c019b86db996053912 Date: 2012-11-19 18:54:49 +0100 By: Mariano Martinez Peck <[hidden email]> Jenkins build #146 _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: Integrated Comment #12 on issue 7149 by [hidden email]: Selection is wrong in senders and Implementors http://code.google.com/p/pharo/issues/detail?id=7149 in 20502 _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Free forum by Nabble | Edit this page |