Issue 7174 in pharo: Class comment pane and variable binding

Status: Accepted
Owner: [hidden email]
Labels: Type-Bug Milestone-2.0 Target-Nautilus

New issue 7174 by [hidden email]: Class comment pane and variable  
binding
http://code.google.com/p/pharo/issues/detail?id=7174

Evaluating an expression in the class comment pane should not take the  
class instance variable into scope.
Else this can lead to destroying class without noticing.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #1 on issue 7174 by [hidden email]: Class comment pane and  
variable binding
http://code.google.com/p/pharo/issues/detail?id=7174

emmm.... I don't think this is really an issue. Yeah, is dangerous, but  
that's part of the power of smalltalk, isn't it?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded-NextAction

Comment #2 on issue 7174 by [hidden email]: Class comment pane and  
variable binding
http://code.google.com/p/pharo/issues/detail?id=7174

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 7174 by [hidden email]: Class comment pane and  
variable binding
http://code.google.com/p/pharo/issues/detail?id=7174

I think inst vars should not be accessible from class comments. For me, a  
class comment is much like a workspace, which wouldn't have access to inst  
vars. In fact, I didn't even know it was possible to access them from class  
comments until I saw this issue. I don't think the danger is worth it.  
Naive users could be executing things in a comment with no idea of the  
consequences. What is the use case?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 7174 by [hidden email]: Class comment pane and  
variable binding
http://code.google.com/p/pharo/issues/detail?id=7174

No esteban this is not good to bind variable when we are inside the comment  
pane.
  This has nothing to do with power. I got bitten by that and it was never  
ilke that and brings nothing.
If you want to expression and expression in the scope of a class then open  
an inspector.

I think that we have that because ben reuse a way to evaluate code and it  
is not suited for doing it in the class comment.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 7174 by [hidden email]: Class comment pane and  
variable binding
http://code.google.com/p/pharo/issues/detail?id=7174

but, but... this was like this since ever... (all browsers)
It is something with the doItReceiver and something magically called in the  
compiler (through TextMorph, et all) .

To fix that we should:
1) create a special context (no idea how to, but feasible)
2) just forbid execution on comment panel.

In any case, I would delay this to 3.0...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 7174 by [hidden email]: Class comment pane and  
variable binding
http://code.google.com/p/pharo/issues/detail?id=7174

I do not think that this was like that in other browser.
I should have logged the error I got.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Invalid

Comment #7 on issue 7174 by [hidden email]: Class comment pane and  
variable binding
http://code.google.com/p/pharo/issues/detail?id=7174

So  check and it was like that so I close it now but it burned me.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker