Issue 7188 in pharo: Got a red square of death when changing the commit message

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
18 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 7188 in pharo: Got a red square of death when changing the commit message

pharo
Status: Accepted
Owner: [hidden email]
Labels: Type-Bug Target-Spec Milestone-2.0

New issue 7188 by [hidden email]: Got a red square of death when  
changing the commit message
http://code.google.com/p/pharo/issues/detail?id=7188

If I delete the "empty log" message (or whatever message I had enter here)
I get a square of death about a string size not correct


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7188 in pharo: Got a red square of death when changing the commit message

pharo

Comment #1 on issue 7188 by [hidden email]: Got a red square of  
death when changing the commit message
http://code.google.com/p/pharo/issues/detail?id=7188

Strange :)



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7188 in pharo: Got a red square of death when changing the commit message

pharo

Comment #2 on issue 7188 by [hidden email]: Got a red square of  
death when changing the commit message
http://code.google.com/p/pharo/issues/detail?id=7188

It also happened with the Workspace

Type something into a workspace.
Select everything with cmd+a
Delete
Red Square of Death


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7188 in pharo: Got a red square of death when changing the commit message

pharo

Comment #3 on issue 7188 by [hidden email]: Got a red square of  
death when changing the commit message
http://code.google.com/p/pharo/issues/detail?id=7188

It seems that all text zone are touched by this plague


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7188 in pharo: Got a red square of death when changing the commit message

pharo

Comment #4 on issue 7188 by [hidden email]: Got a red square of  
death when changing the commit message
http://code.google.com/p/pharo/issues/detail?id=7188

More accurate symptom:

You do not have o remove all the text, just more that one character


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7188 in pharo: Got a red square of death when changing the commit message

pharo

Comment #5 on issue 7188 by [hidden email]: Got a red square of  
death when changing the commit message
http://code.google.com/p/pharo/issues/detail?id=7188

More info
If you cut selection, it works
If you move lines left or right -> SOD


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7188 in pharo: Got a red square of death when changing the commit message

pharo

Comment #6 on issue 7188 by [hidden email]: Got a red square of  
death when changing the commit message
http://code.google.com/p/pharo/issues/detail?id=7188

And everything works in the panel for class editing


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7188 in pharo: Got a red square of death when changing the commit message

pharo

Comment #7 on issue 7188 by [hidden email]: Got a red square of  
death when changing the commit message
http://code.google.com/p/pharo/issues/detail?id=7188

Thierry could you have a look because I wonder if this is related to the  
change you did and that I integrated?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7188 in pharo: Got a red square of death when changing the commit message

pharo
Updates:
        Status: HorribleErrorBlockingEverything
        Owner: [hidden email]
        Labels: -Target-Spec

Comment #8 on issue 7188 by [hidden email]: Got a red square of  
death when changing the commit message
http://code.google.com/p/pharo/issues/detail?id=7188

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7188 in pharo: Got a red square of death when changing the commit message

pharo

Comment #9 on issue 7188 by [hidden email]: Got a red square of  
death when changing the commit message
http://code.google.com/p/pharo/issues/detail?id=7188

I can't reproduce the bug in #20463, can you?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7188 in pharo: Got a red square of death when changing the commit message

pharo

Comment #10 on issue 7188 by [hidden email]: Got a red square of  
death when changing the commit message
http://code.google.com/p/pharo/issues/detail?id=7188

Yes I do !
I will check without changing the default font and see


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7188 in pharo: Got a red square of death when changing the commit message

pharo

Comment #11 on issue 7188 by [hidden email]: Got a red square of  
death when changing the commit message
http://code.google.com/p/pharo/issues/detail?id=7188

So when I take a fresh image and change the font it works.

So some shit happens when loading my preferences. I will dig this way


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7188 in pharo: Got a red square of death when changing the commit message

pharo

Comment #12 on issue 7188 by [hidden email]: Got a red square of  
death when changing the commit message
http://code.google.com/p/pharo/issues/detail?id=7188

the responsible is

((Smalltalk at: #UITheme) perform: #currentSettings) perform:  
#secondarySelectionTextColor: with: ((Color r: 0.0 g: 0.0 b: 0.0))

Do not know why yet


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7188 in pharo: Got a red square of death when changing the commit message

pharo

Comment #13 on issue 7188 by [hidden email]: Got a red square of  
death when changing the commit message
http://code.google.com/p/pharo/issues/detail?id=7188

It seems that the piece of code about secondarySelectionTextColor is broken

By luck, this is not used by default in the Pharo theme, but it's severely  
broken


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7188 in pharo: Got a red square of death when changing the commit message

pharo

Comment #14 on issue 7188 by [hidden email]: Got a red square of  
death when changing the commit message
http://code.google.com/p/pharo/issues/detail?id=7188

Benjamin, did you find a solution ?

I have one and it's introduced by my change that Stephane integrated. When  
adding attributes to a text, if the text is empty and attributes are out of  
range, then it does an out of bounds error applying the secondary selection  
attributes. I'll protect the relevant code.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7188 in pharo: Got a red square of death when changing the commit message

pharo

Comment #15 on issue 7188 by [hidden email]: Got a red square of  
death when changing the commit message
http://code.google.com/p/pharo/issues/detail?id=7188

Ok. I have uploaded a slice in inbox which seems to be doing the job.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7188 in pharo: Got a red square of death when changing the commit message

pharo
Updates:
        Status: FixReviewNeeded

Comment #16 on issue 7188 by [hidden email]: Got a red square of  
death when changing the commit message
http://code.google.com/p/pharo/issues/detail?id=7188

Cool :)
Thank you :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7188 in pharo: Got a red square of death when changing the commit message

pharo
Updates:
        Status: Integrated

Comment #17 on issue 7188 by [hidden email]: Got a red square of  
death when changing the commit message
http://code.google.com/p/pharo/issues/detail?id=7188

in 2.0 464


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker