Issue 7192 in pharo: JobEnd Bug

Status: Accepted
Owner: [hidden email]
CC: [hidden email]
Labels: Type-Bug

New issue 7192 by [hidden email]: JobEnd Bug
http://code.google.com/p/pharo/issues/detail?id=7192

JobEnd Bug

Currently we have


SystemProgressMorph class>> endJob: aJobEnd

     self uniqueInstance close: self uniqueInstance bars last.

and this does not work

I did a hack

SystemProgressMorph class>>endJob: aJobEnd
        | bars |
        self flag: #toFix. "camillo I need help"
        bars := self uniqueInstance bars.
        bars isEmpty
                ifFalse: [ bars do: [:each |  self uniqueInstance close:  each ] ]
       


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: HumanReviewNeeded

Comment #1 on issue 7192 by [hidden email]: JobEnd Bug
http://code.google.com/p/pharo/issues/detail?id=7192

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 7192 by [hidden email]: JobEnd Bug
http://code.google.com/p/pharo/issues/detail?id=7192

Probably better because there seems that last has a psecial role.

endJob: aJobEnd
        | bars |
        self flag: #toFix. "camillo I need help"
        bars := self uniqueInstance bars.
        bars isEmpty
                ifFalse: [ self uniqueInstance close:  bars last ]


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 7192 by [hidden email]: JobEnd Bug
http://code.google.com/p/pharo/issues/detail?id=7192

I'm rerunning the tests with this fix to see if I get all the endJob: ....  
bugs.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 7192 by [hidden email]: JobEnd Bug
http://code.google.com/p/pharo/issues/detail?id=7192

There is the same problem in updateJob:

updateJob: aJobChange
        | bars |
        bars := self uniqueInstance bars.
        bars isEmpty
                ifFalse: [
                        bars last
                                label: aJobChange title;
                                progress: aJobChange progress.
        self uniqueInstance changed]


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 7192 by [hidden email]: JobEnd Bug
http://code.google.com/p/pharo/issues/detail?id=7192

slice in the inbox


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 7192 by [hidden email]: JobEnd Bug
http://code.google.com/p/pharo/issues/detail?id=7192

So the fix works!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #7 on issue 7192 by [hidden email]: JobEnd Bug
http://code.google.com/p/pharo/issues/detail?id=7192

Integrated in 20462


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker