Issue 7207 in pharo: Solution for issue 3882 introduced bugs with scaling and moving ImageMorphs using Morphic Halos

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

Issue 7207 in pharo: Solution for issue 3882 introduced bugs with scaling and moving ImageMorphs using Morphic Halos

pharo
Status: New
Owner: ----
Labels: Type-Bug

New issue 7207 by [hidden email]: Solution for issue 3882 introduced  
bugs with scaling and moving ImageMorphs using Morphic Halos
http://code.google.com/p/pharo/issues/detail?id=7207

Pharo image: core
Pharo core version: Pharo 1.4  #14457
Virtual machine used: linux (from the 1.4 one click.app)

Steps to reproduce #1:
1.  Open Halos on an ImageMorph (such as the Pharo ImageMorph on the main  
screen)
2.  Use the move halo to move the ImageMorph.  Once the mouse button is  
released, the debugger opens. (I have not included the stack trace in this  
report, the explanation below explains what the problem is.)

Steps to reproduce #2:
1.  Open Halos on an ImageMorph (such as the Pharo image on the main screen)
2.  Use the "Change Scale" halo to scale the ImageMorph larger.  Scale  
again, back down to the original size.  Once the mouse button is released,  
the debugger opens.



To fix the issue described here  
http://code.google.com/p/pharo/issues/detail?id=3882, code was introduced  
which make ImageMorphs respond "true" to the message "isFlexMorph", as  
TransformationMorphs do.  Although this code does allow the previously  
unscalable ImageMorph to scale, it introduces the two bugs listed above,  
because ImageMorphs do not respond to all of the messages that  
TransformationMorph responds to.
(By looking and the senders of 'isFlexMorph', it is clear to see that  
ImageMorph does not implement the required methods, nor should it)


I'm not very familiar with Monticello, and it appears as though I pushed my  
changes to http://ss3.gemstone.com/ss/Pharo14, as  
Morphic-WilliamSix.1144.mcz.  I thought I was saving my changes locally,  
and did not expect that my action could nor would push changes elsewhere.  
I need to read more to understand Monticello workflow.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7207 in pharo: Solution for issue 3882 introduced bugs with scaling and moving ImageMorphs using Morphic Halos

pharo

Comment #1 on issue 7207 by [hidden email]: Solution for issue 3882  
introduced bugs with scaling and moving ImageMorphs using Morphic Halos
http://code.google.com/p/pharo/issues/detail?id=7207

I forgot to mention, Morphic-WilliamSix.1144.mcz solves issue 3882, and  
also fixes the bugs that 3882 introduced.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7207 in pharo: Solution for issue 3882 introduced bugs with scaling and moving ImageMorphs using Morphic Halos

pharo
Updates:
        Status: FixReviewNeeded
        Labels: Milestone-2.0

Comment #2 on issue 7207 by [hidden email]: Solution for issue 3882  
introduced bugs with scaling and moving ImageMorphs using Morphic Halos
http://code.google.com/p/pharo/issues/detail?id=7207

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7207 in pharo: Solution for issue 3882 introduced bugs with scaling and moving ImageMorphs using Morphic Halos

pharo
Updates:
        Labels: -Milestone-2.0 Milestone-1.4

Comment #3 on issue 7207 by [hidden email]: Solution for issue 3882  
introduced bugs with scaling and moving ImageMorphs using Morphic Halos
http://code.google.com/p/pharo/issues/detail?id=7207

This is for 1.4

-> need to be checked there
-> Does this need to be ported in 2.0?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7207 in pharo: Solution for issue 3882 introduced bugs with scaling and moving ImageMorphs using Morphic Halos

pharo

Comment #4 on issue 7207 by [hidden email]: Solution for issue 3882  
introduced bugs with scaling and moving ImageMorphs using Morphic Halos
http://code.google.com/p/pharo/issues/detail?id=7207

The bug with ImageMorph is also present in 2.0.  The port is  
straightforward, the changes are identical, and the loaded changes work  
correctly.  I have a local monticello commit which was a port from the 1.4  
image.  The .mcz file is attached.

I'm in the process of reading "HowToContribute" so that I contribute the  
code through the proper channels, which I don't think I did last time.

Attachments:
        Morphic-WilliamSix.1318.mcz  1.1 MB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7207 in pharo: Solution for issue 3882 introduced bugs with scaling and moving ImageMorphs using Morphic Halos

pharo
Updates:
        Labels: Milestone-2.0

Comment #5 on issue 7207 by [hidden email]: Solution for issue 3882  
introduced bugs with scaling and moving ImageMorphs using Morphic Halos
http://code.google.com/p/pharo/issues/detail?id=7207

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7207 in pharo: Solution for issue 3882 introduced bugs with scaling and moving ImageMorphs using Morphic Halos

pharo
Updates:
        Status: NoSourcesAvailable

Comment #6 on issue 7207 by [hidden email]: Solution for issue 3882  
introduced bugs with scaling and moving ImageMorphs using Morphic Halos
http://code.google.com/p/pharo/issues/detail?id=7207#c6

This Issue has been checked by Ulysse the Monkey, but no sources are  
available

Someone should have a look either to check the validity of the source or to  
report a strange behavior of a crazy monkey.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7207 in pharo: Solution for issue 3882 introduced bugs with scaling and moving ImageMorphs using Morphic Halos

pharo

Comment #7 on issue 7207 by [hidden email]: Solution for issue 3882  
introduced bugs with scaling and moving ImageMorphs using Morphic Halos
http://code.google.com/p/pharo/issues/detail?id=7207

Next action: make a slice


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7207 in pharo: Solution for issue 3882 introduced bugs with scaling and moving ImageMorphs using Morphic Halos

pharo
Updates:
        Status: FixToInclude

Comment #8 on issue 7207 by [hidden email]: Solution for issue 3882  
introduced bugs with scaling and moving ImageMorphs using Morphic Halos
http://code.google.com/p/pharo/issues/detail?id=7207

Looks good, thanks!
- Fixes 3882
- Fixes new DNU
- All Morphic and Polymorph tests pass

Fix in inbox:  
SLICE-Issue-7207-Solution-for-issue-3882-introduced-bugs-with-scaling-and-moving-ImageMorphs-using-Morphic-Halos--SeanDeNigris.1

Issue 3882 added #isFlexMorph to ImageMorph, which brings consequences only  
appropriate to TransformMorphs...

- Remove ImageMorph>>#isFlexMorph
- Replace with #shouldFlex, and integrate with system


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7207 in pharo: Solution for issue 3882 introduced bugs with scaling and moving ImageMorphs using Morphic Halos

pharo

Comment #9 on issue 7207 by [hidden email]: Solution for issue 3882  
introduced bugs with scaling and moving ImageMorphs using Morphic Halos
http://code.google.com/p/pharo/issues/detail?id=7207

Thanks!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7207 in pharo: Solution for issue 3882 introduced bugs with scaling and moving ImageMorphs using Morphic Halos

pharo
Updates:
        Status: Integrated

Comment #10 on issue 7207 by [hidden email]: Solution for issue 3882  
introduced bugs with scaling and moving ImageMorphs using Morphic Halos
http://code.google.com/p/pharo/issues/detail?id=7207

in 20488


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker