Issue 7209 in pharo: ChangesBrowser should execute refactorings in order

Status: New
Owner: ----
Labels: Milestone-2.0 Type-Bug

New issue 7209 by [hidden email]: ChangesBrowser should execute  
refactorings in order
http://code.google.com/p/pharo/issues/detail?id=7209

The ChangesBrowser does not preserve the order refactorings are specified...

To reproduce execute the following snippet in Pharo 2.0, and click accept

|model className|
model := RBNamespace  new .
className := 'ANewClassForTheSystem' asSymbol.
model defineClass:
                ('<1s>
                subclass: #<2s>
                instanceVariableNames: ''''
                classVariableNames: ''''
                poolDictionaries: ''''
                category: <3p>' expandMacrosWith: 'NBExternalStructure' with: className  
with: 'JustTesting').
               
model compile: 'myInstanceMethod  ^''Hello world'' '
            in: (model classNamed: className)
            classified: 'method declaration'.
model compile: 'myClassMethod   ^self new '
            in: (model metaclassNamed: className)
            classified: 'method declaration'.
(ChangesBrowser new change: model changes  ) openWithSpec.

The problem seems to come from the PickListModel usage of a Set instance to  
hold the item list. Just changing it to an OrderedCollection fixes this  
issue (however there may be side effects).



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Accepted
        Labels: -Milestone-2.0

Comment #1 on issue 7209 by [hidden email]: ChangesBrowser should  
execute refactorings in order
http://code.google.com/p/pharo/issues/detail?id=7209

Yes, but as this has been like this for a long time it is not a show  
stopper for 2.0, I think
(but if it is fixed we will of course add the fix).

I will remove the label Milestone-2.0


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Milestone-2.0

Comment #2 on issue 7209 by [hidden email]: ChangesBrowser should  
execute refactorings in order
http://code.google.com/p/pharo/issues/detail?id=7209

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 7209 by [hidden email]: ChangesBrowser should execute  
refactorings in order
http://code.google.com/p/pharo/issues/detail?id=7209

Should be solved by https://code.google.com/p/pharo/issues/detail?id=7310


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Blockedon: pharo:7310

Comment #4 on issue 7209 by [hidden email]: ChangesBrowser should  
execute refactorings in order
http://code.google.com/p/pharo/issues/detail?id=7209

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #5 on issue 7209 by [hidden email]: ChangesBrowser should  
execute refactorings in order
http://code.google.com/p/pharo/issues/detail?id=7209

Slice in the inbox fixing the order issue


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #6 on issue 7209 by [hidden email]: ChangesBrowser should  
execute refactorings in order
http://code.google.com/p/pharo/issues/detail?id=7209#c6

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20517

Comment #7 on issue 7209 by [hidden email]: ChangesBrowser should  
execute refactorings in order
http://code.google.com/p/pharo/issues/detail?id=7209#c7

This Issue has been checked by Ulysse the Monkey
       
6384 tests passed in 00:01:15s:
===============================
        CollectionsTests-Arrayed (553)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (912)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (611)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1954)
        CollectionsTests-Weak (739)
        CompilerTests (181)
        KernelTests-Chronology (593)
        KernelTests-Classes (69)
        KernelTests-Exception (2)
        KernelTests-Methods (179)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (38)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-7209-ChangesBrowser-should-execute-refactorings-in-order-BenjaminVanRyseghem.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20517-a on NBCoInterpreter  
NativeBoost-CogPlugin-IgorStasenko.15 uuid:  
44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012
NBCogit NativeBoost-CogPlugin-IgorStasenko.15 uuid:  
44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
40ac7e7bdec6fef0e934d2c019b86db996053912 Date: 2012-11-19 18:54:49 +0100  
By: Mariano Martinez Peck <[hidden email]> Jenkins build #146


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #8 on issue 7209 by [hidden email]: ChangesBrowser should  
execute refactorings in order
http://code.google.com/p/pharo/issues/detail?id=7209

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #9 on issue 7209 by [hidden email]: ChangesBrowser should  
execute refactorings in order
http://code.google.com/p/pharo/issues/detail?id=7209

in 2.0 419


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker