Issue 7224 in pharo: Failing test related to RB

Status: FailingTest
Owner: [hidden email]
Labels: Type-FailingTest Milestone-2.0

New issue 7224 by [hidden email]: Failing test related to RB
http://code.google.com/p/pharo/issues/detail?id=7224

Refactoring.Tests.Critics.RBSmalllintTest.testBadMessage
>>> Refactoring.Tests.Core.RBPullUpMethodTest.testPullUpWithMethodThatCannotBePushedDown
>>> Refactoring.Tests.Core.RBPushDownMethodTest.testPushDownMethodOnNonAbstractClass


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 7224 by [hidden email]: Failing test related to  
RB
http://code.google.com/p/pharo/issues/detail?id=7224

looking into it right now


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 7224 by [hidden email]: Failing test related to  
RB
http://code.google.com/p/pharo/issues/detail?id=7224

these tests pass in 20400


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 7224 by [hidden email]: Failing test related to  
RB
http://code.google.com/p/pharo/issues/detail?id=7224

Something was introduced between 20427 and 20437 that massively slows down  
the RB tests and breaks the two tests above!!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 7224 by [hidden email]: Failing test related to  
RB
http://code.google.com/p/pharo/issues/detail?id=7224

testPullUpWithMethodThatCannotBePushedDown fails for the first time in  
20430, which is combined with the massive slow down. I cannot directly  
think of something that could have caused it, the only thing integrated was  
NativeBoost :/


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #5 on issue 7224 by [hidden email]: Failing test related to  
RB
http://code.google.com/p/pharo/issues/detail?id=7224

got the bastard :D

Since NativeBoost extends Object it is considered as Abstract, since now it  
has a #nbLibraryNameOrHandle in:

nbLibraryNameOrHandle
        ^self subclassResponsibility



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 7224 by [hidden email]: Failing test related to  
RB
http://code.google.com/p/pharo/issues/detail?id=7224

got the bastard :D

Since NativeBoost extends Object it is considered as Abstract, since now it  
has a #subclassResponsibility in:

Object>>#nbLibraryNameOrHandle
        ^self subclassResponsibility

So now we have the proof that extending object is a bad idea :P


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 7224 by [hidden email]: Failing test related to RB
http://code.google.com/p/pharo/issues/detail?id=7224

:)

Object>>#nbLibraryNameOrHandle
        ^self errror: 'subclassResponsibility'


of course we can live without this extension (but then people will start  
asking questions like why i got DNU with #nbLibraryNameOrHandle :)

i wonder what is better - to have this extension, or answering same  
question "why i got dnu" for the rest of the time.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 7224 by [hidden email]: Failing test related to  
RB
http://code.google.com/p/pharo/issues/detail?id=7224

:)



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #9 on issue 7224 by [hidden email]: Failing test related to  
RB
http://code.google.com/p/pharo/issues/detail?id=7224

Name: SLICE-Issue-7224-Failing-test-related-to-RB-CamilloBruni.1
Author: CamilloBruni
Time: 13 January 2013, 6:22:51.698 pm
UUID: 453718b1-e8b3-44bd-91de-ae331fa99e30
Ancestors:
Dependencies: NativeBoost-Core-CamilloBruni.97,  
Refactoring-Core-CamilloBruni.168, Refactoring-Tests-Core-CamilloBruni.58

- minor source code refactoring of some RB methods
- change #nbLibraryNameOrHandle to not do a direct #subclassResponsibility  
send to not break the RB tests


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #10 on issue 7224 by [hidden email]: Failing test related to  
RB
http://code.google.com/p/pharo/issues/detail?id=7224

in 2.0 469


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker