Issue 7238 in pharo: LazyListMorph>>selectionFrameForRow: fails with a 'should not happen' from Rectangle>>intersect:ifNone:

Status: New
Owner: ----
Labels: Milestone-2.0 Type-Bug

New issue 7238 by [hidden email]: LazyListMorph>>selectionFrameForRow: fails  
with a 'should not happen' from Rectangle>>intersect:ifNone:
http://code.google.com/p/pharo/issues/detail?id=7238

In #20468, open the Settings Browser, search for background

LazyListMorph(Object)>>error:
LazyListMorph>>selectionFrameForRow: in Block: [self error: ' should not  
happen ']
Rectangle>>intersect:ifNone:
LazyListMorph>>selectionFrameForRow:
LazyListMorph>>selectionFrameChanged
LazyListMorph>>selectedRow:
PluggableListMorph>>selectionIndex:
PluggableListMorph>>update:
EditableDropListMorph(Object)>>changed: in Block: [:aDependent | aDependent  
update: aParameter]
DependentsArray>>do:
EditableDropListMorph(Object)>>changed:
EditableDropListMorph(DropListMorph)>>updateListSelectionIndex
EditableDropListMorph(DropListMorph)>>on:list:selected:changeSelected:
EditableDropListMorph class(DropListMorph  
class)>>on:list:selected:changeSelected:useIndex:
EditableDropListMorph  
class>>on:list:selected:changeSelected:useIndex:addToList:class:getEnabled:default:
SettingDeclaration>>inputWidgetForFileOrDirectoryWithAction:
FilePath class>>settingInputWidgetForNode:
SettingDeclaration>>inputWidget
SettingDeclaration(PragmaSetting)>>inputMorphFor:
SettingDeclaration>>inputMorphFor:
SettingNode>>inputMorphFor:
MorphTreeColumn>>rowMorphGetterBlock in Block: [:node :cont | node perform:  
self rowMorphGetSelec...etc...
MorphTreeColumn>>rowMorphFor:
MorphTreeNodeMorph>>buildRowMorph in Block: [:col | ...
OrderedCollection>>collect:
MorphTreeNodeMorph>>buildRowMorph
MorphTreeNodeMorph>>initRow
MorphTreeNodeMorph>>initWithContents:prior:forList:indentLevel:
MorphTreeMorph>>addMorphsAfter:fromCollection: in Block: [:item | ...
OrderedCollection>>do:



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #1 on issue 7238 by [hidden email]:  
LazyListMorph>>selectionFrameForRow: fails with a 'should not happen' from  
Rectangle>>intersect:ifNone:
http://code.google.com/p/pharo/issues/detail?id=7238

thanks sven



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #2 on issue 7238 by [hidden email]:  
LazyListMorph>>selectionFrameForRow: fails with a 'should not happen' from  
Rectangle>>intersect:ifNone:
http://code.google.com/p/pharo/issues/detail?id=7238

Well, it seems a bit hard to reproduce

Open Settings Browser, click Expand All button gives the same error.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: QualityControl

Comment #3 on issue 7238 by [hidden email]:  
LazyListMorph>>selectionFrameForRow: fails with a 'should not happen' from  
Rectangle>>intersect:ifNone:
http://code.google.com/p/pharo/issues/detail?id=7238

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #4 on issue 7238 by [hidden email]:  
LazyListMorph>>selectionFrameForRow: fails with a 'should not happen' from  
Rectangle>>intersect:ifNone:
http://code.google.com/p/pharo/issues/detail?id=7238

Use  
https://ci.inria.fr/pharo/view/Pharo-2.0/job/Pharo-2.0/lastSuccessfulBuild/artifact/20486.zip

and open the Settings, then open the Network node

=> should be reproducable with this


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #5 on issue 7238 by [hidden email]:  
LazyListMorph>>selectionFrameForRow: fails with a 'should not happen' from  
Rectangle>>intersect:ifNone:
http://code.google.com/p/pharo/issues/detail?id=7238

If I replace the error raising line with

frame := frame intersect: self bounds ifNone: [ self bounds ].

it works. But this is only a workaround.

We should ask Igor since he added this error in December 2012


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded-NextAction
        Labels: -Type-Bug Type-FirstImpressionsCount

Comment #6 on issue 7238 by [hidden email]:  
LazyListMorph>>selectionFrameForRow: fails with a 'should not happen' from  
Rectangle>>intersect:ifNone:
http://code.google.com/p/pharo/issues/detail?id=7238

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 7238 by [hidden email]:  
LazyListMorph>>selectionFrameForRow: fails with a 'should not happen' from  
Rectangle>>intersect:ifNone:
http://code.google.com/p/pharo/issues/detail?id=7238

Yes now we are in a better situation to fix than by then.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email] [hidden email]
        Labels: Importance-High

Comment #8 on issue 7238 by [hidden email]:  
LazyListMorph>>selectionFrameForRow: fails with a 'should not happen' from  
Rectangle>>intersect:ifNone:
http://code.google.com/p/pharo/issues/detail?id=7238

I've been encountering this a lot in 2051x


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #9 on issue 7238 by [hidden email]:  
LazyListMorph>>selectionFrameForRow: fails with a 'should not happen' from  
Rectangle>>intersect:ifNone:
http://code.google.com/p/pharo/issues/detail?id=7238

I've been looking at it with Igor. Some checks were added in rectangle  
intersection calculation, producing the error... We tried modifying a bit  
the rectangle comparison code and it looks it's working.

Put Slice in inbox, monkey check?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #10 on issue 7238 by [hidden email]:  
LazyListMorph>>selectionFrameForRow: fails with a 'should not happen' from  
Rectangle>>intersect:ifNone:
http://code.google.com/p/pharo/issues/detail?id=7238#c10

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20528

Comment #11 on issue 7238 by [hidden email]:  
LazyListMorph>>selectionFrameForRow: fails with a 'should not happen' from  
Rectangle>>intersect:ifNone:
http://code.google.com/p/pharo/issues/detail?id=7238#c11

This Issue has been checked by Ulysse the Monkey
       
7632 tests passed in 00:04:57s:
===============================
        CollectionsTests-Arrayed (553)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (912)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (611)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1954)
        CollectionsTests-Weak (739)
        CompilerTests (181)
        KernelTests-Chronology (1186)
        KernelTests-Classes (138)
        KernelTests-Exception (5)
        KernelTests-Methods (359)
        KernelTests-Numbers (552)
        KernelTests-Objects (172)
        KernelTests-Pragmas (6)
        KernelTests-Processes (76)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-7238-LazyListMorphgtgtselectionFrameForRow-fails-with-a-should-not-happen-from-RectanglegtgtintersectifNone-GuillermoPolito.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20528-a on NBCoInterpreter  
NativeBoost-CogPlugin-IgorStasenko.15 uuid:  
44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012
NBCogit NativeBoost-CogPlugin-IgorStasenko.15 uuid:  
44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
40ac7e7bdec6fef0e934d2c019b86db996053912 Date: 2012-11-19 18:54:49 +0100  
By: Mariano Martinez Peck <[hidden email]> Jenkins build #146


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Issue 7238: LazyListMorph>>selectionFrameForRow: fails with a 'should not  
happen' from Rectangle>>intersect:ifNone:
http://code.google.com/p/pharo/issues/detail?id=7238

This issue is now blocking issue pharo:7102.
See http://code.google.com/p/pharo/issues/detail?id=7102

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #13 on issue 7238 by [hidden email]:  
LazyListMorph>>selectionFrameForRow: fails with a 'should not happen' from  
Rectangle>>intersect:ifNone:
http://code.google.com/p/pharo/issues/detail?id=7238

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #14 on issue 7238 by [hidden email]:  
LazyListMorph>>selectionFrameForRow: fails with a 'should not happen' from  
Rectangle>>intersect:ifNone:
http://code.google.com/p/pharo/issues/detail?id=7238

I can't load the slice via the MC Browser due to "Issue 6541: Error: cannot  
remove non empty category", but it does fix the problem. I wonder how the  
monkey was able to load it...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #15 on issue 7238 by [hidden email]:  
LazyListMorph>>selectionFrameForRow: fails with a 'should not happen' from  
Rectangle>>intersect:ifNone:
http://code.google.com/p/pharo/issues/detail?id=7238

in 2.0 529


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker